2015-06-26 08:01:10

by Maninder Singh

Subject: [PATCH v2] drm/amdgpu: use kzalloc for allocating one thing

Use kzalloc rather than kcalloc(1.. for allocating
one thing.

Signed-off-by: Maninder Singh <[email protected]>
Reviewed-by: Vaneet Narang <[email protected]>
Reviewed-by: Christian Konig <[email protected]>
---
v2: Chnged shortlog prefix - gpu/amdgpu

drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
index d3706a4..dd3415d 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
@@ -674,7 +674,7 @@ static int amdgpu_ttm_tt_populate(struct ttm_tt *ttm)
return 0;

if (gtt && gtt->userptr) {
- ttm->sg = kcalloc(1, sizeof(struct sg_table), GFP_KERNEL);
+ ttm->sg = kzalloc(sizeof(struct sg_table), GFP_KERNEL);
if (!ttm->sg)
return -ENOMEM;

--
1.7.9.5

2015-06-26 16:54:46

by Alex Deucher

Subject: Re: [PATCH v2] drm/amdgpu: use kzalloc for allocating one thing

On Fri, Jun 26, 2015 at 3:58 AM, Maninder Singh <[email protected]> wrote:
> Use kzalloc rather than kcalloc(1.. for allocating
> one thing.
>
> Signed-off-by: Maninder Singh <[email protected]>
> Reviewed-by: Vaneet Narang <[email protected]>
> Reviewed-by: Christian Konig <[email protected]>
> ---
> v2: Chnged shortlog prefix - gpu/amdgpu

Applied. thanks!

Alex

>
> drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
> index d3706a4..dd3415d 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
> @@ -674,7 +674,7 @@ static int amdgpu_ttm_tt_populate(struct ttm_tt *ttm)
> return 0;
>
> if (gtt && gtt->userptr) {
> - ttm->sg = kcalloc(1, sizeof(struct sg_table), GFP_KERNEL);
> + ttm->sg = kzalloc(sizeof(struct sg_table), GFP_KERNEL);
> if (!ttm->sg)
> return -ENOMEM;
>
> --
> 1.7.9.5
>
> _______________________________________________
> dri-devel mailing list
> [email protected]
> http://lists.freedesktop.org/mailman/listinfo/dri-devel