2023-08-02 02:33:09

by Ran Sun

Subject: [PATCH] drm/amd/pm: Clean up errors in smu75.h

Fix the following errors reported by checkpatch:

ERROR: space prohibited before open square bracket '['
ERROR: "foo * bar" should be "foo *bar"

Signed-off-by: Ran Sun <[email protected]>
---
drivers/gpu/drm/amd/pm/powerplay/inc/smu75.h | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/amd/pm/powerplay/inc/smu75.h b/drivers/gpu/drm/amd/pm/powerplay/inc/smu75.h
index 771523001533..7d5ed7751976 100644
--- a/drivers/gpu/drm/amd/pm/powerplay/inc/smu75.h
+++ b/drivers/gpu/drm/amd/pm/powerplay/inc/smu75.h
@@ -224,8 +224,8 @@ struct SMU7_LocalDpmScoreboard {
uint8_t DteClampMode;
uint8_t FpsClampMode;

- uint16_t LevelResidencyCounters [SMU75_MAX_LEVELS_GRAPHICS];
- uint16_t LevelSwitchCounters [SMU75_MAX_LEVELS_GRAPHICS];
+ uint16_t LevelResidencyCounters[SMU75_MAX_LEVELS_GRAPHICS];
+ uint16_t LevelSwitchCounters[SMU75_MAX_LEVELS_GRAPHICS];

void (*TargetStateCalculator)(uint8_t);
void (*SavedTargetStateCalculator)(uint8_t);
@@ -316,7 +316,7 @@ struct SMU7_VoltageScoreboard {

VoltageChangeHandler_t functionLinks[6];

- uint16_t * VddcFollower1;
+ uint16_t *VddcFollower1;
int16_t Driver_OD_RequestedVidOffset1;
int16_t Driver_OD_RequestedVidOffset2;
};
@@ -677,9 +677,9 @@ typedef struct SCS_CELL_t SCS_CELL_t;

struct VFT_TABLE_t {
VFT_CELL_t Cell[TEMP_RANGE_MAXSTEPS][NUM_VFT_COLUMNS];
- uint16_t AvfsGbv [NUM_VFT_COLUMNS];
- uint16_t BtcGbv [NUM_VFT_COLUMNS];
- int16_t Temperature [TEMP_RANGE_MAXSTEPS];
+ uint16_t AvfsGbv[NUM_VFT_COLUMNS];
+ uint16_t BtcGbv[NUM_VFT_COLUMNS];
+ int16_t Temperature[TEMP_RANGE_MAXSTEPS];

#ifdef SMU__FIRMWARE_SCKS_PRESENT__1
SCS_CELL_t ScksCell[TEMP_RANGE_MAXSTEPS][NUM_VFT_COLUMNS];
--
2.17.1

2023-08-07 17:36:15

by Alex Deucher

Subject: Re: [PATCH] drm/amd/pm: Clean up errors in smu75.h

Applied. Thanks!

On Tue, Aug 1, 2023 at 9:59 PM Ran Sun <[email protected]> wrote:
>
> Fix the following errors reported by checkpatch:
>
> ERROR: space prohibited before open square bracket '['
> ERROR: "foo * bar" should be "foo *bar"
>
> Signed-off-by: Ran Sun <[email protected]>
> ---
> drivers/gpu/drm/amd/pm/powerplay/inc/smu75.h | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/powerplay/inc/smu75.h b/drivers/gpu/drm/amd/pm/powerplay/inc/smu75.h
> index 771523001533..7d5ed7751976 100644
> --- a/drivers/gpu/drm/amd/pm/powerplay/inc/smu75.h
> +++ b/drivers/gpu/drm/amd/pm/powerplay/inc/smu75.h
> @@ -224,8 +224,8 @@ struct SMU7_LocalDpmScoreboard {
> uint8_t DteClampMode;
> uint8_t FpsClampMode;
>
> - uint16_t LevelResidencyCounters [SMU75_MAX_LEVELS_GRAPHICS];
> - uint16_t LevelSwitchCounters [SMU75_MAX_LEVELS_GRAPHICS];
> + uint16_t LevelResidencyCounters[SMU75_MAX_LEVELS_GRAPHICS];
> + uint16_t LevelSwitchCounters[SMU75_MAX_LEVELS_GRAPHICS];
>
> void (*TargetStateCalculator)(uint8_t);
> void (*SavedTargetStateCalculator)(uint8_t);
> @@ -316,7 +316,7 @@ struct SMU7_VoltageScoreboard {
>
> VoltageChangeHandler_t functionLinks[6];
>
> - uint16_t * VddcFollower1;
> + uint16_t *VddcFollower1;
> int16_t Driver_OD_RequestedVidOffset1;
> int16_t Driver_OD_RequestedVidOffset2;
> };
> @@ -677,9 +677,9 @@ typedef struct SCS_CELL_t SCS_CELL_t;
>
> struct VFT_TABLE_t {
> VFT_CELL_t Cell[TEMP_RANGE_MAXSTEPS][NUM_VFT_COLUMNS];
> - uint16_t AvfsGbv [NUM_VFT_COLUMNS];
> - uint16_t BtcGbv [NUM_VFT_COLUMNS];
> - int16_t Temperature [TEMP_RANGE_MAXSTEPS];
> + uint16_t AvfsGbv[NUM_VFT_COLUMNS];
> + uint16_t BtcGbv[NUM_VFT_COLUMNS];
> + int16_t Temperature[TEMP_RANGE_MAXSTEPS];
>
> #ifdef SMU__FIRMWARE_SCKS_PRESENT__1
> SCS_CELL_t ScksCell[TEMP_RANGE_MAXSTEPS][NUM_VFT_COLUMNS];
> --
> 2.17.1
>