2022-12-19 14:29:53

by Jiapeng Chong

[permalink] [raw]
Subject: [PATCH] drm/amd/display: Remove the unused function dmub_outbox_irq_info_funcs

The function dmub_outbox_irq_info_funcs is defined in the
irq_service_dcn201.c file, but not called elsewhere, so remove this
unused function.

drivers/gpu/drm/amd/amdgpu/../display/dc/irq/dcn201/irq_service_dcn201.c:139:43: warning: unused variable 'dmub_outbox_irq_info_funcs'.

Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3520
Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Jiapeng Chong <[email protected]>
---
.../gpu/drm/amd/display/dc/irq/dcn201/irq_service_dcn201.c | 5 -----
1 file changed, 5 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/dc/irq/dcn201/irq_service_dcn201.c b/drivers/gpu/drm/amd/display/dc/irq/dcn201/irq_service_dcn201.c
index 5f4f6dd79511..27dc8c9955f4 100644
--- a/drivers/gpu/drm/amd/display/dc/irq/dcn201/irq_service_dcn201.c
+++ b/drivers/gpu/drm/amd/display/dc/irq/dcn201/irq_service_dcn201.c
@@ -136,11 +136,6 @@ static const struct irq_source_info_funcs vupdate_no_lock_irq_info_funcs = {
.ack = NULL
};

-static const struct irq_source_info_funcs dmub_outbox_irq_info_funcs = {
- .set = NULL,
- .ack = NULL
-};
-
#undef BASE_INNER
#define BASE_INNER(seg) DMU_BASE__INST0_SEG ## seg

--
2.20.1.7.g153144c


2022-12-21 21:30:46

by Alex Deucher

[permalink] [raw]
Subject: Re: [PATCH] drm/amd/display: Remove the unused function dmub_outbox_irq_info_funcs

Applied. Thanks!

Alex

On Mon, Dec 19, 2022 at 9:22 AM Jiapeng Chong
<[email protected]> wrote:
>
> The function dmub_outbox_irq_info_funcs is defined in the
> irq_service_dcn201.c file, but not called elsewhere, so remove this
> unused function.
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/irq/dcn201/irq_service_dcn201.c:139:43: warning: unused variable 'dmub_outbox_irq_info_funcs'.
>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3520
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Jiapeng Chong <[email protected]>
> ---
> .../gpu/drm/amd/display/dc/irq/dcn201/irq_service_dcn201.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/irq/dcn201/irq_service_dcn201.c b/drivers/gpu/drm/amd/display/dc/irq/dcn201/irq_service_dcn201.c
> index 5f4f6dd79511..27dc8c9955f4 100644
> --- a/drivers/gpu/drm/amd/display/dc/irq/dcn201/irq_service_dcn201.c
> +++ b/drivers/gpu/drm/amd/display/dc/irq/dcn201/irq_service_dcn201.c
> @@ -136,11 +136,6 @@ static const struct irq_source_info_funcs vupdate_no_lock_irq_info_funcs = {
> .ack = NULL
> };
>
> -static const struct irq_source_info_funcs dmub_outbox_irq_info_funcs = {
> - .set = NULL,
> - .ack = NULL
> -};
> -
> #undef BASE_INNER
> #define BASE_INNER(seg) DMU_BASE__INST0_SEG ## seg
>
> --
> 2.20.1.7.g153144c
>