2022-05-08 14:38:10

by CGEL

Subject: [PATCH] drm/amdgpu: simplify the return expression of vega10_ih_hw_init()

From: Minghao Chi <[email protected]>

Simplify the return expression.

Reported-by: Zeal Robot <[email protected]>
Signed-off-by: Minghao Chi <[email protected]>
---
drivers/gpu/drm/amd/amdgpu/vega10_ih.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/vega10_ih.c b/drivers/gpu/drm/amd/amdgpu/vega10_ih.c
index 3070466f54e1..cdd599a08125 100644
--- a/drivers/gpu/drm/amd/amdgpu/vega10_ih.c
+++ b/drivers/gpu/drm/amd/amdgpu/vega10_ih.c
@@ -521,14 +521,9 @@ static int vega10_ih_sw_fini(void *handle)

static int vega10_ih_hw_init(void *handle)
{
- int r;
struct amdgpu_device *adev = (struct amdgpu_device *)handle;

- r = vega10_ih_irq_init(adev);
- if (r)
- return r;
-
- return 0;
+ return vega10_ih_irq_init(adev);
}

static int vega10_ih_hw_fini(void *handle)
--
2.25.1

2022-05-09 02:38:01

by Alex Deucher

Subject: Re: [PATCH] drm/amdgpu: simplify the return expression of vega10_ih_hw_init()

Applied. Thanks!

Alex

On Wed, May 4, 2022 at 10:22 PM <[email protected]> wrote:
>
> From: Minghao Chi <[email protected]>
>
> Simplify the return expression.
>
> Reported-by: Zeal Robot <[email protected]>
> Signed-off-by: Minghao Chi <[email protected]>
> ---
> drivers/gpu/drm/amd/amdgpu/vega10_ih.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/vega10_ih.c b/drivers/gpu/drm/amd/amdgpu/vega10_ih.c
> index 3070466f54e1..cdd599a08125 100644
> --- a/drivers/gpu/drm/amd/amdgpu/vega10_ih.c
> +++ b/drivers/gpu/drm/amd/amdgpu/vega10_ih.c
> @@ -521,14 +521,9 @@ static int vega10_ih_sw_fini(void *handle)
>
> static int vega10_ih_hw_init(void *handle)
> {
> - int r;
> struct amdgpu_device *adev = (struct amdgpu_device *)handle;
>
> - r = vega10_ih_irq_init(adev);
> - if (r)
> - return r;
> -
> - return 0;
> + return vega10_ih_irq_init(adev);
> }
>
> static int vega10_ih_hw_fini(void *handle)
> --
> 2.25.1
>
>