2022-04-16 02:07:13

by Tales Aparecida

Subject: [PATCH 0/2] Update AMDGPU glossary and MAINTAINERS

I was handling the request from [0] and then I noticed that some AMD
developers were missing from get_maintainers output due to the lack of a
reference to their documentation in the MAINTAINERS file.

[0] https://gitlab.freedesktop.org/drm/amd/-/issues/1939#note_1309737

Tales Lelo da Aparecida (2):
Documentation/gpu: Add entries to amdgpu glossary
MAINTAINERS: add docs entry to AMDGPU

Documentation/gpu/amdgpu/amdgpu-glossary.rst | 13 +++++++++++++
MAINTAINERS | 1 +
2 files changed, 14 insertions(+)

--
2.35.1

2022-04-16 02:15:13

by Tales Aparecida

Subject: [PATCH 1/2] Documentation/gpu: Add entries to amdgpu glossary

Add missing acronyms to the amdgppu glossary.

Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/1939#note_1309737
Signed-off-by: Tales Lelo da Aparecida <[email protected]>
---
Documentation/gpu/amdgpu/amdgpu-glossary.rst | 13 +++++++++++++
1 file changed, 13 insertions(+)

diff --git a/Documentation/gpu/amdgpu/amdgpu-glossary.rst b/Documentation/gpu/amdgpu/amdgpu-glossary.rst
index 859dcec6c6f9..48829d097f40 100644
--- a/Documentation/gpu/amdgpu/amdgpu-glossary.rst
+++ b/Documentation/gpu/amdgpu/amdgpu-glossary.rst
@@ -8,12 +8,19 @@ we have a dedicated glossary for Display Core at

.. glossary::

+ active_cu_number
+ The number of CUs that are active on the system. The number of active
+ CUs may be less than SE * SH * CU depending on the board configuration.
+
CP
Command Processor

CPLIB
Content Protection Library

+ CU
+ Compute unit
+
DFS
Digital Frequency Synthesizer

@@ -74,6 +81,12 @@ we have a dedicated glossary for Display Core at
SDMA
System DMA

+ SE
+ Shader Engine
+
+ SH
+ SHader array
+
SMU
System Management Unit

--
2.35.1

2022-04-18 01:54:49

by Christian König

Subject: Re: [PATCH 0/2] Update AMDGPU glossary and MAINTAINERS

Am 15.04.22 um 21:50 schrieb Tales Lelo da Aparecida:
> I was handling the request from [0] and then I noticed that some AMD
> developers were missing from get_maintainers output due to the lack of a
> reference to their documentation in the MAINTAINERS file.

Acked-by: Christian König <[email protected]>

>
> [0] https://gitlab.freedesktop.org/drm/amd/-/issues/1939#note_1309737
>
> Tales Lelo da Aparecida (2):
> Documentation/gpu: Add entries to amdgpu glossary
> MAINTAINERS: add docs entry to AMDGPU
>
> Documentation/gpu/amdgpu/amdgpu-glossary.rst | 13 +++++++++++++
> MAINTAINERS | 1 +
> 2 files changed, 14 insertions(+)
>

2022-04-18 03:30:21

by Paul Menzel

Subject: Re: [PATCH 1/2] Documentation/gpu: Add entries to amdgpu glossary

Dear Tales,


Thank you for your patch.

Am 15.04.22 um 21:50 schrieb Tales Lelo da Aparecida:
> Add missing acronyms to the amdgppu glossary.
>
> Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/1939#note_1309737
> Signed-off-by: Tales Lelo da Aparecida <[email protected]>
> ---
> Documentation/gpu/amdgpu/amdgpu-glossary.rst | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/Documentation/gpu/amdgpu/amdgpu-glossary.rst b/Documentation/gpu/amdgpu/amdgpu-glossary.rst
> index 859dcec6c6f9..48829d097f40 100644
> --- a/Documentation/gpu/amdgpu/amdgpu-glossary.rst
> +++ b/Documentation/gpu/amdgpu/amdgpu-glossary.rst
> @@ -8,12 +8,19 @@ we have a dedicated glossary for Display Core at
>
> .. glossary::
>
> + active_cu_number
> + The number of CUs that are active on the system. The number of active
> + CUs may be less than SE * SH * CU depending on the board configuration.
> +
> CP
> Command Processor
>
> CPLIB
> Content Protection Library
>
> + CU
> + Compute unit

Capitalize the U in *unit* as seems to be done in the rest of the files?

> +
> DFS
> Digital Frequency Synthesizer
>
> @@ -74,6 +81,12 @@ we have a dedicated glossary for Display Core at
> SDMA
> System DMA
>
> + SE
> + Shader Engine
> +
> + SH
> + SHader array

No idea if the H should be capitalized.

> +
> SMU
> System Management Unit
>


Kind regards,

Paul

2022-04-21 01:45:26

by Alex Deucher

Subject: Re: [PATCH 1/2] Documentation/gpu: Add entries to amdgpu glossary

Applied the series with minor fix to capitalize the U in Compute Unit. Thanks!

Alex

On Fri, Apr 15, 2022 at 3:52 PM Tales Lelo da Aparecida
<[email protected]> wrote:
>
> Add missing acronyms to the amdgppu glossary.
>
> Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/1939#note_1309737
> Signed-off-by: Tales Lelo da Aparecida <[email protected]>
> ---
> Documentation/gpu/amdgpu/amdgpu-glossary.rst | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/Documentation/gpu/amdgpu/amdgpu-glossary.rst b/Documentation/gpu/amdgpu/amdgpu-glossary.rst
> index 859dcec6c6f9..48829d097f40 100644
> --- a/Documentation/gpu/amdgpu/amdgpu-glossary.rst
> +++ b/Documentation/gpu/amdgpu/amdgpu-glossary.rst
> @@ -8,12 +8,19 @@ we have a dedicated glossary for Display Core at
>
> .. glossary::
>
> + active_cu_number
> + The number of CUs that are active on the system. The number of active
> + CUs may be less than SE * SH * CU depending on the board configuration.
> +
> CP
> Command Processor
>
> CPLIB
> Content Protection Library
>
> + CU
> + Compute unit
> +
> DFS
> Digital Frequency Synthesizer
>
> @@ -74,6 +81,12 @@ we have a dedicated glossary for Display Core at
> SDMA
> System DMA
>
> + SE
> + Shader Engine
> +
> + SH
> + SHader array
> +
> SMU
> System Management Unit
>
> --
> 2.35.1
>