2020-11-23 11:23:18

by Lee Jones

[permalink] [raw]
Subject: [PATCH 39/40] drm/amd/amdgpu/gmc_v9_0: Remove unused table 'ecc_umc_mcumc_status_addrs'

Fixes the following W=1 kernel build warning(s):

drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c:382:23: warning: ‘ecc_umc_mcumc_status_addrs’ defined but not used [-Wunused-const-variable=]

Cc: Alex Deucher <[email protected]>
Cc: "Christian König" <[email protected]>
Cc: David Airlie <[email protected]>
Cc: Daniel Vetter <[email protected]>
Cc: [email protected]
Cc: [email protected]
Signed-off-by: Lee Jones <[email protected]>
---
drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 35 ---------------------------
1 file changed, 35 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
index 0c3421d587e87..fbee43b4ba64d 100644
--- a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
@@ -379,41 +379,6 @@ static const uint32_t ecc_umc_mcumc_ctrl_mask_addrs[] = {
(0x001d43e0 + 0x00001800),
};

-static const uint32_t ecc_umc_mcumc_status_addrs[] = {
- (0x000143c2 + 0x00000000),
- (0x000143c2 + 0x00000800),
- (0x000143c2 + 0x00001000),
- (0x000143c2 + 0x00001800),
- (0x000543c2 + 0x00000000),
- (0x000543c2 + 0x00000800),
- (0x000543c2 + 0x00001000),
- (0x000543c2 + 0x00001800),
- (0x000943c2 + 0x00000000),
- (0x000943c2 + 0x00000800),
- (0x000943c2 + 0x00001000),
- (0x000943c2 + 0x00001800),
- (0x000d43c2 + 0x00000000),
- (0x000d43c2 + 0x00000800),
- (0x000d43c2 + 0x00001000),
- (0x000d43c2 + 0x00001800),
- (0x001143c2 + 0x00000000),
- (0x001143c2 + 0x00000800),
- (0x001143c2 + 0x00001000),
- (0x001143c2 + 0x00001800),
- (0x001543c2 + 0x00000000),
- (0x001543c2 + 0x00000800),
- (0x001543c2 + 0x00001000),
- (0x001543c2 + 0x00001800),
- (0x001943c2 + 0x00000000),
- (0x001943c2 + 0x00000800),
- (0x001943c2 + 0x00001000),
- (0x001943c2 + 0x00001800),
- (0x001d43c2 + 0x00000000),
- (0x001d43c2 + 0x00000800),
- (0x001d43c2 + 0x00001000),
- (0x001d43c2 + 0x00001800),
-};
-
static int gmc_v9_0_ecc_interrupt_state(struct amdgpu_device *adev,
struct amdgpu_irq_src *src,
unsigned type,
--
2.25.1


2020-11-24 23:40:45

by Alex Deucher

[permalink] [raw]
Subject: Re: [PATCH 39/40] drm/amd/amdgpu/gmc_v9_0: Remove unused table 'ecc_umc_mcumc_status_addrs'

On Mon, Nov 23, 2020 at 6:20 AM Lee Jones <[email protected]> wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c:382:23: warning: ‘ecc_umc_mcumc_status_addrs’ defined but not used [-Wunused-const-variable=]
>
> Cc: Alex Deucher <[email protected]>
> Cc: "Christian König" <[email protected]>
> Cc: David Airlie <[email protected]>
> Cc: Daniel Vetter <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> Signed-off-by: Lee Jones <[email protected]>

Applied. Thanks!

Alex

> ---
> drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 35 ---------------------------
> 1 file changed, 35 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
> index 0c3421d587e87..fbee43b4ba64d 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
> @@ -379,41 +379,6 @@ static const uint32_t ecc_umc_mcumc_ctrl_mask_addrs[] = {
> (0x001d43e0 + 0x00001800),
> };
>
> -static const uint32_t ecc_umc_mcumc_status_addrs[] = {
> - (0x000143c2 + 0x00000000),
> - (0x000143c2 + 0x00000800),
> - (0x000143c2 + 0x00001000),
> - (0x000143c2 + 0x00001800),
> - (0x000543c2 + 0x00000000),
> - (0x000543c2 + 0x00000800),
> - (0x000543c2 + 0x00001000),
> - (0x000543c2 + 0x00001800),
> - (0x000943c2 + 0x00000000),
> - (0x000943c2 + 0x00000800),
> - (0x000943c2 + 0x00001000),
> - (0x000943c2 + 0x00001800),
> - (0x000d43c2 + 0x00000000),
> - (0x000d43c2 + 0x00000800),
> - (0x000d43c2 + 0x00001000),
> - (0x000d43c2 + 0x00001800),
> - (0x001143c2 + 0x00000000),
> - (0x001143c2 + 0x00000800),
> - (0x001143c2 + 0x00001000),
> - (0x001143c2 + 0x00001800),
> - (0x001543c2 + 0x00000000),
> - (0x001543c2 + 0x00000800),
> - (0x001543c2 + 0x00001000),
> - (0x001543c2 + 0x00001800),
> - (0x001943c2 + 0x00000000),
> - (0x001943c2 + 0x00000800),
> - (0x001943c2 + 0x00001000),
> - (0x001943c2 + 0x00001800),
> - (0x001d43c2 + 0x00000000),
> - (0x001d43c2 + 0x00000800),
> - (0x001d43c2 + 0x00001000),
> - (0x001d43c2 + 0x00001800),
> -};
> -
> static int gmc_v9_0_ecc_interrupt_state(struct amdgpu_device *adev,
> struct amdgpu_irq_src *src,
> unsigned type,
> --
> 2.25.1
>
> _______________________________________________
> dri-devel mailing list
> [email protected]
> https://lists.freedesktop.org/mailman/listinfo/dri-devel