2021-10-07 19:23:36

by Colin King

Subject: [PATCH][next] drm/amd/display: Remove redundant initialization of variable result

From: Colin Ian King <[email protected]>

The variable result is being initialized with a value that is never
read, it is being updated immediately afterwards in both branches
of an if statement. The assignment is redundant and can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <[email protected]>
---
drivers/gpu/drm/amd/display/dc/core/dc_link_dpia.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link_dpia.c b/drivers/gpu/drm/amd/display/dc/core/dc_link_dpia.c
index 6936b9d549e5..8387767ec1b3 100644
--- a/drivers/gpu/drm/amd/display/dc/core/dc_link_dpia.c
+++ b/drivers/gpu/drm/amd/display/dc/core/dc_link_dpia.c
@@ -774,7 +774,7 @@ static enum link_training_result dpia_training_eq_phase(struct dc_link *link,
struct link_training_settings *lt_settings,
uint32_t hop)
{
- enum link_training_result result = LINK_TRAINING_EQ_FAIL_EQ;
+ enum link_training_result result;

if (link->lttpr_mode == LTTPR_MODE_NON_TRANSPARENT)
result = dpia_training_eq_non_transparent(link, lt_settings, hop);
--
2.32.0

2021-10-07 19:39:41

by Alex Deucher

Subject: Re: [PATCH][next] drm/amd/display: Remove redundant initialization of variable result

Applied. Thanks!

Alex

On Thu, Oct 7, 2021 at 8:06 AM Colin King <[email protected]> wrote:
>
> From: Colin Ian King <[email protected]>
>
> The variable result is being initialized with a value that is never
> read, it is being updated immediately afterwards in both branches
> of an if statement. The assignment is redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <[email protected]>
> ---
> drivers/gpu/drm/amd/display/dc/core/dc_link_dpia.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link_dpia.c b/drivers/gpu/drm/amd/display/dc/core/dc_link_dpia.c
> index 6936b9d549e5..8387767ec1b3 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc_link_dpia.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link_dpia.c
> @@ -774,7 +774,7 @@ static enum link_training_result dpia_training_eq_phase(struct dc_link *link,
> struct link_training_settings *lt_settings,
> uint32_t hop)
> {
> - enum link_training_result result = LINK_TRAINING_EQ_FAIL_EQ;
> + enum link_training_result result;
>
> if (link->lttpr_mode == LTTPR_MODE_NON_TRANSPARENT)
> result = dpia_training_eq_non_transparent(link, lt_settings, hop);
> --
> 2.32.0
>