2021-06-15 11:46:07

by Jiabing Wan

[permalink] [raw]
Subject: [PATCH] drm: display: Fix duplicate field initialization in dcn31

Fix the following coccicheck warning:
drivers/gpu/drm/amd/display/dc/dcn31/dcn31_resource.c:917:56-57:
pstate_enabled: first occurrence line 935, second occurrence line 937

Signed-off-by: Wan Jiabing <[email protected]>
---
drivers/gpu/drm/amd/display/dc/dcn31/dcn31_resource.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/display/dc/dcn31/dcn31_resource.c b/drivers/gpu/drm/amd/display/dc/dcn31/dcn31_resource.c
index 0d6cb6caad81..c67bc9544f5d 100644
--- a/drivers/gpu/drm/amd/display/dc/dcn31/dcn31_resource.c
+++ b/drivers/gpu/drm/amd/display/dc/dcn31/dcn31_resource.c
@@ -934,7 +934,6 @@ static const struct dc_debug_options debug_defaults_drv = {
.dmub_command_table = true,
.pstate_enabled = true,
.use_max_lb = true,
- .pstate_enabled = true,
.enable_mem_low_power = {
.bits = {
.vga = false,
--
2.20.1


2021-06-15 12:55:53

by Rodrigo Siqueira Jordao

[permalink] [raw]
Subject: Re: [PATCH] drm: display: Fix duplicate field initialization in dcn31

On 06/15, Wan Jiabing wrote:
> Fix the following coccicheck warning:
> drivers/gpu/drm/amd/display/dc/dcn31/dcn31_resource.c:917:56-57:
> pstate_enabled: first occurrence line 935, second occurrence line 937
>
> Signed-off-by: Wan Jiabing <[email protected]>
> ---
> drivers/gpu/drm/amd/display/dc/dcn31/dcn31_resource.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn31/dcn31_resource.c b/drivers/gpu/drm/amd/display/dc/dcn31/dcn31_resource.c
> index 0d6cb6caad81..c67bc9544f5d 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn31/dcn31_resource.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn31/dcn31_resource.c
> @@ -934,7 +934,6 @@ static const struct dc_debug_options debug_defaults_drv = {
> .dmub_command_table = true,
> .pstate_enabled = true,
> .use_max_lb = true,
> - .pstate_enabled = true,
> .enable_mem_low_power = {
> .bits = {
> .vga = false,
> --
> 2.20.1
>

Reviewed-by: Rodrigo Siqueira <[email protected]>

Thanks

--
Rodrigo Siqueira
https://siqueira.tech

Attachments:
(No filename) (1.05 kB)
 signature.asc (849.00 B)
 Download all attachments

2021-06-15 20:10:31

by Alex Deucher

[permalink] [raw]
Subject: Re: [PATCH] drm: display: Fix duplicate field initialization in dcn31

Applied. Thanks!


On Tue, Jun 15, 2021 at 8:54 AM Rodrigo Siqueira
<[email protected]> wrote:
>
> On 06/15, Wan Jiabing wrote:
> > Fix the following coccicheck warning:
> > drivers/gpu/drm/amd/display/dc/dcn31/dcn31_resource.c:917:56-57:
> > pstate_enabled: first occurrence line 935, second occurrence line 937
> >
> > Signed-off-by: Wan Jiabing <[email protected]>
> > ---
> > drivers/gpu/drm/amd/display/dc/dcn31/dcn31_resource.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/amd/display/dc/dcn31/dcn31_resource.c b/drivers/gpu/drm/amd/display/dc/dcn31/dcn31_resource.c
> > index 0d6cb6caad81..c67bc9544f5d 100644
> > --- a/drivers/gpu/drm/amd/display/dc/dcn31/dcn31_resource.c
> > +++ b/drivers/gpu/drm/amd/display/dc/dcn31/dcn31_resource.c
> > @@ -934,7 +934,6 @@ static const struct dc_debug_options debug_defaults_drv = {
> > .dmub_command_table = true,
> > .pstate_enabled = true,
> > .use_max_lb = true,
> > - .pstate_enabled = true,
> > .enable_mem_low_power = {
> > .bits = {
> > .vga = false,
> > --
> > 2.20.1
> >
>
> Reviewed-by: Rodrigo Siqueira <[email protected]>
>
> Thanks
>
> --
> Rodrigo Siqueira
> https://siqueira.tech
> _______________________________________________
> amd-gfx mailing list
> [email protected]
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx