2023-07-20 01:35:20

by Randy Dunlap

Subject: Re: [PATCH -next] drm/amdgpu: Fix one kernel-doc comment

On 7/19/23 18:05, Yang Li wrote:
> Use colon to separate parameter name from their specific meaning.
> silence the warning:
>
> drivers/gpu/drm/amd/amdgpu/amdgpu_vm_pt.c:793: warning: Function parameter or member 'adev' not described in 'amdgpu_vm_pte_update_noretry_flags'
>
> Signed-off-by: Yang Li <[email protected]>

Reviewed-by: Randy Dunlap <[email protected]>
Thanks.

> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_vm_pt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm_pt.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm_pt.c
> index 83e1923f6775..96d601e209b8 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm_pt.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm_pt.c
> @@ -783,7 +783,7 @@ int amdgpu_vm_pde_update(struct amdgpu_vm_update_params *params,
> /**
> * amdgpu_vm_pte_update_noretry_flags - Update PTE no-retry flags
> *
> - * @adev - amdgpu_device pointer
> + * @adev: amdgpu_device pointer
> * @flags: pointer to PTE flags
> *
> * Update PTE no-retry flags when TF is enabled.

--
~Randy

2023-07-20 17:37:01

by Alex Deucher

Subject: Re: [PATCH -next] drm/amdgpu: Fix one kernel-doc comment

Applied. Thanks!

On Wed, Jul 19, 2023 at 9:27 PM Randy Dunlap <[email protected]> wrote:
>
>
>
> On 7/19/23 18:05, Yang Li wrote:
> > Use colon to separate parameter name from their specific meaning.
> > silence the warning:
> >
> > drivers/gpu/drm/amd/amdgpu/amdgpu_vm_pt.c:793: warning: Function parameter or member 'adev' not described in 'amdgpu_vm_pte_update_noretry_flags'
> >
> > Signed-off-by: Yang Li <[email protected]>
>
> Reviewed-by: Randy Dunlap <[email protected]>
> Thanks.
>
> > ---
> > drivers/gpu/drm/amd/amdgpu/amdgpu_vm_pt.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm_pt.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm_pt.c
> > index 83e1923f6775..96d601e209b8 100644
> > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm_pt.c
> > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm_pt.c
> > @@ -783,7 +783,7 @@ int amdgpu_vm_pde_update(struct amdgpu_vm_update_params *params,
> > /**
> > * amdgpu_vm_pte_update_noretry_flags - Update PTE no-retry flags
> > *
> > - * @adev - amdgpu_device pointer
> > + * @adev: amdgpu_device pointer
> > * @flags: pointer to PTE flags
> > *
> > * Update PTE no-retry flags when TF is enabled.
>
> --
> ~Randy