2021-09-06 09:43:45

by Jiapeng Chong

Subject: [PATCH] drm/amd/display: make configure_lttpr_mode_transparent and configure_lttpr_mode_non_transparent static

From: chongjiapeng <[email protected]>

This symbols is not used outside of dc_link_dp.c, so marks it static.

Fix the following sparse warning:

drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c:1766:16:
warning: symbol 'configure_lttpr_mode_non_transparent' was not declared.
Should it be static?

drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c:1755:16:
warning: symbol 'configure_lttpr_mode_transparent' was not declared.
Should it be static?

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: chongjiapeng <[email protected]>
---
drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
index a666401..4e2cf8f 100644
--- a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
+++ b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
@@ -1752,7 +1752,7 @@ uint8_t dp_convert_to_count(uint8_t lttpr_repeater_count)
return 0; // invalid value
}

-enum dc_status configure_lttpr_mode_transparent(struct dc_link *link)
+static enum dc_status configure_lttpr_mode_transparent(struct dc_link *link)
{
uint8_t repeater_mode = DP_PHY_REPEATER_MODE_TRANSPARENT;

@@ -1763,7 +1763,7 @@ enum dc_status configure_lttpr_mode_transparent(struct dc_link *link)
sizeof(repeater_mode));
}

-enum dc_status configure_lttpr_mode_non_transparent(
+static enum dc_status configure_lttpr_mode_non_transparent(
struct dc_link *link,
const struct link_training_settings *lt_settings)
{
--
1.8.3.1

2021-09-07 17:45:42

by Alex Deucher

Subject: Re: [PATCH] drm/amd/display: make configure_lttpr_mode_transparent and configure_lttpr_mode_non_transparent static

Applied. Thanks!

Alex

On Mon, Sep 6, 2021 at 5:42 AM Jiapeng Chong
<[email protected]> wrote:
>
> From: chongjiapeng <[email protected]>
>
> This symbols is not used outside of dc_link_dp.c, so marks it static.
>
> Fix the following sparse warning:
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c:1766:16:
> warning: symbol 'configure_lttpr_mode_non_transparent' was not declared.
> Should it be static?
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c:1755:16:
> warning: symbol 'configure_lttpr_mode_transparent' was not declared.
> Should it be static?
>
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: chongjiapeng <[email protected]>
> ---
> drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
> index a666401..4e2cf8f 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
> @@ -1752,7 +1752,7 @@ uint8_t dp_convert_to_count(uint8_t lttpr_repeater_count)
> return 0; // invalid value
> }
>
> -enum dc_status configure_lttpr_mode_transparent(struct dc_link *link)
> +static enum dc_status configure_lttpr_mode_transparent(struct dc_link *link)
> {
> uint8_t repeater_mode = DP_PHY_REPEATER_MODE_TRANSPARENT;
>
> @@ -1763,7 +1763,7 @@ enum dc_status configure_lttpr_mode_transparent(struct dc_link *link)
> sizeof(repeater_mode));
> }
>
> -enum dc_status configure_lttpr_mode_non_transparent(
> +static enum dc_status configure_lttpr_mode_non_transparent(
> struct dc_link *link,
> const struct link_training_settings *lt_settings)
> {
> --
> 1.8.3.1
>