2021-05-04 23:42:15

by Stephen Rothwell

[permalink] [raw]
Subject: linux-next: build failure after merge of the amdgpu tree

Hi all,

After merging the amdgpu tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c: In function 'amdgpu_dm_initialize_drm_device':
drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:3728:7: error: implicit declaration of function 'register_outbox_irq_handlers'; did you mean 'register_hpd_handlers'? [-Werror=implicit-function-declaration]
3728 | if (register_outbox_irq_handlers(dm->adev)) {
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
| register_hpd_handlers

Caused by commit

77a49c458931 ("drm/amd/display: Support for DMUB AUX")

I have used the amdgpu tree from next-20210504 for today.

--
Cheers,
Stephen Rothwell


Attachments:
(No filename) (499.00 B)
OpenPGP digital signature

2021-05-09 22:52:07

by Stephen Rothwell

[permalink] [raw]
Subject: Re: linux-next: build failure after merge of the amdgpu tree

Hi all,

On Wed, 5 May 2021 09:34:58 +1000 Stephen Rothwell <[email protected]> wrote:
>
> After merging the amdgpu tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c: In function 'amdgpu_dm_initialize_drm_device':
> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:3728:7: error: implicit declaration of function 'register_outbox_irq_handlers'; did you mean 'register_hpd_handlers'? [-Werror=implicit-function-declaration]
> 3728 | if (register_outbox_irq_handlers(dm->adev)) {
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
> | register_hpd_handlers
>
> Caused by commit
>
> 77a49c458931 ("drm/amd/display: Support for DMUB AUX")
>
> I have used the amdgpu tree from next-20210504 for today.

This has now been broken for 6 days ... please fix or revert.

--
Cheers,
Stephen Rothwell


Attachments:
(No filename) (499.00 B)
OpenPGP digital signature

2021-05-10 15:07:50

by Alex Deucher

[permalink] [raw]
Subject: Re: linux-next: build failure after merge of the amdgpu tree

On Sun, May 9, 2021 at 6:46 PM Stephen Rothwell <[email protected]> wrote:
>
> Hi all,
>
> On Wed, 5 May 2021 09:34:58 +1000 Stephen Rothwell <[email protected]> wrote:
> >
> > After merging the amdgpu tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
> >
> > drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c: In function 'amdgpu_dm_initialize_drm_device':
> > drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:3728:7: error: implicit declaration of function 'register_outbox_irq_handlers'; did you mean 'register_hpd_handlers'? [-Werror=implicit-function-declaration]
> > 3728 | if (register_outbox_irq_handlers(dm->adev)) {
> > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > | register_hpd_handlers
> >
> > Caused by commit
> >
> > 77a49c458931 ("drm/amd/display: Support for DMUB AUX")
> >
> > I have used the amdgpu tree from next-20210504 for today.
>
> This has now been broken for 6 days ... please fix or revert.

Fixed in this patch set:
https://patchwork.freedesktop.org/series/89890/

Alex

>
> --
> Cheers,
> Stephen Rothwell

2021-05-10 22:19:51

by Stephen Rothwell

[permalink] [raw]
Subject: Re: linux-next: build failure after merge of the amdgpu tree

Hi Alex,

On Mon, 10 May 2021 10:24:58 -0400 Alex Deucher <[email protected]> wrote:
>
> Fixed in this patch set:
> https://patchwork.freedesktop.org/series/89890/

Sure, but that is not in the amdgpu tree that linux-next includes
(https://gitlab.freedesktop.org/agd5f/linux#drm-next). Did you forget
to push it out, or is it still being reviewed/tested?

--
Cheers,
Stephen Rothwell


Attachments:
(No filename) (499.00 B)
OpenPGP digital signature

2021-05-10 22:24:36

by Alex Deucher

[permalink] [raw]
Subject: Re: linux-next: build failure after merge of the amdgpu tree

On Mon, May 10, 2021 at 6:18 PM Stephen Rothwell <[email protected]> wrote:
>
> Hi Alex,
>
> On Mon, 10 May 2021 10:24:58 -0400 Alex Deucher <[email protected]> wrote:
> >
> > Fixed in this patch set:
> > https://patchwork.freedesktop.org/series/89890/
>
> Sure, but that is not in the amdgpu tree that linux-next includes
> (https://gitlab.freedesktop.org/agd5f/linux#drm-next). Did you forget
> to push it out, or is it still being reviewed/tested?

Was still being reviewed. I just pushed out the tree with it included.

Alex

>
> --
> Cheers,
> Stephen Rothwell

2021-05-10 23:03:36

by Stephen Rothwell

[permalink] [raw]
Subject: Re: linux-next: build failure after merge of the amdgpu tree

Hi Alex,

On Mon, 10 May 2021 18:23:35 -0400 Alex Deucher <[email protected]> wrote:
>
> On Mon, May 10, 2021 at 6:18 PM Stephen Rothwell <[email protected]> wrote:
> >
> > On Mon, 10 May 2021 10:24:58 -0400 Alex Deucher <[email protected]> wrote:
> > >
> > > Fixed in this patch set:
> > > https://patchwork.freedesktop.org/series/89890/
> >
> > Sure, but that is not in the amdgpu tree that linux-next includes
> > (https://gitlab.freedesktop.org/agd5f/linux#drm-next). Did you forget
> > to push it out, or is it still being reviewed/tested?
>
> Was still being reviewed. I just pushed out the tree with it included.

Excellent, thanks.

--
Cheers,
Stephen Rothwell


Attachments:
(No filename) (499.00 B)
OpenPGP digital signature