2023-07-10 01:36:26

by Stephen Rothwell

[permalink] [raw]
Subject: linux-next: Signed-off-by missing for commit in the amdgpu tree

Hi all,

Commit

aeddb7d13ad3 ("drm/amd/display: Block optimize on consecutive FAMS enables")

is missing a Signed-off-by from its author.

--
Cheers,
Stephen Rothwell

Attachments:
(No filename) (499.00 B)
OpenPGP digital signature

2023-07-10 13:33:38

by Aurabindo Pillai

[permalink] [raw]
Subject: Re: linux-next: Signed-off-by missing for commit in the amdgpu tree



On 7/9/2023 6:25 PM, Stephen Rothwell wrote:
> Hi all,
>
> Commit
>
> aeddb7d13ad3 ("drm/amd/display: Block optimize on consecutive FAMS enables")
>
> is missing a Signed-off-by from its author.
>

Hi Stephen,

Not sure how the tags went missing, but here is the full commit
(a7d8d8bcbd9af8d4aa1580bffd418af78384040f) information from
amd-staging-drm-next:


drm/amd/display: Block optimize on consecutive FAMS enables

[WHY]
It is possible to commit state multiple times in rapid succession with
FAMS enabled; if each of these commits were to set optimized_required,
then the user may see latency.

[HOW]
fw_based_mclk_switching is currently not used in dc->clk_mgr; use it
to track whether the current state has FAMS enabled;
if it has, then do not disable FAMS in prepare_bandwidth, and do
not set
optimized_required.

Reviewed-by: Rodrigo Siqueira <[email protected]>
Signed-off-by: Wesley Chalmers <[email protected]>
Tested-by: Daniel Wheeler <[email protected]>
Signed-off-by: Alex Deucher <[email protected]>
Acked-by: Hamza Mahfooz <[email protected]>


--

Thanks & Regards,
Aurabindo Pillai

2023-07-10 13:35:07

by Alex Deucher

[permalink] [raw]
Subject: Re: linux-next: Signed-off-by missing for commit in the amdgpu tree

On Mon, Jul 10, 2023 at 9:21 AM Aurabindo Pillai
<[email protected]> wrote:
>
>
>
> On 7/9/2023 6:25 PM, Stephen Rothwell wrote:
> > Hi all,
> >
> > Commit
> >
> > aeddb7d13ad3 ("drm/amd/display: Block optimize on consecutive FAMS enables")
> >
> > is missing a Signed-off-by from its author.
> >
>
> Hi Stephen,
>
> Not sure how the tags went missing, but here is the full commit
> (a7d8d8bcbd9af8d4aa1580bffd418af78384040f) information from
> amd-staging-drm-next:
>
>
> drm/amd/display: Block optimize on consecutive FAMS enables
>
> [WHY]
> It is possible to commit state multiple times in rapid succession with
> FAMS enabled; if each of these commits were to set optimized_required,
> then the user may see latency.
>
> [HOW]
> fw_based_mclk_switching is currently not used in dc->clk_mgr; use it
> to track whether the current state has FAMS enabled;
> if it has, then do not disable FAMS in prepare_bandwidth, and do
> not set
> optimized_required.
>
> Reviewed-by: Rodrigo Siqueira <[email protected]>
> Signed-off-by: Wesley Chalmers <[email protected]>
> Tested-by: Daniel Wheeler <[email protected]>
> Signed-off-by: Alex Deucher <[email protected]>
> Acked-by: Hamza Mahfooz <[email protected]>
>

I've fixed it up in my tree.

Alex