2024-05-07 06:00:03

by Krzysztof Kozlowski

Subject: [PATCH] clk: samsung: gs101: drop unused HSI2 clock parent data

Drop static const arrays with HSI2 clocks parent data which are not
referenced by any clock. This might cause -Werror=unused-const-variable
warnings.

Reported-by: Stephen Boyd <[email protected]>
Closes: https://lore.kernel.org/all/[email protected]/
Fixes: 093c290084a4 ("clk: samsung: gs101: add support for cmu_hsi2")
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/clk/samsung/clk-gs101.c | 15 ---------------
1 file changed, 15 deletions(-)

diff --git a/drivers/clk/samsung/clk-gs101.c b/drivers/clk/samsung/clk-gs101.c
index e2a6a1992505..ba9570f7a5fa 100644
--- a/drivers/clk/samsung/clk-gs101.c
+++ b/drivers/clk/samsung/clk-gs101.c
@@ -2601,21 +2601,6 @@ static const unsigned long cmu_hsi2_clk_regs[] __initconst = {
QUEUE_CTRL_REG_BLK_HSI2_CMU_HSI2,
};

-PNAME(mout_hsi2_ufs_embd_p) = { "oscclk", "dout_cmu_shared0_div4",
- "dout_cmu_shared2_div2", "fout_spare_pll" };
-
-PNAME(mout_hsi2_pcie_p) = { "oscclk", "dout_cmu_shared2_div2" };
-
-PNAME(mout_hsi2_bus_p) = { "dout_cmu_shared0_div4",
- "dout_cmu_shared1_div4",
- "dout_cmu_shared2_div2",
- "dout_cmu_shared3_div2",
- "fout_spare_pll", "oscclk", "oscclk",
- "oscclk" };
-
-PNAME(mout_hsi2_mmc_card_p) = { "fout_shared2_pll", "fout_shared3_pll",
- "dout_cmu_shared0_div4", "fout_spare_pll" };
-
PNAME(mout_hsi2_bus_user_p) = { "oscclk", "dout_cmu_hsi2_bus" };
PNAME(mout_hsi2_mmc_card_user_p) = { "oscclk", "dout_cmu_hsi2_mmc_card" };
PNAME(mout_hsi2_pcie_user_p) = { "oscclk", "dout_cmu_hsi2_pcie" };
--
2.43.0

2024-05-07 09:52:49

by Krzysztof Kozlowski

Subject: Re: [PATCH] clk: samsung: gs101: drop unused HSI2 clock parent data

On Tue, 07 May 2024 07:59:48 +0200, Krzysztof Kozlowski wrote:
> Drop static const arrays with HSI2 clocks parent data which are not
> referenced by any clock. This might cause -Werror=unused-const-variable
> warnings.
>
>

Applied, thanks!

[1/1] clk: samsung: gs101: drop unused HSI2 clock parent data
https://git.kernel.org/krzk/linux/c/7c18b0a5aa46cc7e5d3a7ef3f9f8e3aa91bb780f

Best regards,
--
Krzysztof Kozlowski <[email protected]>

2024-05-07 10:02:33

by Peter Griffin

Subject: Re: [PATCH] clk: samsung: gs101: drop unused HSI2 clock parent data

Hi Krzysztof,

On Tue, 7 May 2024 at 06:59, Krzysztof Kozlowski
<[email protected]> wrote:
>
> Drop static const arrays with HSI2 clocks parent data which are not
> referenced by any clock. This might cause -Werror=unused-const-variable
> warnings.
>
> Reported-by: Stephen Boyd <[email protected]>
> Closes: https://lore.kernel.org/all/[email protected]/
> Fixes: 093c290084a4 ("clk: samsung: gs101: add support for cmu_hsi2")
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---

Thanks for the fix! These are actually the cmu_top parents and
shouldn't be defined here. They already have their own definitions in
the cmu_top section.

Reviewed-by: Peter Griffin <[email protected]>

Peter