2023-07-21 10:36:33

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH v5 1/4] dt-bindings: arm: fsl: Add VAR-SOM-MX6 SoM

On 21/07/2023 11:49, James Hilliard wrote:
> Add support for Variscite i.MX6Q VAR-SOM-MX6 SoM.
>
> Acked-by: Conor Dooley <[email protected]>
> Signed-off-by: James Hilliard <[email protected]>
> ---
> Documentation/devicetree/bindings/arm/fsl.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> index 2510eaa8906d..da486c4a4ecf 100644
> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> @@ -385,6 +385,11 @@ properties:
> - const: toradex,apalis_imx6q
> - const: fsl,imx6q
>
> + - description: i.MX6Q Variscite VAR-SOM-MX6 Boards
> + items:
> + - const: variscite,var-som-imx6q

Again, this cannot be on its own. This commit does not make sense on its
own.

Best regards,
Krzysztof



2023-07-21 10:49:41

by James Hilliard

[permalink] [raw]
Subject: Re: [PATCH v5 1/4] dt-bindings: arm: fsl: Add VAR-SOM-MX6 SoM

On Fri, Jul 21, 2023 at 3:58 AM Krzysztof Kozlowski
<[email protected]> wrote:
>
> On 21/07/2023 11:49, James Hilliard wrote:
> > Add support for Variscite i.MX6Q VAR-SOM-MX6 SoM.
> >
> > Acked-by: Conor Dooley <[email protected]>
> > Signed-off-by: James Hilliard <[email protected]>
> > ---
> > Documentation/devicetree/bindings/arm/fsl.yaml | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> > index 2510eaa8906d..da486c4a4ecf 100644
> > --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> > @@ -385,6 +385,11 @@ properties:
> > - const: toradex,apalis_imx6q
> > - const: fsl,imx6q
> >
> > + - description: i.MX6Q Variscite VAR-SOM-MX6 Boards
> > + items:
> > + - const: variscite,var-som-imx6q
>
> Again, this cannot be on its own. This commit does not make sense on its
> own.

So I should just combine this with patch 3?

>
> Best regards,
> Krzysztof
>