2021-02-09 13:42:36

by David Howells

Subject: [RFC PATCH net] rxrpc: Fix missing dependency on NET_UDP_TUNNEL

The changes to make rxrpc create the udp socket missed a bit to add the
Kconfig dependency on the udp tunnel code to do this.

Fix this by adding making AF_RXRPC select NET_UDP_TUNNEL.

Fixes: 1a9b86c9fd95 ("rxrpc: use udp tunnel APIs instead of open code in rxrpc_open_socket")
Reported-by: kernel test robot <[email protected]>
Suggested-by: Vadim Fedorenko <[email protected]>
Signed-off-by: David Howells <[email protected]>
cc: Xin Long <[email protected]>
cc: [email protected]
cc: Jakub Kicinski <[email protected]>
---

net/rxrpc/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/net/rxrpc/Kconfig b/net/rxrpc/Kconfig
index d706bb408365..0885b22e5c0e 100644
--- a/net/rxrpc/Kconfig
+++ b/net/rxrpc/Kconfig
@@ -8,6 +8,7 @@ config AF_RXRPC
depends on INET
select CRYPTO
select KEYS
+ select NET_UDP_TUNNEL
help
Say Y or M here to include support for RxRPC session sockets (just
the transport part, not the presentation part: (un)marshalling is

2021-02-09 14:26:09

by Xin Long

Subject: Re: [RFC PATCH net] rxrpc: Fix missing dependency on NET_UDP_TUNNEL

On Tue, Feb 9, 2021 at 9:38 PM David Howells <[email protected]> wrote:
>
> The changes to make rxrpc create the udp socket missed a bit to add the
> Kconfig dependency on the udp tunnel code to do this.
>
> Fix this by adding making AF_RXRPC select NET_UDP_TUNNEL.
>
> Fixes: 1a9b86c9fd95 ("rxrpc: use udp tunnel APIs instead of open code in rxrpc_open_socket")
> Reported-by: kernel test robot <[email protected]>
> Suggested-by: Vadim Fedorenko <[email protected]>
> Signed-off-by: David Howells <[email protected]>
> cc: Xin Long <[email protected]>
> cc: [email protected]
> cc: Jakub Kicinski <[email protected]>
> ---
>
> net/rxrpc/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/net/rxrpc/Kconfig b/net/rxrpc/Kconfig
> index d706bb408365..0885b22e5c0e 100644
> --- a/net/rxrpc/Kconfig
> +++ b/net/rxrpc/Kconfig
> @@ -8,6 +8,7 @@ config AF_RXRPC
> depends on INET
> select CRYPTO
> select KEYS
> + select NET_UDP_TUNNEL
> help
> Say Y or M here to include support for RxRPC session sockets (just
> the transport part, not the presentation part: (un)marshalling is
>
>
Reviewed-by: Xin Long <[email protected]>

Thanks.