2023-07-04 09:35:27

by Menglong Dong

[permalink] [raw]
Subject: [PATCH net-next] bnxt_en: use dev_consume_skb_any() in bnxt_tx_int

From: Menglong Dong <[email protected]>

Replace dev_kfree_skb_any() with dev_consume_skb_any() in bnxt_tx_int()
to clear the unnecessary noise of "kfree_skb" event.

Signed-off-by: Menglong Dong <[email protected]>
---
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
index f42e51bd3e42..bcd0f0173cb5 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
@@ -685,7 +685,7 @@ static void bnxt_tx_int(struct bnxt *bp, struct bnxt_napi *bnapi, int nr_pkts)
next_tx_int:
cons = NEXT_TX(cons);

- dev_kfree_skb_any(skb);
+ dev_consume_skb_any(skb);
}

WRITE_ONCE(txr->tx_cons, cons);
--
2.40.1



2023-07-04 13:14:33

by Paolo Abeni

[permalink] [raw]
Subject: Re: [PATCH net-next] bnxt_en: use dev_consume_skb_any() in bnxt_tx_int

On Tue, 2023-07-04 at 16:52 +0800, [email protected] wrote:
> From: Menglong Dong <[email protected]>
>
> Replace dev_kfree_skb_any() with dev_consume_skb_any() in bnxt_tx_int()
> to clear the unnecessary noise of "kfree_skb" event.
>
> Signed-off-by: Menglong Dong <[email protected]>

## Form letter - net-next-closed

The merge window for v6.5 has begun and therefore net-next is closed
for new drivers, features, code refactoring and optimizations.
We are currently accepting bug fixes only.

Please repost when net-next reopens after July 10th.

RFC patches sent for review only are obviously welcome at any time.

See:
https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#development-cycle
--
pw-bot: defer


2023-07-05 01:44:29

by Menglong Dong

[permalink] [raw]
Subject: Re: [PATCH net-next] bnxt_en: use dev_consume_skb_any() in bnxt_tx_int

On Tue, Jul 4, 2023 at 9:02 PM Paolo Abeni <[email protected]> wrote:
>
> On Tue, 2023-07-04 at 16:52 +0800, [email protected] wrote:
> > From: Menglong Dong <[email protected]>
> >
> > Replace dev_kfree_skb_any() with dev_consume_skb_any() in bnxt_tx_int()
> > to clear the unnecessary noise of "kfree_skb" event.
> >
> > Signed-off-by: Menglong Dong <[email protected]>
>
> ## Form letter - net-next-closed
>
> The merge window for v6.5 has begun and therefore net-next is closed
> for new drivers, features, code refactoring and optimizations.
> We are currently accepting bug fixes only.
>
> Please repost when net-next reopens after July 10th.
>

Sorry, I forgot that the net-next is closed. I'll resend it
after July 10th.

Thanks!
Menglong Dong

> RFC patches sent for review only are obviously welcome at any time.
>
> See:
> https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#development-cycle
> --
> pw-bot: defer
>