2021-09-09 06:04:07

by Satya Priya

Subject: [PATCH V3 2/2] arm64: dts: sc7280: Add volume up support for sc7280-idp

Add pm7325 PMIC gpio support for vol+ on sc7280-idp.

Signed-off-by: satya priya <[email protected]>
---
Changes in V2:
- No changes.

Changes in V3:
- Sorted the nodes alphabetically.

arch/arm64/boot/dts/qcom/sc7280-idp.dtsi | 31 +++++++++++++++++++++++++++++++
1 file changed, 31 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
index 371a2a9..434c1c6 100644
--- a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
@@ -239,6 +239,26 @@
cd-gpios = <&tlmm 91 GPIO_ACTIVE_LOW>;
};

+&soc {
+ gpio_keys {
+ compatible = "gpio-keys";
+ label = "gpio-keys";
+
+ pinctrl-names = "default";
+ pinctrl-0 = <&key_vol_up_default>;
+
+ vol_up {
+ label = "volume_up";
+ gpios = <&pm7325_gpios 6 GPIO_ACTIVE_LOW>;
+ linux,input-type = <1>;
+ linux,code = <KEY_VOLUMEUP>;
+ gpio-key,wakeup;
+ debounce-interval = <15>;
+ linux,can-disable;
+ };
+ };
+};
+
&uart5 {
status = "okay";
};
@@ -284,6 +304,17 @@

/* PINCTRL - additions to nodes defined in sc7280.dtsi */

+&pm7325_gpios {
+ key_vol_up_default: key_vol_up_default {
+ pins = "gpio6";
+ function = "normal";
+ input-enable;
+ bias-pull-up;
+ power-source = <0>;
+ qcom,drive-strength = <3>;
+ };
+};
+
&qup_uart5_default {
tx {
pins = "gpio46";
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation

2021-09-14 01:03:55

by Stephen Boyd

Subject: Re: [PATCH V3 2/2] arm64: dts: sc7280: Add volume up support for sc7280-idp

Quoting satya priya (2021-09-08 23:01:28)
> diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
> index 371a2a9..434c1c6 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
> @@ -239,6 +239,26 @@
> cd-gpios = <&tlmm 91 GPIO_ACTIVE_LOW>;
> };
>
> +&soc {
> + gpio_keys {

Should be gpio-keys. Node names shouldn't have underscores. Typically
underscores are replaced with dashes.

> + compatible = "gpio-keys";
> + label = "gpio-keys";
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&key_vol_up_default>;
> +
> + vol_up {

Should be vol-up or volume-up.

> + label = "volume_up";
> + gpios = <&pm7325_gpios 6 GPIO_ACTIVE_LOW>;
> + linux,input-type = <1>;
> + linux,code = <KEY_VOLUMEUP>;
> + gpio-key,wakeup;
> + debounce-interval = <15>;
> + linux,can-disable;
> + };
> + };
> +};
> +
> &uart5 {
> status = "okay";
> };
> @@ -284,6 +304,17 @@
>
> /* PINCTRL - additions to nodes defined in sc7280.dtsi */
>
> +&pm7325_gpios {
> + key_vol_up_default: key_vol_up_default {

Should be key_vol_up_default: key-vol-up-default {

> + pins = "gpio6";
> + function = "normal";
> + input-enable;
> + bias-pull-up;
> + power-source = <0>;
> + qcom,drive-strength = <3>;
> + };
> +};
> +
> &qup_uart5_default {
> tx {
> pins = "gpio46";