2021-10-19 10:51:46

by Satya Priya

Subject: [PATCH V2 3/3] arm64: dts: qcom: pm8350c: Add pwm support

From: satya priya <[email protected]>

Add pwm support for PM8350C pmic.

Signed-off-by: satya priya <[email protected]>
---
Changes in V2:
- Dropped suffix '4' from pwm phandle and removed "status=ok".

arch/arm64/boot/dts/qcom/pm8350c.dtsi | 6 ++++++
1 file changed, 6 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/pm8350c.dtsi b/arch/arm64/boot/dts/qcom/pm8350c.dtsi
index e1b75ae..08fc0a8 100644
--- a/arch/arm64/boot/dts/qcom/pm8350c.dtsi
+++ b/arch/arm64/boot/dts/qcom/pm8350c.dtsi
@@ -29,6 +29,12 @@
interrupt-controller;
#interrupt-cells = <2>;
};
+
+ pm8350c_pwm: pwm {
+ compatible = "qcom,pm8350c-pwm";
+ #pwm-cells = <2>;
+ status = "disabled";
+ };
};
};

--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation

2021-10-20 04:29:43

by Stephen Boyd

Subject: Re: [PATCH V2 3/3] arm64: dts: qcom: pm8350c: Add pwm support

Quoting Satya Priya (2021-10-19 03:48:51)
> From: satya priya <[email protected]>
>
> Add pwm support for PM8350C pmic.
>
> Signed-off-by: satya priya <[email protected]>
> ---
> Changes in V2:
> - Dropped suffix '4' from pwm phandle and removed "status=ok".
>
> arch/arm64/boot/dts/qcom/pm8350c.dtsi | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/pm8350c.dtsi b/arch/arm64/boot/dts/qcom/pm8350c.dtsi
> index e1b75ae..08fc0a8 100644
> --- a/arch/arm64/boot/dts/qcom/pm8350c.dtsi
> +++ b/arch/arm64/boot/dts/qcom/pm8350c.dtsi
> @@ -29,6 +29,12 @@
> interrupt-controller;
> #interrupt-cells = <2>;
> };
> +
> + pm8350c_pwm: pwm {
> + compatible = "qcom,pm8350c-pwm";

It should have a reg property. Every node should have a single cell for
the reg property because the parent has #address-cells = <1>

> + #pwm-cells = <2>;
> + status = "disabled";
> + };
> };