2022-08-23 10:44:23

by Satya Priya

Subject: [PATCH] clk: qcom: lpass: Fix the invalid index errors seen at bootup

After support for resets is added, qcom_cc_really_probe()
would be called twice for the same cc which causes
invalid index errors in qcom_clk_hw_get().

qcom_cc_clk_hw_get: invalid index 5
qcom_cc_clk_hw_get: invalid index 6
qcom_cc_clk_hw_get: invalid index 7

Fixes: a9dd26639d05 ("clk: qcom: lpass: Add support for LPASS clock controller for SC7280")
Signed-off-by: Taniya Das <[email protected]>
Signed-off-by: Satya Priya <[email protected]>
---
This patch depends on [1]
[1] https://patchwork.kernel.org/project/linux-arm-msm/list/?series=667984

drivers/clk/qcom/lpassaudiocc-sc7280.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/qcom/lpassaudiocc-sc7280.c b/drivers/clk/qcom/lpassaudiocc-sc7280.c
index 063e036..5d4bc56 100644
--- a/drivers/clk/qcom/lpassaudiocc-sc7280.c
+++ b/drivers/clk/qcom/lpassaudiocc-sc7280.c
@@ -785,7 +785,7 @@ static int lpass_audio_cc_sc7280_probe(struct platform_device *pdev)
regmap_write(regmap, 0x4, 0x3b);
regmap_write(regmap, 0x8, 0xff05);

- ret = qcom_cc_really_probe(pdev, &lpass_audio_cc_sc7280_desc, regmap);
+ ret = qcom_cc_probe_by_index(pdev, 0, &lpass_audio_cc_sc7280_desc);
if (ret) {
dev_err(&pdev->dev, "Failed to register LPASS AUDIO CC clocks\n");
pm_runtime_disable(&pdev->dev);
--
2.7.4

2022-08-23 18:13:53

by Caleb Connolly

Subject: Re: [PATCH] clk: qcom: lpass: Fix the invalid index errors seen at bootup

Could you adjust the subject line to reflect which CC this patch is for?

clk: qcom: lpassaudiocc-sc7280: Fix the invalid index errors seen at bootup

This matches other commits in the subsystem.

On 23/08/2022 10:05, Satya Priya wrote:
> After support for resets is added, qcom_cc_really_probe()
> would be called twice for the same cc which causes
> invalid index errors in qcom_clk_hw_get().
>
> qcom_cc_clk_hw_get: invalid index 5
> qcom_cc_clk_hw_get: invalid index 6
> qcom_cc_clk_hw_get: invalid index 7
>
> Fixes: a9dd26639d05 ("clk: qcom: lpass: Add support for LPASS clock controller for SC7280")
> Signed-off-by: Taniya Das <[email protected]>
> Signed-off-by: Satya Priya <[email protected]>
> ---
> This patch depends on [1]
> [1] https://patchwork.kernel.org/project/linux-arm-msm/list/?series=667984
>
> drivers/clk/qcom/lpassaudiocc-sc7280.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/qcom/lpassaudiocc-sc7280.c b/drivers/clk/qcom/lpassaudiocc-sc7280.c
> index 063e036..5d4bc56 100644
> --- a/drivers/clk/qcom/lpassaudiocc-sc7280.c
> +++ b/drivers/clk/qcom/lpassaudiocc-sc7280.c
> @@ -785,7 +785,7 @@ static int lpass_audio_cc_sc7280_probe(struct platform_device *pdev)
> regmap_write(regmap, 0x4, 0x3b);
> regmap_write(regmap, 0x8, 0xff05);
>
> - ret = qcom_cc_really_probe(pdev, &lpass_audio_cc_sc7280_desc, regmap);
> + ret = qcom_cc_probe_by_index(pdev, 0, &lpass_audio_cc_sc7280_desc);
> if (ret) {
> dev_err(&pdev->dev, "Failed to register LPASS AUDIO CC clocks\n");
> pm_runtime_disable(&pdev->dev);
> --
> 2.7.4
>

--
Kind Regards,
Caleb

2022-08-23 18:53:50

by Stephen Boyd

Subject: Re: [PATCH] clk: qcom: lpass: Fix the invalid index errors seen at bootup

Quoting Satya Priya (2022-08-23 02:05:27)
> After support for resets is added, qcom_cc_really_probe()
> would be called twice for the same cc which causes
> invalid index errors in qcom_clk_hw_get().
>
> qcom_cc_clk_hw_get: invalid index 5
> qcom_cc_clk_hw_get: invalid index 6
> qcom_cc_clk_hw_get: invalid index 7
>
> Fixes: a9dd26639d05 ("clk: qcom: lpass: Add support for LPASS clock controller for SC7280")
> Signed-off-by: Taniya Das <[email protected]>
> Signed-off-by: Satya Priya <[email protected]>
> ---
> This patch depends on [1]
> [1] https://patchwork.kernel.org/project/linux-arm-msm/list/?series=667984

Why not resend the series and squash this patch into it?