2022-03-21 22:22:18

by Srinivasa Rao Mandadapu

Subject: [PATCH v5 1/3] arm64: dts: qcom: sc7280: Add pinctrl for wcd938x codec reset and CTIA/OMTP headset selection

Add pinctrl nodes for wcd codec reset and CTIA/OMTP headset type selection.

Signed-off-by: Srinivasa Rao Mandadapu <[email protected]>
Co-developed-by: Venkata Prasad Potturu <[email protected]>
Signed-off-by: Venkata Prasad Potturu <[email protected]>
---
arch/arm64/boot/dts/qcom/sc7280-idp.dtsi | 22 ++++++++++++++++++++++
1 file changed, 22 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
index ecbf2b8..688fa95 100644
--- a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
@@ -545,5 +545,27 @@
function = "gpio";
bias-pull-down;
};
+
+ us_euro_select: us-euro-select {
+ pins = "gpio81";
+ function = "gpio";
+ bias-pull-down;
+ drive-strength = <2>;
+ };
+
+ wcd938x_reset_active: wcd938x-reset-active {
+ pins = "gpio83";
+ function = "gpio";
+ drive-strength = <16>;
+ output-high;
+ };
+
+ wcd938x_reset_sleep: wcd938x-reset-sleep {
+ pins = "gpio83";
+ function = "gpio";
+ drive-strength = <16>;
+ bias-disable;
+ output-low;
+ };
};

--
2.7.4

2022-03-21 22:22:21

by Stephen Boyd

Subject: Re: [PATCH v5 1/3] arm64: dts: qcom: sc7280: Add pinctrl for wcd938x codec reset and CTIA/OMTP headset selection

Quoting Srinivasa Rao Mandadapu (2022-03-21 04:59:17)
> Add pinctrl nodes for wcd codec reset and CTIA/OMTP headset type selection.
>
> Signed-off-by: Srinivasa Rao Mandadapu <[email protected]>
> Co-developed-by: Venkata Prasad Potturu <[email protected]>
> Signed-off-by: Venkata Prasad Potturu <[email protected]>
> ---
> arch/arm64/boot/dts/qcom/sc7280-idp.dtsi | 22 ++++++++++++++++++++++
> 1 file changed, 22 insertions(+)

Please combine this patch with the consumer that uses the pinctrl nodes.
Otherwise it is too hard to review the contents of this patch.

2022-04-05 05:21:15

by Srinivasa Rao Mandadapu

Subject: Re: [PATCH v5 1/3] arm64: dts: qcom: sc7280: Add pinctrl for wcd938x codec reset and CTIA/OMTP headset selection

On 3/22/2022 1:57 AM, Stephen Boyd wrote:
Thanks for your time Stephen!!!
> Quoting Srinivasa Rao Mandadapu (2022-03-21 04:59:17)
>> Add pinctrl nodes for wcd codec reset and CTIA/OMTP headset type selection.
>>
>> Signed-off-by: Srinivasa Rao Mandadapu <[email protected]>
>> Co-developed-by: Venkata Prasad Potturu <[email protected]>
>> Signed-off-by: Venkata Prasad Potturu <[email protected]>
>> ---
>> arch/arm64/boot/dts/qcom/sc7280-idp.dtsi | 22 ++++++++++++++++++++++
>> 1 file changed, 22 insertions(+)
> Please combine this patch with the consumer that uses the pinctrl nodes.
> Otherwise it is too hard to review the contents of this patch.
Okay. Will do accordingly.