2022-04-16 02:20:42

by Stephen Boyd

Subject: Re: [PATCH V10 6/9] mfd: pm8008: Add mfd_cell struct to register LDOs

Quoting Satya Priya (2022-04-14 05:30:15)
> diff --git a/drivers/mfd/qcom-pm8008.c b/drivers/mfd/qcom-pm8008.c
> index ca5240d..ab4ba55 100644
> --- a/drivers/mfd/qcom-pm8008.c
> +++ b/drivers/mfd/qcom-pm8008.c
> @@ -282,6 +287,14 @@ static int pm8008_probe(struct i2c_client *client)
> }
> gpiod_set_value(chip->reset_gpio, 1);
>
> + rc = devm_mfd_add_devices(&chip->clients[PM8008_REGULATORS_SID]->dev,
> + 0, pm8008_regulator_devs, ARRAY_SIZE(pm8008_regulator_devs),
> + NULL, 0, NULL);
> + if (rc) {
> + dev_err(chip->dev, "Failed to add regulators: %d\n", rc);
> + return rc;
> + }
> +
> return devm_of_platform_populate(chip->dev);

Can we just use devm_of_platform_populate()? Then have a compatible =
"qcom,pm8008-regulators" that binds with the regulator platform driver
and searches for the named regmap for the second i2c client.

2022-04-19 13:39:41

by Satya Priya

Subject: Re: [PATCH V10 6/9] mfd: pm8008: Add mfd_cell struct to register LDOs

On 4/15/2022 5:53 AM, Stephen Boyd wrote:
> Quoting Satya Priya (2022-04-14 05:30:15)
>> diff --git a/drivers/mfd/qcom-pm8008.c b/drivers/mfd/qcom-pm8008.c
>> index ca5240d..ab4ba55 100644
>> --- a/drivers/mfd/qcom-pm8008.c
>> +++ b/drivers/mfd/qcom-pm8008.c
>> @@ -282,6 +287,14 @@ static int pm8008_probe(struct i2c_client *client)
>> }
>> gpiod_set_value(chip->reset_gpio, 1);
>>
>> + rc = devm_mfd_add_devices(&chip->clients[PM8008_REGULATORS_SID]->dev,
>> + 0, pm8008_regulator_devs, ARRAY_SIZE(pm8008_regulator_devs),
>> + NULL, 0, NULL);
>> + if (rc) {
>> + dev_err(chip->dev, "Failed to add regulators: %d\n", rc);
>> + return rc;
>> + }
>> +
>> return devm_of_platform_populate(chip->dev);
> Can we just use devm_of_platform_populate()? Then have a compatible =
> "qcom,pm8008-regulators" that binds with the regulator platform driver
> and searches for the named regmap for the second i2c client.


On earlier versions we had a separate compatible for regulator driver, I
had to drop it as per Mark's suggestions here [1], [2].


If Mark is OK with adding a separate compatible, I can add it back.


[1]
https://patchwork.kernel.org/project/linux-arm-msm/patch/[email protected]/#24618011

[2]
https://patchwork.kernel.org/project/linux-arm-msm/patch/[email protected]/#24692220