2024-05-23 19:45:22

by Rob Herring (Arm)

Subject: [PATCH] dt-bindings: usb: realtek,rts5411: Add missing "additionalProperties" on child nodes

All nodes need an explicit additionalProperties or unevaluatedProperties
unless a $ref has one that's false. As that is not the case with
usb-device.yaml, "additionalProperties" is needed here.

Fixes: c44d9dab31d6 ("dt-bindings: usb: Add downstream facing ports to realtek binding")
Signed-off-by: Rob Herring (Arm) <[email protected]>
---
Documentation/devicetree/bindings/usb/realtek,rts5411.yaml | 1 +
1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/usb/realtek,rts5411.yaml b/Documentation/devicetree/bindings/usb/realtek,rts5411.yaml
index 0874fc21f66f..6577a61cc075 100644
--- a/Documentation/devicetree/bindings/usb/realtek,rts5411.yaml
+++ b/Documentation/devicetree/bindings/usb/realtek,rts5411.yaml
@@ -65,6 +65,7 @@ patternProperties:
description: The hard wired USB devices
type: object
$ref: /schemas/usb/usb-device.yaml
+ additionalProperties: true

required:
- peer-hub
--
2.43.0

2024-05-23 21:23:16

by Stephen Boyd

Subject: Re: [PATCH] dt-bindings: usb: realtek,rts5411: Add missing "additionalProperties" on child nodes

Quoting Rob Herring (Arm) (2024-05-23 12:44:59)
> All nodes need an explicit additionalProperties or unevaluatedProperties
> unless a $ref has one that's false. As that is not the case with
> usb-device.yaml, "additionalProperties" is needed here.
>
> Fixes: c44d9dab31d6 ("dt-bindings: usb: Add downstream facing ports to realtek binding")
> Signed-off-by: Rob Herring (Arm) <[email protected]>
> ---

Reviewed-by: Stephen Boyd <[email protected]>