2023-01-18 11:11:05

by Andy Shevchenko

Subject: [PATCH v1 1/1] platform/x86: intel/pmc: Switch to use acpi_evaluate_dsm_typed()

The acpi_evaluate_dsm_typed() provides a way to check the type of the
object evaluated by _DSM call. Use it instead of open coded variant.

Signed-off-by: Andy Shevchenko <[email protected]>
---
drivers/platform/x86/intel/pmc/tgl.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/platform/x86/intel/pmc/tgl.c b/drivers/platform/x86/intel/pmc/tgl.c
index e3e50538465d..c245ada849d0 100644
--- a/drivers/platform/x86/intel/pmc/tgl.c
+++ b/drivers/platform/x86/intel/pmc/tgl.c
@@ -221,9 +221,9 @@ void pmc_core_get_tgl_lpm_reqs(struct platform_device *pdev)

guid_parse(ACPI_S0IX_DSM_UUID, &s0ix_dsm_guid);

- out_obj = acpi_evaluate_dsm(adev->handle, &s0ix_dsm_guid, 0,
- ACPI_GET_LOW_MODE_REGISTERS, NULL);
- if (out_obj && out_obj->type == ACPI_TYPE_BUFFER) {
+ out_obj = acpi_evaluate_dsm_typed(adev->handle, &s0ix_dsm_guid, 0,
+ ACPI_GET_LOW_MODE_REGISTERS, NULL, ACPI_TYPE_BUFFER);
+ if (out_obj) {
u32 size = out_obj->buffer.length;

if (size != lpm_size) {
--
2.39.0

2023-01-18 21:37:25

by Rajneesh Bhardwaj

Subject: Re: [PATCH v1 1/1] platform/x86: intel/pmc: Switch to use acpi_evaluate_dsm_typed()

Looks good.
Reviewed-by : Rajneesh Bhardwaj <[email protected]>


On Wed, Jan 18, 2023 at 4:54 AM Andy Shevchenko
<[email protected]> wrote:
>
> The acpi_evaluate_dsm_typed() provides a way to check the type of the
> object evaluated by _DSM call. Use it instead of open coded variant.
>
> Signed-off-by: Andy Shevchenko <[email protected]>
> ---
> drivers/platform/x86/intel/pmc/tgl.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/platform/x86/intel/pmc/tgl.c b/drivers/platform/x86/intel/pmc/tgl.c
> index e3e50538465d..c245ada849d0 100644
> --- a/drivers/platform/x86/intel/pmc/tgl.c
> +++ b/drivers/platform/x86/intel/pmc/tgl.c
> @@ -221,9 +221,9 @@ void pmc_core_get_tgl_lpm_reqs(struct platform_device *pdev)
>
> guid_parse(ACPI_S0IX_DSM_UUID, &s0ix_dsm_guid);
>
> - out_obj = acpi_evaluate_dsm(adev->handle, &s0ix_dsm_guid, 0,
> - ACPI_GET_LOW_MODE_REGISTERS, NULL);
> - if (out_obj && out_obj->type == ACPI_TYPE_BUFFER) {
> + out_obj = acpi_evaluate_dsm_typed(adev->handle, &s0ix_dsm_guid, 0,
> + ACPI_GET_LOW_MODE_REGISTERS, NULL, ACPI_TYPE_BUFFER);
> + if (out_obj) {
> u32 size = out_obj->buffer.length;
>
> if (size != lpm_size) {
> --
> 2.39.0
>


--
Thanks,
Rajneesh