2019-12-28 17:20:57

by Frank Lee

Subject: [PATCH] thermal: sun8i: Add hwmon support

Expose sun8i thermal as a HWMON device.

Signed-off-by: Yangtao Li <[email protected]>
---
drivers/thermal/sun8i_thermal.c | 6 ++++++
1 file changed, 6 insertions(+)

diff --git a/drivers/thermal/sun8i_thermal.c b/drivers/thermal/sun8i_thermal.c
index 23a5f4aa4be4..619e75cb41b0 100644
--- a/drivers/thermal/sun8i_thermal.c
+++ b/drivers/thermal/sun8i_thermal.c
@@ -20,6 +20,8 @@
#include <linux/slab.h>
#include <linux/thermal.h>

+#include "thermal_hwmon.h"
+
#define MAX_SENSOR_NUM 4

#define FT_TEMP_MASK GENMASK(11, 0)
@@ -477,6 +479,10 @@ static int sun8i_ths_register(struct ths_device *tmdev)
&ths_ops);
if (IS_ERR(tmdev->sensor[i].tzd))
return PTR_ERR(tmdev->sensor[i].tzd);
+
+ if (devm_thermal_add_hwmon_sysfs(tmdev->sensor[i].tzd))
+ dev_warn(tmdev->dev,
+ "Failed to add hwmon sysfs attributes\n");
}

return 0;
--
2.17.1

2020-01-06 04:33:01

by Chen-Yu Tsai

Subject: Re: [PATCH] thermal: sun8i: Add hwmon support

On Sun, Dec 29, 2019 at 1:19 AM Yangtao Li <[email protected]> wrote:
>
> Expose sun8i thermal as a HWMON device.
>
> Signed-off-by: Yangtao Li <[email protected]>
> ---
> drivers/thermal/sun8i_thermal.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/thermal/sun8i_thermal.c b/drivers/thermal/sun8i_thermal.c
> index 23a5f4aa4be4..619e75cb41b0 100644
> --- a/drivers/thermal/sun8i_thermal.c
> +++ b/drivers/thermal/sun8i_thermal.c
> @@ -20,6 +20,8 @@
> #include <linux/slab.h>
> #include <linux/thermal.h>
>
> +#include "thermal_hwmon.h"
> +
> #define MAX_SENSOR_NUM 4
>
> #define FT_TEMP_MASK GENMASK(11, 0)
> @@ -477,6 +479,10 @@ static int sun8i_ths_register(struct ths_device *tmdev)
> &ths_ops);
> if (IS_ERR(tmdev->sensor[i].tzd))
> return PTR_ERR(tmdev->sensor[i].tzd);
> +
> + if (devm_thermal_add_hwmon_sysfs(tmdev->sensor[i].tzd))
> + dev_warn(tmdev->dev,
> + "Failed to add hwmon sysfs attributes\n");

Maybe you want a hard failure instead?

ChenYu

> }
>
> return 0;
> --
> 2.17.1
>

2020-01-06 16:15:15

by Frank Lee

Subject: Re: [PATCH] thermal: sun8i: Add hwmon support

HI Chen-Yu.

On Mon, Jan 6, 2020 at 12:32 PM Chen-Yu Tsai <[email protected]> wrote:
>
> On Sun, Dec 29, 2019 at 1:19 AM Yangtao Li <[email protected]> wrote:
> >
> > Expose sun8i thermal as a HWMON device.
> >
> > Signed-off-by: Yangtao Li <[email protected]>
> > ---
> > drivers/thermal/sun8i_thermal.c | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/drivers/thermal/sun8i_thermal.c b/drivers/thermal/sun8i_thermal.c
> > index 23a5f4aa4be4..619e75cb41b0 100644
> > --- a/drivers/thermal/sun8i_thermal.c
> > +++ b/drivers/thermal/sun8i_thermal.c
> > @@ -20,6 +20,8 @@
> > #include <linux/slab.h>
> > #include <linux/thermal.h>
> >
> > +#include "thermal_hwmon.h"
> > +
> > #define MAX_SENSOR_NUM 4
> >
> > #define FT_TEMP_MASK GENMASK(11, 0)
> > @@ -477,6 +479,10 @@ static int sun8i_ths_register(struct ths_device *tmdev)
> > &ths_ops);
> > if (IS_ERR(tmdev->sensor[i].tzd))
> > return PTR_ERR(tmdev->sensor[i].tzd);
> > +
> > + if (devm_thermal_add_hwmon_sysfs(tmdev->sensor[i].tzd))
> > + dev_warn(tmdev->dev,
> > + "Failed to add hwmon sysfs attributes\n");
>
> Maybe you want a hard failure instead?

I don't quite understand what you mean.
What do you think should be done?

MBR,
Yangtao

>
> ChenYu
>
> > }
> >
> > return 0;
> > --
> > 2.17.1
> >

2020-01-07 03:17:19

by Chen-Yu Tsai

Subject: Re: [PATCH] thermal: sun8i: Add hwmon support

On Tue, Jan 7, 2020 at 12:14 AM Frank Lee <[email protected]> wrote:
>
> HI Chen-Yu.
>
> On Mon, Jan 6, 2020 at 12:32 PM Chen-Yu Tsai <[email protected]> wrote:
> >
> > On Sun, Dec 29, 2019 at 1:19 AM Yangtao Li <[email protected]> wrote:
> > >
> > > Expose sun8i thermal as a HWMON device.
> > >
> > > Signed-off-by: Yangtao Li <[email protected]>
> > > ---
> > > drivers/thermal/sun8i_thermal.c | 6 ++++++
> > > 1 file changed, 6 insertions(+)
> > >
> > > diff --git a/drivers/thermal/sun8i_thermal.c b/drivers/thermal/sun8i_thermal.c
> > > index 23a5f4aa4be4..619e75cb41b0 100644
> > > --- a/drivers/thermal/sun8i_thermal.c
> > > +++ b/drivers/thermal/sun8i_thermal.c
> > > @@ -20,6 +20,8 @@
> > > #include <linux/slab.h>
> > > #include <linux/thermal.h>
> > >
> > > +#include "thermal_hwmon.h"
> > > +
> > > #define MAX_SENSOR_NUM 4
> > >
> > > #define FT_TEMP_MASK GENMASK(11, 0)
> > > @@ -477,6 +479,10 @@ static int sun8i_ths_register(struct ths_device *tmdev)
> > > &ths_ops);
> > > if (IS_ERR(tmdev->sensor[i].tzd))
> > > return PTR_ERR(tmdev->sensor[i].tzd);
> > > +
> > > + if (devm_thermal_add_hwmon_sysfs(tmdev->sensor[i].tzd))
> > > + dev_warn(tmdev->dev,
> > > + "Failed to add hwmon sysfs attributes\n");
> >
> > Maybe you want a hard failure instead?
>
> I don't quite understand what you mean.
> What do you think should be done?

Return an error instead of just printing a warning.

ChenYu

> MBR,
> Yangtao
>
> >
> > ChenYu
> >
> > > }
> > >
> > > return 0;
> > > --
> > > 2.17.1
> > >

2020-01-11 18:11:33

by Frank Lee

Subject: Re: [PATCH] thermal: sun8i: Add hwmon support

On Tue, Jan 7, 2020 at 11:15 AM Chen-Yu Tsai <[email protected]> wrote:
>
> On Tue, Jan 7, 2020 at 12:14 AM Frank Lee <[email protected]> wrote:
> >
> > HI Chen-Yu.
> >
> > On Mon, Jan 6, 2020 at 12:32 PM Chen-Yu Tsai <[email protected]> wrote:
> > >
> > > On Sun, Dec 29, 2019 at 1:19 AM Yangtao Li <[email protected]> wrote:
> > > >
> > > > Expose sun8i thermal as a HWMON device.
> > > >
> > > > Signed-off-by: Yangtao Li <[email protected]>
> > > > ---
> > > > drivers/thermal/sun8i_thermal.c | 6 ++++++
> > > > 1 file changed, 6 insertions(+)
> > > >
> > > > diff --git a/drivers/thermal/sun8i_thermal.c b/drivers/thermal/sun8i_thermal.c
> > > > index 23a5f4aa4be4..619e75cb41b0 100644
> > > > --- a/drivers/thermal/sun8i_thermal.c
> > > > +++ b/drivers/thermal/sun8i_thermal.c
> > > > @@ -20,6 +20,8 @@
> > > > #include <linux/slab.h>
> > > > #include <linux/thermal.h>
> > > >
> > > > +#include "thermal_hwmon.h"
> > > > +
> > > > #define MAX_SENSOR_NUM 4
> > > >
> > > > #define FT_TEMP_MASK GENMASK(11, 0)
> > > > @@ -477,6 +479,10 @@ static int sun8i_ths_register(struct ths_device *tmdev)
> > > > &ths_ops);
> > > > if (IS_ERR(tmdev->sensor[i].tzd))
> > > > return PTR_ERR(tmdev->sensor[i].tzd);
> > > > +
> > > > + if (devm_thermal_add_hwmon_sysfs(tmdev->sensor[i].tzd))
> > > > + dev_warn(tmdev->dev,
> > > > + "Failed to add hwmon sysfs attributes\n");
> > >
> > > Maybe you want a hard failure instead?
> >
> > I don't quite understand what you mean.
> > What do you think should be done?
>
> Return an error instead of just printing a warning.

Sometimes, even if hwmon fails to add, it can still work as a thermal driver.
At this time, I don't really want to interrupt the registration of the
thermal driver.

Anyone else's opinion here?

Yours,
Ynagtao

>
> ChenYu
>
> > MBR,
> > Yangtao
> >
> > >
> > > ChenYu
> > >
> > > > }
> > > >
> > > > return 0;
> > > > --
> > > > 2.17.1
> > > >

2020-01-12 18:14:11

by Frank Lee

Subject: Re: [PATCH] thermal: sun8i: Add hwmon support

HI Daniel:

On Sun, Jan 12, 2020 at 2:08 AM Frank Lee <[email protected]> wrote:
>
> On Tue, Jan 7, 2020 at 11:15 AM Chen-Yu Tsai <[email protected]> wrote:
> >
> > On Tue, Jan 7, 2020 at 12:14 AM Frank Lee <[email protected]> wrote:
> > >
> > > HI Chen-Yu.
> > >
> > > On Mon, Jan 6, 2020 at 12:32 PM Chen-Yu Tsai <[email protected]> wrote:
> > > >
> > > > On Sun, Dec 29, 2019 at 1:19 AM Yangtao Li <[email protected]> wrote:
> > > > >
> > > > > Expose sun8i thermal as a HWMON device.
> > > > >
> > > > > Signed-off-by: Yangtao Li <[email protected]>
> > > > > ---
> > > > > drivers/thermal/sun8i_thermal.c | 6 ++++++
> > > > > 1 file changed, 6 insertions(+)
> > > > >
> > > > > diff --git a/drivers/thermal/sun8i_thermal.c b/drivers/thermal/sun8i_thermal.c
> > > > > index 23a5f4aa4be4..619e75cb41b0 100644
> > > > > --- a/drivers/thermal/sun8i_thermal.c
> > > > > +++ b/drivers/thermal/sun8i_thermal.c
> > > > > @@ -20,6 +20,8 @@
> > > > > #include <linux/slab.h>
> > > > > #include <linux/thermal.h>
> > > > >
> > > > > +#include "thermal_hwmon.h"
> > > > > +
> > > > > #define MAX_SENSOR_NUM 4
> > > > >
> > > > > #define FT_TEMP_MASK GENMASK(11, 0)
> > > > > @@ -477,6 +479,10 @@ static int sun8i_ths_register(struct ths_device *tmdev)
> > > > > &ths_ops);
> > > > > if (IS_ERR(tmdev->sensor[i].tzd))
> > > > > return PTR_ERR(tmdev->sensor[i].tzd);
> > > > > +
> > > > > + if (devm_thermal_add_hwmon_sysfs(tmdev->sensor[i].tzd))
> > > > > + dev_warn(tmdev->dev,
> > > > > + "Failed to add hwmon sysfs attributes\n");
> > > >
> > > > Maybe you want a hard failure instead?
> > >
> > > I don't quite understand what you mean.
> > > What do you think should be done?
> >
> > Return an error instead of just printing a warning.
>
> Sometimes, even if hwmon fails to add, it can still work as a thermal driver.
> At this time, I don't really want to interrupt the registration of the
> thermal driver.
>
> Anyone else's opinion here?
>

What's your point? Can you choose this patch?

MBR,
Yangtao

2020-01-12 19:33:18

by Daniel Lezcano

Subject: Re: [PATCH] thermal: sun8i: Add hwmon support

On 12/01/2020 19:12, Frank Lee wrote:
> HI Daniel:
>
> On Sun, Jan 12, 2020 at 2:08 AM Frank Lee <[email protected]> wrote:
>>
>> On Tue, Jan 7, 2020 at 11:15 AM Chen-Yu Tsai <[email protected]> wrote:
>>>
>>> On Tue, Jan 7, 2020 at 12:14 AM Frank Lee <[email protected]> wrote:
>>>>
>>>> HI Chen-Yu.
>>>>
>>>> On Mon, Jan 6, 2020 at 12:32 PM Chen-Yu Tsai <[email protected]> wrote:
>>>>>
>>>>> On Sun, Dec 29, 2019 at 1:19 AM Yangtao Li <[email protected]> wrote:
>>>>>>
>>>>>> Expose sun8i thermal as a HWMON device.
>>>>>>
>>>>>> Signed-off-by: Yangtao Li <[email protected]>
>>>>>> ---
>>>>>> drivers/thermal/sun8i_thermal.c | 6 ++++++
>>>>>> 1 file changed, 6 insertions(+)
>>>>>>
>>>>>> diff --git a/drivers/thermal/sun8i_thermal.c b/drivers/thermal/sun8i_thermal.c
>>>>>> index 23a5f4aa4be4..619e75cb41b0 100644
>>>>>> --- a/drivers/thermal/sun8i_thermal.c
>>>>>> +++ b/drivers/thermal/sun8i_thermal.c
>>>>>> @@ -20,6 +20,8 @@
>>>>>> #include <linux/slab.h>
>>>>>> #include <linux/thermal.h>
>>>>>>
>>>>>> +#include "thermal_hwmon.h"
>>>>>> +
>>>>>> #define MAX_SENSOR_NUM 4
>>>>>>
>>>>>> #define FT_TEMP_MASK GENMASK(11, 0)
>>>>>> @@ -477,6 +479,10 @@ static int sun8i_ths_register(struct ths_device *tmdev)
>>>>>> &ths_ops);
>>>>>> if (IS_ERR(tmdev->sensor[i].tzd))
>>>>>> return PTR_ERR(tmdev->sensor[i].tzd);
>>>>>> +
>>>>>> + if (devm_thermal_add_hwmon_sysfs(tmdev->sensor[i].tzd))
>>>>>> + dev_warn(tmdev->dev,
>>>>>> + "Failed to add hwmon sysfs attributes\n");
>>>>>
>>>>> Maybe you want a hard failure instead?
>>>>
>>>> I don't quite understand what you mean.
>>>> What do you think should be done?
>>>
>>> Return an error instead of just printing a warning.
>>
>> Sometimes, even if hwmon fails to add, it can still work as a thermal driver.
>> At this time, I don't really want to interrupt the registration of the
>> thermal driver.
>>
>> Anyone else's opinion here?
>>
>
> What's your point? Can you choose this patch?

Applied, thanks


--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog