2019-12-21 17:42:06

by Frank Lee

[permalink] [raw]
Subject: [PATCH] thermal: fix indentation in makefile

To unify code style.

Signed-off-by: Yangtao Li <[email protected]>
---
drivers/thermal/Makefile | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/thermal/Makefile b/drivers/thermal/Makefile
index baeb70bf0568..ab9389bc42b2 100644
--- a/drivers/thermal/Makefile
+++ b/drivers/thermal/Makefile
@@ -5,7 +5,7 @@

obj-$(CONFIG_THERMAL) += thermal_sys.o
thermal_sys-y += thermal_core.o thermal_sysfs.o \
- thermal_helpers.o
+ thermal_helpers.o

# interface to/from other layers providing sensors
thermal_sys-$(CONFIG_THERMAL_HWMON) += thermal_hwmon.o
@@ -25,11 +25,11 @@ thermal_sys-$(CONFIG_CPU_THERMAL) += cpu_cooling.o
thermal_sys-$(CONFIG_CLOCK_THERMAL) += clock_cooling.o

# devfreq cooling
-thermal_sys-$(CONFIG_DEVFREQ_THERMAL) += devfreq_cooling.o
+thermal_sys-$(CONFIG_DEVFREQ_THERMAL) += devfreq_cooling.o

# platform thermal drivers
obj-y += broadcom/
-obj-$(CONFIG_THERMAL_MMIO) += thermal_mmio.o
+obj-$(CONFIG_THERMAL_MMIO) += thermal_mmio.o
obj-$(CONFIG_SPEAR_THERMAL) += spear_thermal.o
obj-$(CONFIG_ROCKCHIP_THERMAL) += rockchip_thermal.o
obj-$(CONFIG_RCAR_THERMAL) += rcar_thermal.o
@@ -49,9 +49,9 @@ obj-$(CONFIG_TI_SOC_THERMAL) += ti-soc-thermal/
obj-y += st/
obj-$(CONFIG_QCOM_TSENS) += qcom/
obj-y += tegra/
-obj-$(CONFIG_HISI_THERMAL) += hisi_thermal.o
+obj-$(CONFIG_HISI_THERMAL) += hisi_thermal.o
obj-$(CONFIG_MTK_THERMAL) += mtk_thermal.o
obj-$(CONFIG_GENERIC_ADC_THERMAL) += thermal-generic-adc.o
obj-$(CONFIG_ZX2967_THERMAL) += zx2967_thermal.o
obj-$(CONFIG_UNIPHIER_THERMAL) += uniphier_thermal.o
-obj-$(CONFIG_AMLOGIC_THERMAL) += amlogic_thermal.o
+obj-$(CONFIG_AMLOGIC_THERMAL) += amlogic_thermal.o
--
2.17.1


2019-12-21 18:59:20

by Daniel Lezcano

[permalink] [raw]
Subject: Re: [PATCH] thermal: fix indentation in makefile

On 21/12/2019 18:37, Yangtao Li wrote:
> To unify code style.
>
> Signed-off-by: Yangtao Li <[email protected]>
> ---
> drivers/thermal/Makefile | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/thermal/Makefile b/drivers/thermal/Makefile
> index baeb70bf0568..ab9389bc42b2 100644
> --- a/drivers/thermal/Makefile
> +++ b/drivers/thermal/Makefile
> @@ -5,7 +5,7 @@
>
> obj-$(CONFIG_THERMAL) += thermal_sys.o
> thermal_sys-y += thermal_core.o thermal_sysfs.o \
> - thermal_helpers.o
> + thermal_helpers.o

Here a tabulation is replaced with spaces.

> # interface to/from other layers providing sensors
> thermal_sys-$(CONFIG_THERMAL_HWMON) += thermal_hwmon.o
> @@ -25,11 +25,11 @@ thermal_sys-$(CONFIG_CPU_THERMAL) += cpu_cooling.o
> thermal_sys-$(CONFIG_CLOCK_THERMAL) += clock_cooling.o
>
> # devfreq cooling
> -thermal_sys-$(CONFIG_DEVFREQ_THERMAL) += devfreq_cooling.o
> +thermal_sys-$(CONFIG_DEVFREQ_THERMAL) += devfreq_cooling.o
>
> # platform thermal drivers
> obj-y += broadcom/
> -obj-$(CONFIG_THERMAL_MMIO) += thermal_mmio.o
> +obj-$(CONFIG_THERMAL_MMIO) += thermal_mmio.o
> obj-$(CONFIG_SPEAR_THERMAL) += spear_thermal.o
> obj-$(CONFIG_ROCKCHIP_THERMAL) += rockchip_thermal.o
> obj-$(CONFIG_RCAR_THERMAL) += rcar_thermal.o
> @@ -49,9 +49,9 @@ obj-$(CONFIG_TI_SOC_THERMAL) += ti-soc-thermal/
> obj-y += st/
> obj-$(CONFIG_QCOM_TSENS) += qcom/
> obj-y += tegra/
> -obj-$(CONFIG_HISI_THERMAL) += hisi_thermal.o
> +obj-$(CONFIG_HISI_THERMAL) += hisi_thermal.o
> obj-$(CONFIG_MTK_THERMAL) += mtk_thermal.o
> obj-$(CONFIG_GENERIC_ADC_THERMAL) += thermal-generic-adc.o
> obj-$(CONFIG_ZX2967_THERMAL) += zx2967_thermal.o
> obj-$(CONFIG_UNIPHIER_THERMAL) += uniphier_thermal.o
> -obj-$(CONFIG_AMLOGIC_THERMAL) += amlogic_thermal.o
> +obj-$(CONFIG_AMLOGIC_THERMAL) += amlogic_thermal.o
>


--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

2019-12-22 17:40:42

by Frank Lee

[permalink] [raw]
Subject: Re: [PATCH] thermal: fix indentation in makefile

：q

On Sun, Dec 22, 2019 at 2:57 AM Daniel Lezcano
<[email protected]> wrote:
>
> On 21/12/2019 18:37, Yangtao Li wrote:
> > To unify code style.
> >
> > Signed-off-by: Yangtao Li <[email protected]>
> > ---
> > drivers/thermal/Makefile | 10 +++++-----
> > 1 file changed, 5 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/thermal/Makefile b/drivers/thermal/Makefile
> > index baeb70bf0568..ab9389bc42b2 100644
> > --- a/drivers/thermal/Makefile
> > +++ b/drivers/thermal/Makefile
> > @@ -5,7 +5,7 @@
> >
> > obj-$(CONFIG_THERMAL) += thermal_sys.o
> > thermal_sys-y += thermal_core.o thermal_sysfs.o \
> > - thermal_helpers.o
> > + thermal_helpers.o
>
> Here a tabulation is replaced with spaces.

It won't align after using tab here, shouldn't modify it?


Yours,
Yangtao

>
> > # interface to/from other layers providing sensors
> > thermal_sys-$(CONFIG_THERMAL_HWMON) += thermal_hwmon.o
> > @@ -25,11 +25,11 @@ thermal_sys-$(CONFIG_CPU_THERMAL) += cpu_cooling.o
> > thermal_sys-$(CONFIG_CLOCK_THERMAL) += clock_cooling.o
> >
> > # devfreq cooling
> > -thermal_sys-$(CONFIG_DEVFREQ_THERMAL) += devfreq_cooling.o
> > +thermal_sys-$(CONFIG_DEVFREQ_THERMAL) += devfreq_cooling.o
> >
> > # platform thermal drivers
> > obj-y += broadcom/
> > -obj-$(CONFIG_THERMAL_MMIO) += thermal_mmio.o
> > +obj-$(CONFIG_THERMAL_MMIO) += thermal_mmio.o
> > obj-$(CONFIG_SPEAR_THERMAL) += spear_thermal.o
> > obj-$(CONFIG_ROCKCHIP_THERMAL) += rockchip_thermal.o
> > obj-$(CONFIG_RCAR_THERMAL) += rcar_thermal.o
> > @@ -49,9 +49,9 @@ obj-$(CONFIG_TI_SOC_THERMAL) += ti-soc-thermal/
> > obj-y += st/
> > obj-$(CONFIG_QCOM_TSENS) += qcom/
> > obj-y += tegra/
> > -obj-$(CONFIG_HISI_THERMAL) += hisi_thermal.o
> > +obj-$(CONFIG_HISI_THERMAL) += hisi_thermal.o
> > obj-$(CONFIG_MTK_THERMAL) += mtk_thermal.o
> > obj-$(CONFIG_GENERIC_ADC_THERMAL) += thermal-generic-adc.o
> > obj-$(CONFIG_ZX2967_THERMAL) += zx2967_thermal.o
> > obj-$(CONFIG_UNIPHIER_THERMAL) += uniphier_thermal.o
> > -obj-$(CONFIG_AMLOGIC_THERMAL) += amlogic_thermal.o
> > +obj-$(CONFIG_AMLOGIC_THERMAL) += amlogic_thermal.o
> >
>
>
> --
> <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
>
> Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
> <http://twitter.com/#!/linaroorg> Twitter |
> <http://www.linaro.org/linaro-blog/> Blog
>

2020-02-17 07:41:26

by Zhang, Rui

[permalink] [raw]
Subject: Re: [PATCH] thermal: fix indentation in makefile

On Mon, 2019-12-23 at 01:38 +0800, Frank Lee wrote:
> ：q
>
> On Sun, Dec 22, 2019 at 2:57 AM Daniel Lezcano
> <[email protected]> wrote:
> >
> > On 21/12/2019 18:37, Yangtao Li wrote:
> > > To unify code style.
> > >
> > > Signed-off-by: Yangtao Li <[email protected]>
> > > ---
> > > drivers/thermal/Makefile | 10 +++++-----
> > > 1 file changed, 5 insertions(+), 5 deletions(-)
> > >
> > > diff --git a/drivers/thermal/Makefile b/drivers/thermal/Makefile
> > > index baeb70bf0568..ab9389bc42b2 100644
> > > --- a/drivers/thermal/Makefile
> > > +++ b/drivers/thermal/Makefile
> > > @@ -5,7 +5,7 @@
> > >
> > > obj-$(CONFIG_THERMAL) += thermal_sys.o
> > > thermal_sys-y += thermal_core.o
> > > thermal_sysfs.o \
> > > - thermal_helpers.o
> > > + thermal_helpers.o
> >
> > Here a tabulation is replaced with spaces.
>
> It won't align after using tab here, shouldn't modify it?

I'd prefer using tab here. Other changes seem okay to me.

thanks,
rui
>
>
> Yours,
> Yangtao
>
> >
> > > # interface to/from other layers providing sensors
> > > thermal_sys-$(CONFIG_THERMAL_HWMON) += thermal_hwmon.o
> > > @@ -25,11 +25,11 @@ thermal_sys-$(CONFIG_CPU_THERMAL) +=
> > > cpu_cooling.o
> > > thermal_sys-$(CONFIG_CLOCK_THERMAL) += clock_cooling.o
> > >
> > > # devfreq cooling
> > > -thermal_sys-$(CONFIG_DEVFREQ_THERMAL) += devfreq_cooling.o
> > > +thermal_sys-$(CONFIG_DEVFREQ_THERMAL) +=
> > > devfreq_cooling.o
> > >
> > > # platform thermal drivers
> > > obj-y += broadcom/
> > > -obj-$(CONFIG_THERMAL_MMIO) += thermal_mmio.o
> > > +obj-$(CONFIG_THERMAL_MMIO) += thermal_mmio.o
> > > obj-$(CONFIG_SPEAR_THERMAL) += spear_thermal.o
> > > obj-$(CONFIG_ROCKCHIP_THERMAL) += rockchip_thermal.o
> > > obj-$(CONFIG_RCAR_THERMAL) += rcar_thermal.o
> > > @@ -49,9 +49,9 @@ obj-$(CONFIG_TI_SOC_THERMAL) += ti-soc-
> > > thermal/
> > > obj-y += st/
> > > obj-$(CONFIG_QCOM_TSENS) += qcom/
> > > obj-y += tegra/
> > > -obj-$(CONFIG_HISI_THERMAL) += hisi_thermal.o
> > > +obj-$(CONFIG_HISI_THERMAL) += hisi_thermal.o
> > > obj-$(CONFIG_MTK_THERMAL) += mtk_thermal.o
> > > obj-$(CONFIG_GENERIC_ADC_THERMAL) += thermal-generic-adc.o
> > > obj-$(CONFIG_ZX2967_THERMAL) += zx2967_thermal.o
> > > obj-$(CONFIG_UNIPHIER_THERMAL) += uniphier_thermal.o
> > > -obj-$(CONFIG_AMLOGIC_THERMAL) += amlogic_thermal.o
> > > +obj-$(CONFIG_AMLOGIC_THERMAL) += amlogic_thermal.o
> > >
> >
> >
> > --
> > <http://www.linaro.org/> Linaro.org │ Open source software for ARM
> > SoCs
> >
> > Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
> > <http://twitter.com/#!/linaroorg> Twitter |
> > <http://www.linaro.org/linaro-blog/> Blog
> >