2017-06-23 11:20:42

by Fengguang Wu

Subject: [linux-next:master 6255/9581] drivers/usb/gadget/udc/snps_udc_plat.c:31:6: sparse: symbol 'start_udc' was not declared. Should it be static?

tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: a73468728fd8f34ccbd7c60f0808024ae491f4d6
commit: 1b9f35adb0ffa143c7972a8459d6979c77d6c3c0 [6255/9581] usb: gadget: udc: Add Synopsys UDC Platform driver
reproduce:
# apt-get install sparse
git checkout 1b9f35adb0ffa143c7972a8459d6979c77d6c3c0
make ARCH=x86_64 allmodconfig
make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)

>> drivers/usb/gadget/udc/snps_udc_plat.c:31:6: sparse: symbol 'start_udc' was not declared. Should it be static?
>> drivers/usb/gadget/udc/snps_udc_plat.c:41:6: sparse: symbol 'stop_udc' was not declared. Should it be static?
>> drivers/usb/gadget/udc/snps_udc_plat.c:79:6: sparse: symbol 'udc_drd_work' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

2017-06-23 11:20:41

by Fengguang Wu

Subject: [RFC PATCH linux-next] usb: gadget: udc: start_udc() can be static

Signed-off-by: Fengguang Wu <[email protected]>
---
snps_udc_plat.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/usb/gadget/udc/snps_udc_plat.c b/drivers/usb/gadget/udc/snps_udc_plat.c
index 2e11f19..f7b4d0f 100644
--- a/drivers/usb/gadget/udc/snps_udc_plat.c
+++ b/drivers/usb/gadget/udc/snps_udc_plat.c
@@ -28,7 +28,7 @@
/* description */
#define UDC_MOD_DESCRIPTION "Synopsys UDC platform driver"

-void start_udc(struct udc *udc)
+static void start_udc(struct udc *udc)
{
if (udc->driver) {
dev_info(udc->dev, "Connecting...\n");
@@ -38,7 +38,7 @@ void start_udc(struct udc *udc)
}
}

-void stop_udc(struct udc *udc)
+static void stop_udc(struct udc *udc)
{
int tmp;
u32 reg;
@@ -76,7 +76,7 @@ void stop_udc(struct udc *udc)
dev_info(udc->dev, "Device disconnected\n");
}

-void udc_drd_work(struct work_struct *work)
+static void udc_drd_work(struct work_struct *work)
{
struct udc *udc;

2017-06-23 11:30:52

by Raviteja Garimella

Subject: Re: [RFC PATCH linux-next] usb: gadget: udc: start_udc() can be static

Looks good to me.

Thanks,
Ravi

On Fri, Jun 23, 2017 at 4:50 PM, kbuild test robot
<[email protected]> wrote:
>
> Signed-off-by: Fengguang Wu <[email protected]>
> ---
> snps_udc_plat.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/usb/gadget/udc/snps_udc_plat.c b/drivers/usb/gadget/udc/snps_udc_plat.c
> index 2e11f19..f7b4d0f 100644
> --- a/drivers/usb/gadget/udc/snps_udc_plat.c
> +++ b/drivers/usb/gadget/udc/snps_udc_plat.c
> @@ -28,7 +28,7 @@
> /* description */
> #define UDC_MOD_DESCRIPTION "Synopsys UDC platform driver"
>
> -void start_udc(struct udc *udc)
> +static void start_udc(struct udc *udc)
> {
> if (udc->driver) {
> dev_info(udc->dev, "Connecting...\n");
> @@ -38,7 +38,7 @@ void start_udc(struct udc *udc)
> }
> }
>
> -void stop_udc(struct udc *udc)
> +static void stop_udc(struct udc *udc)
> {
> int tmp;
> u32 reg;
> @@ -76,7 +76,7 @@ void stop_udc(struct udc *udc)
> dev_info(udc->dev, "Device disconnected\n");
> }
>
> -void udc_drd_work(struct work_struct *work)
> +static void udc_drd_work(struct work_struct *work)
> {
> struct udc *udc;
>