2020-11-01 07:24:00

by Jernej Skrabec

[permalink] [raw]
Subject: [PATCH] arm64: dts: allwinner: h6: orangepi-one-plus: Fix ethernet

RX/TX delay on OrangePi One Plus board is set on PHY. Reflect that in
ethernet node.

Fixes: 7ee32a17e0d6 ("arm64: dts: allwinner: h6: orangepi-one-plus: Enable ethernet")
Signed-off-by: Jernej Skrabec <[email protected]>
---
arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi-one-plus.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi-one-plus.dts b/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi-one-plus.dts
index fceb298bfd53..29a081e72a9b 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi-one-plus.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi-one-plus.dts
@@ -27,7 +27,7 @@ reg_gmac_3v3: gmac-3v3 {
&emac {
pinctrl-names = "default";
pinctrl-0 = <&ext_rgmii_pins>;
- phy-mode = "rgmii";
+ phy-mode = "rgmii-id";
phy-handle = <&ext_rgmii_phy>;
phy-supply = <&reg_gmac_3v3>;
allwinner,rx-delay-ps = <200>;
--
2.29.2


2020-11-01 09:23:49

by Code Kipper

[permalink] [raw]
Subject: Re: [linux-sunxi] [PATCH] arm64: dts: allwinner: h6: orangepi-one-plus: Fix ethernet

On Sun, 1 Nov 2020 at 08:20, Jernej Skrabec <[email protected]> wrote:
>
> RX/TX delay on OrangePi One Plus board is set on PHY. Reflect that in
> ethernet node.
>
> Fixes: 7ee32a17e0d6 ("arm64: dts: allwinner: h6: orangepi-one-plus: Enable ethernet")
> Signed-off-by: Jernej Skrabec <[email protected]>
Hi Jernej,
Tested-by: Marcus Cooper <[email protected]>
BR,
CK
> ---
> arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi-one-plus.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi-one-plus.dts b/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi-one-plus.dts
> index fceb298bfd53..29a081e72a9b 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi-one-plus.dts
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi-one-plus.dts
> @@ -27,7 +27,7 @@ reg_gmac_3v3: gmac-3v3 {
> &emac {
> pinctrl-names = "default";
> pinctrl-0 = <&ext_rgmii_pins>;
> - phy-mode = "rgmii";
> + phy-mode = "rgmii-id";
> phy-handle = <&ext_rgmii_phy>;
> phy-supply = <&reg_gmac_3v3>;
> allwinner,rx-delay-ps = <200>;
> --
> 2.29.2
>
> --
> You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
> To view this discussion on the web, visit https://groups.google.com/d/msgid/linux-sunxi/20201101072609.1681891-1-jernej.skrabec%40siol.net.

2020-11-02 09:28:02

by Maxime Ripard

[permalink] [raw]
Subject: Re: [PATCH] arm64: dts: allwinner: h6: orangepi-one-plus: Fix ethernet

On Sun, Nov 01, 2020 at 08:26:09AM +0100, Jernej Skrabec wrote:
> RX/TX delay on OrangePi One Plus board is set on PHY. Reflect that in
> ethernet node.
>
> Fixes: 7ee32a17e0d6 ("arm64: dts: allwinner: h6: orangepi-one-plus: Enable ethernet")
> Signed-off-by: Jernej Skrabec <[email protected]>

Applied. It's not clear yet whether it's the best way forward (the PR
got rejected), so it might need some extra work in the future.

Maxime

Attachments:
(No filename) (455.00 B)
 signature.asc (235.00 B)
 Download all attachments