Hi all,
After merging the char-misc.current tree, today's linux-next build
(arm multi_v7_defconfig) produced this warning:
In file included from drivers/base/firmware_loader/main.c:41:
drivers/base/firmware_loader/firmware.h:145:12: warning: 'fw_map_paged_buf' defined but not used [-Wunused-function]
static int fw_map_paged_buf(struct fw_priv *fw_priv) { return -ENXIO; }
^~~~~~~~~~~~~~~~
drivers/base/firmware_loader/firmware.h:144:12: warning: 'fw_grow_paged_buf' defined but not used [-Wunused-function]
static int fw_grow_paged_buf(struct fw_priv *fw_priv, int pages_needed) { return -ENXIO; }
^~~~~~~~~~~~~~~~~
Introduced by commit
c8917b8ff09e ("firmware: fix build errors in paged buffer handling code")
These need to be inline (as well as static) ... :-(
--
Cheers,
Stephen Rothwell
On Tue, Jul 23, 2019 at 12:23 AM Stephen Rothwell <[email protected]> wrote:
>
> Hi all,
>
> After merging the char-misc.current tree, today's linux-next build
> (arm multi_v7_defconfig) produced this warning:
>
> In file included from drivers/base/firmware_loader/main.c:41:
> drivers/base/firmware_loader/firmware.h:145:12: warning: 'fw_map_paged_buf' defined but not used [-Wunused-function]
> static int fw_map_paged_buf(struct fw_priv *fw_priv) { return -ENXIO; }
> ^~~~~~~~~~~~~~~~
> drivers/base/firmware_loader/firmware.h:144:12: warning: 'fw_grow_paged_buf' defined but not used [-Wunused-function]
> static int fw_grow_paged_buf(struct fw_priv *fw_priv, int pages_needed) { return -ENXIO; }
> ^~~~~~~~~~~~~~~~~
>
> Introduced by commit
>
> c8917b8ff09e ("firmware: fix build errors in paged buffer handling code")
>
> These need to be inline (as well as static) ... :-(
>
> --
> Cheers,
> Stephen Rothwell
They were 'static inline' in the patch I have submitted for review
when I reported the problem, but it was luck I am an hobbyst, not a
professional coder.
I checked with Takashi and Greg, because I noticed the inline removed
in the post review commit
and Takashi was checking if inline was really needed, now it's confirmed.
No big issue, now the important thing is that inline is added,
please Takashi kindly confirm when it's done.
Mauro