2019-07-25 21:32:55

by Paul Walmsley

Subject: [PATCH] riscv: dts: fu540-c000: drop "timebase-frequency"

On FU540-based systems, the "timebase-frequency" (RTCCLK) is sourced
from an external crystal located on the PCB. Thus the
timebase-frequency DT property should be defined by the board that
uses the SoC, not the SoC itself. Drop the superfluous
timebase-frequency property from the SoC DT data. (It's already
present in the board DT data.)

Signed-off-by: Paul Walmsley <[email protected]>
---
arch/riscv/boot/dts/sifive/fu540-c000.dtsi | 1 -
1 file changed, 1 deletion(-)

diff --git a/arch/riscv/boot/dts/sifive/fu540-c000.dtsi b/arch/riscv/boot/dts/sifive/fu540-c000.dtsi
index 9bf63f0ab253..42b5ec223100 100644
--- a/arch/riscv/boot/dts/sifive/fu540-c000.dtsi
+++ b/arch/riscv/boot/dts/sifive/fu540-c000.dtsi
@@ -21,7 +21,6 @@
cpus {
#address-cells = <1>;
#size-cells = <0>;
- timebase-frequency = <1000000>;
cpu0: cpu@0 {
compatible = "sifive,e51", "sifive,rocket0", "riscv";
device_type = "cpu";
--
2.22.0

2019-07-28 13:42:24

by Bin Meng

Subject: Re: [PATCH] riscv: dts: fu540-c000: drop "timebase-frequency"

On Fri, Jul 26, 2019 at 5:31 AM Paul Walmsley <[email protected]> wrote:
>
>
> On FU540-based systems, the "timebase-frequency" (RTCCLK) is sourced
> from an external crystal located on the PCB. Thus the
> timebase-frequency DT property should be defined by the board that
> uses the SoC, not the SoC itself. Drop the superfluous
> timebase-frequency property from the SoC DT data. (It's already
> present in the board DT data.)
>
> Signed-off-by: Paul Walmsley <[email protected]>
> ---
> arch/riscv/boot/dts/sifive/fu540-c000.dtsi | 1 -
> 1 file changed, 1 deletion(-)
>

Reviewed-by: Bin Meng <[email protected]>