2021-07-15 17:26:44

by Geert Uytterhoeven

Subject: [PATCH] riscv: dts: microchip: mpfs-icicle: Fix serial console

Currently, nothing is output on the serial console, unless
"console=ttyS0,115200n8" or "earlycon" are appended to the kernel
command line. Enable automatic console selection using
chosen/stdout-path by adding a proper alias, and configure the expected
serial rate.

While at it, add aliases for the other three serial ports, which are
provided on the same micro-USB connector as the first one.

Fixes: 0fa6107eca4186ad ("RISC-V: Initial DTS for Microchip ICICLE board")
Signed-off-by: Geert Uytterhoeven <[email protected]>
---
.../boot/dts/microchip/microchip-mpfs-icicle-kit.dts | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/arch/riscv/boot/dts/microchip/microchip-mpfs-icicle-kit.dts b/arch/riscv/boot/dts/microchip/microchip-mpfs-icicle-kit.dts
index ec79944065c98ef2..d75ea11ed043c1f0 100644
--- a/arch/riscv/boot/dts/microchip/microchip-mpfs-icicle-kit.dts
+++ b/arch/riscv/boot/dts/microchip/microchip-mpfs-icicle-kit.dts
@@ -14,8 +14,15 @@ / {
model = "Microchip PolarFire-SoC Icicle Kit";
compatible = "microchip,mpfs-icicle-kit";

+ aliases {
+ serial0 = &serial0;
+ serial1 = &serial1;
+ serial2 = &serial2;
+ serial3 = &serial3;
+ };
+
chosen {
- stdout-path = &serial0;
+ stdout-path = "serial0:115200n8";
};

cpus {
--
2.25.1

2021-07-16 02:18:01

by Bin Meng

Subject: Re: [PATCH] riscv: dts: microchip: mpfs-icicle: Fix serial console

On Fri, Jul 16, 2021 at 1:26 AM Geert Uytterhoeven <[email protected]> wrote:
>
> Currently, nothing is output on the serial console, unless
> "console=ttyS0,115200n8" or "earlycon" are appended to the kernel
> command line. Enable automatic console selection using
> chosen/stdout-path by adding a proper alias, and configure the expected
> serial rate.
>
> While at it, add aliases for the other three serial ports, which are
> provided on the same micro-USB connector as the first one.
>
> Fixes: 0fa6107eca4186ad ("RISC-V: Initial DTS for Microchip ICICLE board")
> Signed-off-by: Geert Uytterhoeven <[email protected]>
> ---
> .../boot/dts/microchip/microchip-mpfs-icicle-kit.dts | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/arch/riscv/boot/dts/microchip/microchip-mpfs-icicle-kit.dts b/arch/riscv/boot/dts/microchip/microchip-mpfs-icicle-kit.dts
> index ec79944065c98ef2..d75ea11ed043c1f0 100644
> --- a/arch/riscv/boot/dts/microchip/microchip-mpfs-icicle-kit.dts
> +++ b/arch/riscv/boot/dts/microchip/microchip-mpfs-icicle-kit.dts
> @@ -14,8 +14,15 @@ / {
> model = "Microchip PolarFire-SoC Icicle Kit";
> compatible = "microchip,mpfs-icicle-kit";
>
> + aliases {
> + serial0 = &serial0;
> + serial1 = &serial1;
> + serial2 = &serial2;
> + serial3 = &serial3;
> + };
> +
> chosen {
> - stdout-path = &serial0;
> + stdout-path = "serial0:115200n8";
> };
>
> cpus {
> --

If possible, please rebase this patch on top of
https://patchwork.kernel.org/project/linux-riscv/patch/[email protected]/

Reviewed-by: Bin Meng <[email protected]>