2021-06-18 13:19:58

by Xiongwei Song

[permalink] [raw]
Subject: Re: [PATCH] locking/lockdep: Correct the description error for check_redundant()

On Fri, Jun 18, 2021 at 9:02 PM Xiongwei Song <[email protected]> wrote:
>
> From: Xiongwei Song <[email protected]>
>
> If there is no matched result, check_redundant() will return BFS_RNOMATCH.
>
> Signed-off-by: Xiongwei Song <[email protected]>
> Reviewed-by: Boqun Feng <[email protected]>
> ---
> kernel/locking/lockdep.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/locking/lockdep.c b/kernel/locking/lockdep.c
> index cfe0f4374594..1f126ca7fbd7 100644
> --- a/kernel/locking/lockdep.c
> +++ b/kernel/locking/lockdep.c
> @@ -2726,7 +2726,7 @@ static inline bool usage_skip(struct lock_list *entry, void *mask)
> * <target> or not. If it can, <src> -> <target> dependency is already
> * in the graph.
> *
> - * Return BFS_RMATCH if it does, or BFS_RMATCH if it does not, return BFS_E* if
> + * Return BFS_RMATCH if it does, or BFS_RNOMATCH if it does not, return BFS_E* if
> * any error appears in the bfs search.
> */
> static noinline enum bfs_result

Sorry I forgot to add version info, this is v2.
Regarding v1 please see https://lkml.org/lkml/2021/6/17/1156.

Regards,
Xiongwei

> --
> 2.30.2
>