2019-04-29 11:54:52

by Christoph Hellwig

[permalink] [raw]
Subject: [PATCH] nds32: don't export low-level cache flushing routines

None of these is used by modules. Nor should they as we have better
highlevel primitives.

Signed-off-by: Christoph Hellwig <[email protected]>
---
arch/nds32/kernel/nds32_ksyms.c | 6 ------
1 file changed, 6 deletions(-)

diff --git a/arch/nds32/kernel/nds32_ksyms.c b/arch/nds32/kernel/nds32_ksyms.c
index 5ecebd0e60cb..20719e42ae36 100644
--- a/arch/nds32/kernel/nds32_ksyms.c
+++ b/arch/nds32/kernel/nds32_ksyms.c
@@ -23,9 +23,3 @@ EXPORT_SYMBOL(memzero);
EXPORT_SYMBOL(__arch_copy_from_user);
EXPORT_SYMBOL(__arch_copy_to_user);
EXPORT_SYMBOL(__arch_clear_user);
-
-/* cache handling */
-EXPORT_SYMBOL(cpu_icache_inval_all);
-EXPORT_SYMBOL(cpu_dcache_wbinval_all);
-EXPORT_SYMBOL(cpu_dma_inval_range);
-EXPORT_SYMBOL(cpu_dma_wb_range);
--
2.20.1


2019-05-07 06:45:33

by Greentime Hu

[permalink] [raw]
Subject: Re: [PATCH] nds32: don't export low-level cache flushing routines

Hi Christoph,

Christoph Hellwig <[email protected]> 於 2019年4月29日 週一 下午7:52寫道:
>
> None of these is used by modules. Nor should they as we have better
> highlevel primitives.
>
> Signed-off-by: Christoph Hellwig <[email protected]>
> ---
> arch/nds32/kernel/nds32_ksyms.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/arch/nds32/kernel/nds32_ksyms.c b/arch/nds32/kernel/nds32_ksyms.c
> index 5ecebd0e60cb..20719e42ae36 100644
> --- a/arch/nds32/kernel/nds32_ksyms.c
> +++ b/arch/nds32/kernel/nds32_ksyms.c
> @@ -23,9 +23,3 @@ EXPORT_SYMBOL(memzero);
> EXPORT_SYMBOL(__arch_copy_from_user);
> EXPORT_SYMBOL(__arch_copy_to_user);
> EXPORT_SYMBOL(__arch_clear_user);
> -
> -/* cache handling */
> -EXPORT_SYMBOL(cpu_icache_inval_all);
> -EXPORT_SYMBOL(cpu_dcache_wbinval_all);
> -EXPORT_SYMBOL(cpu_dma_inval_range);
> -EXPORT_SYMBOL(cpu_dma_wb_range);

Acked-by: Greentime Hu <[email protected]>
Thanks for your patch. I will put in my next tree.