2017-11-28 02:56:59

by Greentime Hu

[permalink] [raw]
Subject: Re: [PATCH v2 30/35] net: faraday add nds32 support.

2017-11-27 22:15 GMT+08:00 Arnd Bergmann <[email protected]>:
> On Mon, Nov 27, 2017 at 1:28 PM, Greentime Hu <[email protected]> wrote:
>> From: Greentime Hu <[email protected]>
>>
>> Signed-off-by: Greentime Hu <[email protected]>
>
> This is missing a patch description.
>

Thanks.
Sorry. I miss it. I will add the commit messages in the next version patch.

>> diff --git a/drivers/net/ethernet/faraday/Kconfig b/drivers/net/ethernet/faraday/Kconfig
>> index 040c7f1..0ae6e9a 100644
>> --- a/drivers/net/ethernet/faraday/Kconfig
>> +++ b/drivers/net/ethernet/faraday/Kconfig
>> @@ -5,7 +5,7 @@
>> config NET_VENDOR_FARADAY
>> bool "Faraday devices"
>> default y
>> - depends on ARM
>> + depends on ARM || NDS32
>> ---help---
>> If you have a network (Ethernet) card belonging to this class, say Y.
>>
>
> We probably want to make all three here
>
> depends on ARM || NDS32 || COMPILE_TEST
>

Thanks.
I will modify it in the next version patch.

From 1585228999906539830@xxx Mon Nov 27 14:16:22 +0000 2017
X-GM-THRID: 1585224127688842509
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread