2020-07-10 13:58:41

by Christoph Hellwig

Subject: [PATCH 2/6] nds32: use uaccess_kernel in show_regs

Use the uaccess_kernel helper instead of duplicating it.

Signed-off-by: Christoph Hellwig <[email protected]>
---
arch/nds32/kernel/process.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/nds32/kernel/process.c b/arch/nds32/kernel/process.c
index 9712fd474f2ca3..f06265949ec28b 100644
--- a/arch/nds32/kernel/process.c
+++ b/arch/nds32/kernel/process.c
@@ -121,7 +121,7 @@ void show_regs(struct pt_regs *regs)
regs->uregs[3], regs->uregs[2], regs->uregs[1], regs->uregs[0]);
pr_info(" IRQs o%s Segment %s\n",
interrupts_enabled(regs) ? "n" : "ff",
- segment_eq(get_fs(), KERNEL_DS)? "kernel" : "user");
+ uaccess_kernel() ? "kernel" : "user");
}

EXPORT_SYMBOL(show_regs);
--
2.26.2

2020-07-13 10:04:39

by Greentime Hu

Subject: Re: [PATCH 2/6] nds32: use uaccess_kernel in show_regs

Christoph Hellwig <[email protected]> 於 2020年7月10日 週五 下午9:57寫道：
>
> Use the uaccess_kernel helper instead of duplicating it.
>
> Signed-off-by: Christoph Hellwig <[email protected]>
> ---
> arch/nds32/kernel/process.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/nds32/kernel/process.c b/arch/nds32/kernel/process.c
> index 9712fd474f2ca3..f06265949ec28b 100644
> --- a/arch/nds32/kernel/process.c
> +++ b/arch/nds32/kernel/process.c
> @@ -121,7 +121,7 @@ void show_regs(struct pt_regs *regs)
> regs->uregs[3], regs->uregs[2], regs->uregs[1], regs->uregs[0]);
> pr_info(" IRQs o%s Segment %s\n",
> interrupts_enabled(regs) ? "n" : "ff",
> - segment_eq(get_fs(), KERNEL_DS)? "kernel" : "user");
> + uaccess_kernel() ? "kernel" : "user");
> }
>
> EXPORT_SYMBOL(show_regs);

Hi Christoph, Thank you.
Acked-by: Greentime Hu <[email protected]>