2018-08-07 04:07:32

by Yue Haibing

Subject: [PATCH] nds32: add NULL entry to the end of_device_id array

Make sure of_device_id tables are NULL terminated.
Found by coccinelle spatch "misc/of_table.cocci"

Signed-off-by: YueHaibing <[email protected]>
---
arch/nds32/kernel/atl2c.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/nds32/kernel/atl2c.c b/arch/nds32/kernel/atl2c.c
index 0c6d031..0c5386e 100644
--- a/arch/nds32/kernel/atl2c.c
+++ b/arch/nds32/kernel/atl2c.c
@@ -9,7 +9,8 @@

void __iomem *atl2c_base;
static const struct of_device_id atl2c_ids[] __initconst = {
- {.compatible = "andestech,atl2c",}
+ {.compatible = "andestech,atl2c",},
+ {}
};

static int __init atl2c_of_init(void)
--
2.7.0

2018-08-08 06:48:03

by Greentime Hu

Subject: Re: [PATCH] nds32: add NULL entry to the end of_device_id array

YueHaibing <[email protected]> 於 2018年8月7日 週二 下午12:03寫道：
>
> Make sure of_device_id tables are NULL terminated.
> Found by coccinelle spatch "misc/of_table.cocci"
>
> Signed-off-by: YueHaibing <[email protected]>
> ---
> arch/nds32/kernel/atl2c.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/nds32/kernel/atl2c.c b/arch/nds32/kernel/atl2c.c
> index 0c6d031..0c5386e 100644
> --- a/arch/nds32/kernel/atl2c.c
> +++ b/arch/nds32/kernel/atl2c.c
> @@ -9,7 +9,8 @@
>
> void __iomem *atl2c_base;
> static const struct of_device_id atl2c_ids[] __initconst = {
> - {.compatible = "andestech,atl2c",}
> + {.compatible = "andestech,atl2c",},
> + {}
> };
>
> static int __init atl2c_of_init(void)

Hi Yuehaibing,

Thank you for your patch.
Acked-by: Greentime Hu <[email protected]>