2021-08-23 01:50:18

by CGEL

Subject: [PATCH linux-next] alpha:smp: fix warning comparing pointer to 0

From: Jing Yangyang <[email protected]>

Fix the following coccicheck warning:
./arch/alpha/kernel/smp.c:271:39-40:
WARNING:comparing pointer to 0

Reported-by: Zeal Robot <[email protected]>
Signed-off-by: Jing Yangyang <[email protected]>
---
arch/alpha/kernel/smp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/alpha/kernel/smp.c b/arch/alpha/kernel/smp.c
index cb64e47..adc05c2 100644
--- a/arch/alpha/kernel/smp.c
+++ b/arch/alpha/kernel/smp.c
@@ -268,7 +268,7 @@ enum ipi_message_type {
memcpy(cp2, cp1, cnt);
cp2[cnt] = '\0';

- while ((cp2 = strchr(cp2, '\r')) != 0) {
+ while ((cp2 = strchr(cp2, '\r'))) {
*cp2 = ' ';
if (cp2[1] == '\n')
cp2[1] = ' ';
--
1.8.3.1

2021-08-23 02:03:50

by Matt Turner

Subject: Re: [PATCH linux-next] alpha:smp: fix warning comparing pointer to 0

On Sun, Aug 22, 2021 at 6:49 PM CGEL <[email protected]> wrote:
>
> From: Jing Yangyang <[email protected]>
>
> Fix the following coccicheck warning:
> ./arch/alpha/kernel/smp.c:271:39-40:
> WARNING:comparing pointer to 0
>
> Reported-by: Zeal Robot <[email protected]>
> Signed-off-by: Jing Yangyang <[email protected]>
> ---
> arch/alpha/kernel/smp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/alpha/kernel/smp.c b/arch/alpha/kernel/smp.c
> index cb64e47..adc05c2 100644
> --- a/arch/alpha/kernel/smp.c
> +++ b/arch/alpha/kernel/smp.c
> @@ -268,7 +268,7 @@ enum ipi_message_type {
> memcpy(cp2, cp1, cnt);
> cp2[cnt] = '\0';
>
> - while ((cp2 = strchr(cp2, '\r')) != 0) {

You may as well compare with NULL, for clarity.