2021-12-13 18:56:33

by Colin Ian King

Subject: [PATCH] alpha: osf_sys: reduce kernel log spamming on invalid osf_mount call typenr

Calling the osf_mount system call with an invalid typenr value will
spam the kernel log with error messages. Reduce the spamming by making
it a ratelimited printk. Issue found when exercising with the stress-ng
enosys system call stressor.

Signed-off-by: Colin Ian King <[email protected]>
---
arch/alpha/kernel/osf_sys.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/alpha/kernel/osf_sys.c b/arch/alpha/kernel/osf_sys.c
index 8bbeebb73cf0..2367a385d726 100644
--- a/arch/alpha/kernel/osf_sys.c
+++ b/arch/alpha/kernel/osf_sys.c
@@ -521,7 +521,7 @@ SYSCALL_DEFINE4(osf_mount, unsigned long, typenr, const char __user *, path,
break;
default:
retval = -EINVAL;
- printk("osf_mount(%ld, %x)\n", typenr, flag);
+ printk_ratelimited("osf_mount(%ld, %x)\n", typenr, flag);
}

return retval;
--
2.33.1

2023-02-26 02:09:20

by Matt Turner

Subject: Re: [PATCH] alpha: osf_sys: reduce kernel log spamming on invalid osf_mount call typenr

On Mon, Dec 13, 2021 at 10:58 PM Colin Ian King <[email protected]> wrote:
>
> Calling the osf_mount system call with an invalid typenr value will
> spam the kernel log with error messages. Reduce the spamming by making
> it a ratelimited printk. Issue found when exercising with the stress-ng
> enosys system call stressor.
>
> Signed-off-by: Colin Ian King <[email protected]>
> ---
> arch/alpha/kernel/osf_sys.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/alpha/kernel/osf_sys.c b/arch/alpha/kernel/osf_sys.c
> index 8bbeebb73cf0..2367a385d726 100644
> --- a/arch/alpha/kernel/osf_sys.c
> +++ b/arch/alpha/kernel/osf_sys.c
> @@ -521,7 +521,7 @@ SYSCALL_DEFINE4(osf_mount, unsigned long, typenr, const char __user *, path,
> break;
> default:
> retval = -EINVAL;
> - printk("osf_mount(%ld, %x)\n", typenr, flag);
> + printk_ratelimited("osf_mount(%ld, %x)\n", typenr, flag);
> }
>
> return retval;
> --
> 2.33.1
>

Thanks for the patch! This was included in my pull request today and
is now upstream in Linus' tree.