LinuxLists.cc - [RFC PATCH 0/9] allocate sys_membarrier system call number on major archs

2015-08-27 18:02:53

Subject: [RFC PATCH 0/9] allocate sys_membarrier system call number on major archs

Wire up the sys_membarrier system call on all major architectures.
This would need testing from architecture maintainers and/or
enthusiasts. Posting as RFC for now. Could be picked into Andrew's
tree once we get the Tested-by tags.

Thanks,

Mathieu

Mathieu Desnoyers (9):
powerpc: allocate sys_membarrier system call number
arm: allocate sys_membarrier system call number
arm64: allocate sys_membarrier system call number
mips: allocate sys_membarrier system call number
s390/s390x: allocate sys_membarrier system call number
sparc/sparc64: allocate sys_membarrier system call number
alpha: allocate sys_membarrier system call number
ia64: allocate sys_membarrier system call number
parisc: allocate sys_membarrier system call number

arch/alpha/include/uapi/asm/unistd.h | 1 +
arch/alpha/kernel/systbls.S | 1 +
arch/arm/include/asm/unistd.h | 2 +-
arch/arm/include/uapi/asm/unistd.h | 1 +
arch/arm/kernel/calls.S | 1 +
arch/arm64/include/asm/unistd32.h | 2 ++
arch/ia64/include/asm/unistd.h | 2 +-
arch/ia64/include/uapi/asm/unistd.h | 1 +
arch/ia64/kernel/entry.S | 1 +
arch/mips/include/uapi/asm/unistd.h | 15 +++++++++------
arch/mips/kernel/scall32-o32.S | 1 +
arch/mips/kernel/scall64-64.S | 1 +
arch/mips/kernel/scall64-n32.S | 1 +
arch/mips/kernel/scall64-o32.S | 1 +
arch/parisc/include/uapi/asm/unistd.h | 3 ++-
arch/parisc/kernel/syscall_table.S | 1 +
arch/powerpc/include/asm/systbl.h | 1 +
arch/powerpc/include/asm/unistd.h | 2 +-
arch/powerpc/include/uapi/asm/unistd.h | 1 +
arch/s390/include/uapi/asm/unistd.h | 3 ++-
arch/s390/kernel/syscalls.S | 1 +
arch/sparc/include/uapi/asm/unistd.h | 3 ++-
arch/sparc/kernel/systbls_32.S | 2 +-
arch/sparc/kernel/systbls_64.S | 4 ++--
24 files changed, 37 insertions(+), 15 deletions(-)

--
1.9.1

2015-08-27 18:02:55

by Mathieu Desnoyers

[permalink] [raw]

Subject: [RFC PATCH 1/9] powerpc: allocate sys_membarrier system call number

Allow it to be used from SPU, since it should not have unwanted
side-effects.

[ Untested on this architecture. To try it out: fetch linux-next/akpm,
apply this patch, build/run a membarrier-enabled kernel, and do make
kselftest. ]

Signed-off-by: Mathieu Desnoyers <[email protected]>
CC: Andrew Morton <[email protected]>
CC: [email protected]
CC: Benjamin Herrenschmidt <[email protected]>
CC: Paul Mackerras <[email protected]>
CC: Michael Ellerman <[email protected]>
CC: [email protected]
---
arch/powerpc/include/asm/systbl.h | 1 +
arch/powerpc/include/asm/unistd.h | 2 +-
arch/powerpc/include/uapi/asm/unistd.h | 1 +
3 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/arch/powerpc/include/asm/systbl.h b/arch/powerpc/include/asm/systbl.h
index 4d65499..126d0c4 100644
--- a/arch/powerpc/include/asm/systbl.h
+++ b/arch/powerpc/include/asm/systbl.h
@@ -369,3 +369,4 @@ SYSCALL_SPU(bpf)
COMPAT_SYS(execveat)
PPC64ONLY(switch_endian)
SYSCALL_SPU(userfaultfd)
+SYSCALL_SPU(membarrier)
diff --git a/arch/powerpc/include/asm/unistd.h b/arch/powerpc/include/asm/unistd.h
index 4a055b6..13411be 100644
--- a/arch/powerpc/include/asm/unistd.h
+++ b/arch/powerpc/include/asm/unistd.h
@@ -12,7 +12,7 @@
#include <uapi/asm/unistd.h>

-#define __NR_syscalls 365
+#define __NR_syscalls 366

#define __NR__exit __NR_exit
#define NR_syscalls __NR_syscalls
diff --git a/arch/powerpc/include/uapi/asm/unistd.h b/arch/powerpc/include/uapi/asm/unistd.h
index 6ad58d4..6337738 100644
--- a/arch/powerpc/include/uapi/asm/unistd.h
+++ b/arch/powerpc/include/uapi/asm/unistd.h
@@ -387,5 +387,6 @@
#define __NR_execveat 362
#define __NR_switch_endian 363
#define __NR_userfaultfd 364
+#define __NR_membarrier 365

#endif /* _UAPI_ASM_POWERPC_UNISTD_H_ */
--
1.9.1

2015-08-27 18:03:37

by Mathieu Desnoyers

[permalink] [raw]

Subject: [RFC PATCH 2/9] arm: allocate sys_membarrier system call number

2015-08-27 18:03:13

by Mathieu Desnoyers

[permalink] [raw]

Subject: [RFC PATCH 3/9] arm64: allocate sys_membarrier system call number

arm64 sys_membarrier number is already wired for arm64 through
asm-generic/unistd.h, but needs to be allocated separately for
the 32-bit compability layer of arm64.

[ Untested on this architecture. To try it out: fetch linux-next/akpm,
apply this patch, build/run a membarrier-enabled kernel, and do make
kselftest. ]

Signed-off-by: Mathieu Desnoyers <[email protected]>
CC: Andrew Morton <[email protected]>
CC: [email protected]
CC: Catalin Marinas <[email protected]>
CC: Will Deacon <[email protected]>
---
arch/arm64/include/asm/unistd32.h | 2 ++
1 file changed, 2 insertions(+)

diff --git a/arch/arm64/include/asm/unistd32.h b/arch/arm64/include/asm/unistd32.h
index cef934a..d97be80 100644
--- a/arch/arm64/include/asm/unistd32.h
+++ b/arch/arm64/include/asm/unistd32.h
@@ -797,3 +797,5 @@ __SYSCALL(__NR_memfd_create, sys_memfd_create)
__SYSCALL(__NR_bpf, sys_bpf)
#define __NR_execveat 387
__SYSCALL(__NR_execveat, compat_sys_execveat)
+#define __NR_membarrier 388
+__SYSCALL(__NR_membarrier, sys_membarrier)
--
1.9.1

2015-08-27 18:03:38

by Mathieu Desnoyers

[permalink] [raw]

Subject: [RFC PATCH 4/9] mips: allocate sys_membarrier system call number

[ Untested on this architecture. To try it out: fetch linux-next/akpm,
apply this patch, build/run a membarrier-enabled kernel, and do make
kselftest. ]

Signed-off-by: Mathieu Desnoyers <[email protected]>
CC: Andrew Morton <[email protected]>
CC: [email protected]
CC: Ralf Baechle <[email protected]>
CC: [email protected]
---
arch/mips/include/uapi/asm/unistd.h | 15 +++++++++------
arch/mips/kernel/scall32-o32.S | 1 +
arch/mips/kernel/scall64-64.S | 1 +
arch/mips/kernel/scall64-n32.S | 1 +
arch/mips/kernel/scall64-o32.S | 1 +
5 files changed, 13 insertions(+), 6 deletions(-)

diff --git a/arch/mips/include/uapi/asm/unistd.h b/arch/mips/include/uapi/asm/unistd.h
index d0bdfaa..b107983 100644
--- a/arch/mips/include/uapi/asm/unistd.h
+++ b/arch/mips/include/uapi/asm/unistd.h
@@ -378,16 +378,17 @@
#define __NR_bpf (__NR_Linux + 355)
#define __NR_execveat (__NR_Linux + 356)
#define __NR_mlock2 (__NR_Linux + 357)
+#define __NR_membarrier (__NR_Linux + 358)

/*
* Offset of the last Linux o32 flavoured syscall
*/
-#define __NR_Linux_syscalls 357
+#define __NR_Linux_syscalls 358

#endif /* _MIPS_SIM == _MIPS_SIM_ABI32 */

#define __NR_O32_Linux 4000
-#define __NR_O32_Linux_syscalls 357
+#define __NR_O32_Linux_syscalls 358

#if _MIPS_SIM == _MIPS_SIM_ABI64

@@ -713,16 +714,17 @@
#define __NR_bpf (__NR_Linux + 315)
#define __NR_execveat (__NR_Linux + 316)
#define __NR_mlock2 (__NR_Linux + 317)
+#define __NR_membarrier (__NR_Linux + 318)

/*
* Offset of the last Linux 64-bit flavoured syscall
*/
-#define __NR_Linux_syscalls 317
+#define __NR_Linux_syscalls 318

#endif /* _MIPS_SIM == _MIPS_SIM_ABI64 */

#define __NR_64_Linux 5000
-#define __NR_64_Linux_syscalls 317
+#define __NR_64_Linux_syscalls 318

#if _MIPS_SIM == _MIPS_SIM_NABI32

@@ -1052,15 +1054,16 @@
#define __NR_bpf (__NR_Linux + 319)
#define __NR_execveat (__NR_Linux + 320)
#define __NR_mlock2 (__NR_Linux + 321)
+#define __NR_membarrier (__NR_Linux + 322)

/*
* Offset of the last N32 flavoured syscall
*/
-#define __NR_Linux_syscalls 321
+#define __NR_Linux_syscalls 322

#endif /* _MIPS_SIM == _MIPS_SIM_NABI32 */

#define __NR_N32_Linux 6000
-#define __NR_N32_Linux_syscalls 321
+#define __NR_N32_Linux_syscalls 322

#endif /* _UAPI_ASM_UNISTD_H */
diff --git a/arch/mips/kernel/scall32-o32.S b/arch/mips/kernel/scall32-o32.S
index b0b377a..9265542 100644
--- a/arch/mips/kernel/scall32-o32.S
+++ b/arch/mips/kernel/scall32-o32.S
@@ -600,3 +600,4 @@ EXPORT(sys_call_table)
PTR sys_bpf /* 4355 */
PTR sys_execveat
PTR sys_mlock2
+ PTR sys_membarrier
diff --git a/arch/mips/kernel/scall64-64.S b/arch/mips/kernel/scall64-64.S
index f12eb03..79d4fb0 100644
--- a/arch/mips/kernel/scall64-64.S
+++ b/arch/mips/kernel/scall64-64.S
@@ -437,4 +437,5 @@ EXPORT(sys_call_table)
PTR sys_bpf /* 5315 */
PTR sys_execveat
PTR sys_mlock2
+ PTR sys_membarrier
.size sys_call_table,.-sys_call_table
diff --git a/arch/mips/kernel/scall64-n32.S b/arch/mips/kernel/scall64-n32.S
index ecdd65a..235892a 100644
--- a/arch/mips/kernel/scall64-n32.S
+++ b/arch/mips/kernel/scall64-n32.S
@@ -430,4 +430,5 @@ EXPORT(sysn32_call_table)
PTR sys_bpf
PTR compat_sys_execveat /* 6320 */
PTR sys_mlock2
+ PTR sys_membarrier
.size sysn32_call_table,.-sysn32_call_table
diff --git a/arch/mips/kernel/scall64-o32.S b/arch/mips/kernel/scall64-o32.S
index 7a8b2df..c051bd3 100644
--- a/arch/mips/kernel/scall64-o32.S
+++ b/arch/mips/kernel/scall64-o32.S
@@ -585,4 +585,5 @@ EXPORT(sys32_call_table)
PTR sys_bpf /* 4355 */
PTR compat_sys_execveat
PTR sys_mlock2
+ PTR sys_membarrier
.size sys32_call_table,.-sys32_call_table
--
1.9.1

2015-08-27 18:04:45

by Mathieu Desnoyers

[permalink] [raw]

Subject: [RFC PATCH 5/9] s390/s390x: allocate sys_membarrier system call number

2015-08-27 18:04:43

by Mathieu Desnoyers

[permalink] [raw]

Subject: [RFC PATCH 6/9] sparc/sparc64: allocate sys_membarrier system call number

[ Untested on this architecture. To try it out: fetch linux-next/akpm,
apply this patch, build/run a membarrier-enabled kernel, and do make
kselftest. ]

Signed-off-by: Mathieu Desnoyers <[email protected]>
CC: Andrew Morton <[email protected]>
CC: [email protected]
CC: "David S. Miller" <[email protected]>
CC: [email protected]
---
arch/sparc/include/uapi/asm/unistd.h | 3 ++-
arch/sparc/kernel/systbls_32.S | 2 +-
arch/sparc/kernel/systbls_64.S | 4 ++--
3 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/arch/sparc/include/uapi/asm/unistd.h b/arch/sparc/include/uapi/asm/unistd.h
index 6f35f4d..efe9479 100644
--- a/arch/sparc/include/uapi/asm/unistd.h
+++ b/arch/sparc/include/uapi/asm/unistd.h
@@ -416,8 +416,9 @@
#define __NR_memfd_create 348
#define __NR_bpf 349
#define __NR_execveat 350
+#define __NR_membarrier 351

-#define NR_syscalls 351
+#define NR_syscalls 352

/* Bitmask values returned from kern_features system call. */
#define KERN_FEATURE_MIXED_MODE_STACK 0x00000001
diff --git a/arch/sparc/kernel/systbls_32.S b/arch/sparc/kernel/systbls_32.S
index e31a905..cc23b62 100644
--- a/arch/sparc/kernel/systbls_32.S
+++ b/arch/sparc/kernel/systbls_32.S
@@ -87,4 +87,4 @@ sys_call_table:
/*335*/ .long sys_syncfs, sys_sendmmsg, sys_setns, sys_process_vm_readv, sys_process_vm_writev
/*340*/ .long sys_ni_syscall, sys_kcmp, sys_finit_module, sys_sched_setattr, sys_sched_getattr
/*345*/ .long sys_renameat2, sys_seccomp, sys_getrandom, sys_memfd_create, sys_bpf
-/*350*/ .long sys_execveat
+/*350*/ .long sys_execveat, sys_membarrier
diff --git a/arch/sparc/kernel/systbls_64.S b/arch/sparc/kernel/systbls_64.S
index d72f76a..f229468 100644
--- a/arch/sparc/kernel/systbls_64.S
+++ b/arch/sparc/kernel/systbls_64.S
@@ -88,7 +88,7 @@ sys_call_table32:
.word sys_syncfs, compat_sys_sendmmsg, sys_setns, compat_sys_process_vm_readv, compat_sys_process_vm_writev
/*340*/ .word sys_kern_features, sys_kcmp, sys_finit_module, sys_sched_setattr, sys_sched_getattr
.word sys32_renameat2, sys_seccomp, sys_getrandom, sys_memfd_create, sys_bpf
-/*350*/ .word sys32_execveat
+/*350*/ .word sys32_execveat, sys_membarrier

#endif /* CONFIG_COMPAT */

@@ -168,4 +168,4 @@ sys_call_table:
.word sys_syncfs, sys_sendmmsg, sys_setns, sys_process_vm_readv, sys_process_vm_writev
/*340*/ .word sys_kern_features, sys_kcmp, sys_finit_module, sys_sched_setattr, sys_sched_getattr
.word sys_renameat2, sys_seccomp, sys_getrandom, sys_memfd_create, sys_bpf
-/*350*/ .word sys64_execveat
+/*350*/ .word sys64_execveat, sys_membarrier
--
1.9.1

2015-08-27 18:04:47

by Mathieu Desnoyers

[permalink] [raw]

Subject: [RFC PATCH 7/9] alpha: allocate sys_membarrier system call number

2015-08-27 18:03:35

by Mathieu Desnoyers

[permalink] [raw]

Subject: [RFC PATCH 8/9] ia64: allocate sys_membarrier system call number

2015-08-27 18:03:34

by Mathieu Desnoyers

[permalink] [raw]

Subject: [RFC PATCH 9/9] parisc: allocate sys_membarrier system call number

2015-08-27 18:34:42

by Matt Turner

[permalink] [raw]

Subject: Re: [RFC PATCH 7/9] alpha: allocate sys_membarrier system call number

On Thu, Aug 27, 2015 at 10:56 AM, Mathieu Desnoyers
<[email protected]> wrote:
> [ Untested on this architecture. To try it out: fetch linux-next/akpm,
> apply this patch, build/run a membarrier-enabled kernel, and do make
> kselftest. ]
>
> Signed-off-by: Mathieu Desnoyers <[email protected]>
> CC: Andrew Morton <[email protected]>
> CC: [email protected]
> CC: Richard Henderson <[email protected]>
> CC: Ivan Kokshaysky <[email protected]>
> CC: Matt Turner <[email protected]>
> CC: [email protected]
> ---
> arch/alpha/include/uapi/asm/unistd.h | 1 +
> arch/alpha/kernel/systbls.S | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/arch/alpha/include/uapi/asm/unistd.h b/arch/alpha/include/uapi/asm/unistd.h
> index aa33bf5..7725619 100644
> --- a/arch/alpha/include/uapi/asm/unistd.h
> +++ b/arch/alpha/include/uapi/asm/unistd.h
> @@ -475,5 +475,6 @@
> #define __NR_getrandom 511
> #define __NR_memfd_create 512
> #define __NR_execveat 513
> +#define __NR_membarrier 514

NR_SYSCALLS in arch/alpha/include/asm/unistd.h needs to be updated as well.

>
> #endif /* _UAPI_ALPHA_UNISTD_H */
> diff --git a/arch/alpha/kernel/systbls.S b/arch/alpha/kernel/systbls.S
> index 9b62e3f..1ea64f4 100644
> --- a/arch/alpha/kernel/systbls.S
> +++ b/arch/alpha/kernel/systbls.S
> @@ -532,6 +532,7 @@ sys_call_table:
> .quad sys_getrandom
> .quad sys_memfd_create
> .quad sys_execveat
> + .quad sys_membarrier
>
> .size sys_call_table, . - sys_call_table
> .type sys_call_table, @object
> --
> 1.9.1
>

2015-08-27 19:06:54

by Mathieu Desnoyers

[permalink] [raw]

Subject: Re: [RFC PATCH 7/9] alpha: allocate sys_membarrier system call number

----- On Aug 27, 2015, at 2:34 PM, Matt Turner [email protected] wrote:

> On Thu, Aug 27, 2015 at 10:56 AM, Mathieu Desnoyers
> <[email protected]> wrote:
>> [ Untested on this architecture. To try it out: fetch linux-next/akpm,
>> apply this patch, build/run a membarrier-enabled kernel, and do make
>> kselftest. ]
>>
>> Signed-off-by: Mathieu Desnoyers <[email protected]>
>> CC: Andrew Morton <[email protected]>
>> CC: [email protected]
>> CC: Richard Henderson <[email protected]>
>> CC: Ivan Kokshaysky <[email protected]>
>> CC: Matt Turner <[email protected]>
>> CC: [email protected]
>> ---
>> arch/alpha/include/uapi/asm/unistd.h | 1 +
>> arch/alpha/kernel/systbls.S | 1 +
>> 2 files changed, 2 insertions(+)
>>
>> diff --git a/arch/alpha/include/uapi/asm/unistd.h
>> b/arch/alpha/include/uapi/asm/unistd.h
>> index aa33bf5..7725619 100644
>> --- a/arch/alpha/include/uapi/asm/unistd.h
>> +++ b/arch/alpha/include/uapi/asm/unistd.h
>> @@ -475,5 +475,6 @@
>> #define __NR_getrandom 511
>> #define __NR_memfd_create 512
>> #define __NR_execveat 513
>> +#define __NR_membarrier 514
>
> NR_SYSCALLS in arch/alpha/include/asm/unistd.h needs to be updated as well.
>

Will send a v2 with this modif, thanks!

Mathieu

>>
>> #endif /* _UAPI_ALPHA_UNISTD_H */
>> diff --git a/arch/alpha/kernel/systbls.S b/arch/alpha/kernel/systbls.S
>> index 9b62e3f..1ea64f4 100644
>> --- a/arch/alpha/kernel/systbls.S
>> +++ b/arch/alpha/kernel/systbls.S
>> @@ -532,6 +532,7 @@ sys_call_table:
>> .quad sys_getrandom
>> .quad sys_memfd_create
>> .quad sys_execveat
>> + .quad sys_membarrier
>>
>> .size sys_call_table, . - sys_call_table
>> .type sys_call_table, @object
>> --
>> 1.9.1

--
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com

2015-08-27 19:08:07

by Mathieu Desnoyers

[permalink] [raw]

Subject: [RFC PATCH v2] alpha: allocate sys_membarrier system call number

2015-08-27 22:51:57

by Russell King - ARM Linux

[permalink] [raw]

Subject: Re: [RFC PATCH 2/9] arm: allocate sys_membarrier system call number

On Thu, Aug 27, 2015 at 01:56:48PM -0400, Mathieu Desnoyers wrote:
> [ Untested on this architecture. To try it out: fetch linux-next/akpm,
> apply this patch, build/run a membarrier-enabled kernel, and do make
> kselftest. ]

But note: the system call is not guaranteed to be allocated at that number
until I've merged the patch. I believe that there's other system calls
which are pending during the next merge window.

--
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.

2015-08-27 23:16:09

by David Miller

[permalink] [raw]

Subject: Re: [RFC PATCH 6/9] sparc/sparc64: allocate sys_membarrier system call number

From: Mathieu Desnoyers <[email protected]>
Date: Thu, 27 Aug 2015 13:56:52 -0400

> [ Untested on this architecture. To try it out: fetch linux-next/akpm,
> apply this patch, build/run a membarrier-enabled kernel, and do make
> kselftest. ]
>
> Signed-off-by: Mathieu Desnoyers <[email protected]>

Acked-by: David S. Miller <[email protected]>

2015-08-27 23:16:53

by Mathieu Desnoyers

[permalink] [raw]

Subject: Re: [RFC PATCH 2/9] arm: allocate sys_membarrier system call number

----- On Aug 27, 2015, at 6:51 PM, Russell King - ARM Linux [email protected] wrote:

> On Thu, Aug 27, 2015 at 01:56:48PM -0400, Mathieu Desnoyers wrote:
>> [ Untested on this architecture. To try it out: fetch linux-next/akpm,
>> apply this patch, build/run a membarrier-enabled kernel, and do make
>> kselftest. ]
>
> But note: the system call is not guaranteed to be allocated at that number
> until I've merged the patch. I believe that there's other system calls
> which are pending during the next merge window.

Sure, no problem. I mainly want to make sure the system call
works fine on each major arch before we reach the merge window.

Let me know if you want me to send an updated version of this
patch during or after the merge window.

Thanks!

Mathieu

--
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com

2015-08-28 07:40:42

by Ralf Baechle

[permalink] [raw]

Subject: Re: [RFC PATCH 4/9] mips: allocate sys_membarrier system call number

On Thu, Aug 27, 2015 at 01:56:50PM -0400, Mathieu Desnoyers wrote:

> [ Untested on this architecture. To try it out: fetch linux-next/akpm,
> apply this patch, build/run a membarrier-enabled kernel, and do make
> kselftest. ]
>
> Signed-off-by: Mathieu Desnoyers <[email protected]>
> CC: Andrew Morton <[email protected]>
> CC: [email protected]
> CC: Ralf Baechle <[email protected]>
> CC: [email protected]
> ---
> arch/mips/include/uapi/asm/unistd.h | 15 +++++++++------
> arch/mips/kernel/scall32-o32.S | 1 +
> arch/mips/kernel/scall64-64.S | 1 +
> arch/mips/kernel/scall64-n32.S | 1 +
> arch/mips/kernel/scall64-o32.S | 1 +
> 5 files changed, 13 insertions(+), 6 deletions(-)

Looking good assuming there is no compat syscall required.

Ralf

2015-08-28 14:06:28

by Mathieu Desnoyers

[permalink] [raw]

Subject: Re: [RFC PATCH 4/9] mips: allocate sys_membarrier system call number

----- On Aug 28, 2015, at 3:40 AM, Ralf Baechle [email protected] wrote:

> On Thu, Aug 27, 2015 at 01:56:50PM -0400, Mathieu Desnoyers wrote:
>
>> [ Untested on this architecture. To try it out: fetch linux-next/akpm,
>> apply this patch, build/run a membarrier-enabled kernel, and do make
>> kselftest. ]
>>
>> Signed-off-by: Mathieu Desnoyers <[email protected]>
>> CC: Andrew Morton <[email protected]>
>> CC: [email protected]
>> CC: Ralf Baechle <[email protected]>
>> CC: [email protected]
>> ---
>> arch/mips/include/uapi/asm/unistd.h | 15 +++++++++------
>> arch/mips/kernel/scall32-o32.S | 1 +
>> arch/mips/kernel/scall64-64.S | 1 +
>> arch/mips/kernel/scall64-n32.S | 1 +
>> arch/mips/kernel/scall64-o32.S | 1 +
>> 5 files changed, 13 insertions(+), 6 deletions(-)
>
> Looking good assuming there is no compat syscall required.

Indeed, sys_membarrier only takes two integer arguments, so no
compat syscall is required.

Thanks!

Mathieu

--
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com

2015-08-31 06:54:10

by Michael Ellerman

[permalink] [raw]

Subject: Re: [RFC PATCH 1/9] powerpc: allocate sys_membarrier system call number

On Thu, 2015-08-27 at 13:56 -0400, Mathieu Desnoyers wrote:
> Allow it to be used from SPU, since it should not have unwanted
> side-effects.
>
> [ Untested on this architecture. To try it out: fetch linux-next/akpm,
> apply this patch, build/run a membarrier-enabled kernel, and do make
> kselftest. ]
>
> Signed-off-by: Mathieu Desnoyers <[email protected]>
> CC: Andrew Morton <[email protected]>
> CC: [email protected]
> CC: Benjamin Herrenschmidt <[email protected]>
> CC: Paul Mackerras <[email protected]>
> CC: Michael Ellerman <[email protected]>
> CC: [email protected]

Thanks.

I get:

$ ./membarrier_test
membarrier MEMBARRIER_CMD_QUERY syscall available.
membarrier: MEMBARRIER_CMD_SHARED success.
membarrier: tests done!

Which looks good.

Assuming the membarrier support hits 4.3, I'll take this via my tree for 4.3
also.

cheers

2015-08-31 15:33:11

by Mathieu Desnoyers

[permalink] [raw]

Subject: Re: [RFC PATCH 1/9] powerpc: allocate sys_membarrier system call number

----- On Aug 31, 2015, at 2:54 AM, Michael Ellerman [email protected] wrote:

> On Thu, 2015-08-27 at 13:56 -0400, Mathieu Desnoyers wrote:
>> Allow it to be used from SPU, since it should not have unwanted
>> side-effects.
>>
>> [ Untested on this architecture. To try it out: fetch linux-next/akpm,
>> apply this patch, build/run a membarrier-enabled kernel, and do make
>> kselftest. ]
>>
>> Signed-off-by: Mathieu Desnoyers <[email protected]>
>> CC: Andrew Morton <[email protected]>
>> CC: [email protected]
>> CC: Benjamin Herrenschmidt <[email protected]>
>> CC: Paul Mackerras <[email protected]>
>> CC: Michael Ellerman <[email protected]>
>> CC: [email protected]
>
> Thanks.
>
> I get:
>
> $ ./membarrier_test
> membarrier MEMBARRIER_CMD_QUERY syscall available.
> membarrier: MEMBARRIER_CMD_SHARED success.
> membarrier: tests done!
>
> Which looks good.
>
> Assuming the membarrier support hits 4.3, I'll take this via my tree for 4.3
> also.

Great! I'll take care of your comments about self-tests,

Thanks,

Mathieu

--
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com

2015-09-01 01:00:47

by Michael Ellerman

[permalink] [raw]

Subject: Re: [RFC PATCH 1/9] powerpc: allocate sys_membarrier system call number

On Mon, 2015-08-31 at 15:32 +0000, Mathieu Desnoyers wrote:
> ----- On Aug 31, 2015, at 2:54 AM, Michael Ellerman [email protected] wrote:
>
> > On Thu, 2015-08-27 at 13:56 -0400, Mathieu Desnoyers wrote:
> >> Allow it to be used from SPU, since it should not have unwanted
> >> side-effects.

> > $ ./membarrier_test
> > membarrier MEMBARRIER_CMD_QUERY syscall available.
> > membarrier: MEMBARRIER_CMD_SHARED success.
> > membarrier: tests done!
> >
> > Which looks good.
> >
> > Assuming the membarrier support hits 4.3, I'll take this via my tree for 4.3
> > also.
>
> Great! I'll take care of your comments about self-tests,

Thanks. None of them are critical so we can always fix them later.

cheers