2020-01-16 13:24:20

by Toke Høiland-Jørgensen

[permalink] [raw]
Subject: [PATCH bpf-next v3 10/11] tools/runqslower: Remove tools/lib/bpf from include path

From: Toke Høiland-Jørgensen <[email protected]>

Since we are now consistently using the bpf/ prefix on #include directives,
we don't need to include tools/lib/bpf in the include path. Remove it to
make sure we don't inadvertently introduce new includes without the prefix.

Signed-off-by: Toke Høiland-Jørgensen <[email protected]>
---
tools/bpf/runqslower/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/bpf/runqslower/Makefile b/tools/bpf/runqslower/Makefile
index c0512b830805..d474608159f5 100644
--- a/tools/bpf/runqslower/Makefile
+++ b/tools/bpf/runqslower/Makefile
@@ -5,7 +5,7 @@ LLC := llc
LLVM_STRIP := llvm-strip
DEFAULT_BPFTOOL := $(OUTPUT)/sbin/bpftool
BPFTOOL ?= $(DEFAULT_BPFTOOL)
-LIBBPF_INCLUDE := -I$(abspath ../../lib) -I$(abspath ../../lib/bpf)
+LIBBPF_INCLUDE := -I$(abspath ../../lib)
LIBBPF_SRC := $(abspath ../../lib/bpf)
CFLAGS := -g -Wall



2020-01-16 23:27:13

by Andrii Nakryiko

[permalink] [raw]
Subject: Re: [PATCH bpf-next v3 10/11] tools/runqslower: Remove tools/lib/bpf from include path

On Thu, Jan 16, 2020 at 5:23 AM Toke Høiland-Jørgensen <[email protected]> wrote:
>
> From: Toke Høiland-Jørgensen <[email protected]>
>
> Since we are now consistently using the bpf/ prefix on #include directives,
> we don't need to include tools/lib/bpf in the include path. Remove it to
> make sure we don't inadvertently introduce new includes without the prefix.
>
> Signed-off-by: Toke Høiland-Jørgensen <[email protected]>
> ---

Acked-by: Andrii Nakryiko <[email protected]>

> tools/bpf/runqslower/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/bpf/runqslower/Makefile b/tools/bpf/runqslower/Makefile
> index c0512b830805..d474608159f5 100644
> --- a/tools/bpf/runqslower/Makefile
> +++ b/tools/bpf/runqslower/Makefile
> @@ -5,7 +5,7 @@ LLC := llc
> LLVM_STRIP := llvm-strip
> DEFAULT_BPFTOOL := $(OUTPUT)/sbin/bpftool
> BPFTOOL ?= $(DEFAULT_BPFTOOL)
> -LIBBPF_INCLUDE := -I$(abspath ../../lib) -I$(abspath ../../lib/bpf)
> +LIBBPF_INCLUDE := -I$(abspath ../../lib)
> LIBBPF_SRC := $(abspath ../../lib/bpf)
> CFLAGS := -g -Wall
>
>