2022-04-16 02:41:35

by Alexander Lobakin

[permalink] [raw]
Subject: [PATCH bpf-next 00/11] bpf: random unpopular userspace fixes (32 bit et al.)

This mostly issues the cross build (1) errors for 32 bit (2)
MIPS (3) with minimal configuration (4) on Musl (5). The majority
of them aren't yesterday's, so it is a "who does need it outside
of x86_64 or ARM64?" moment again.
Trivial stuff in general, not counting the bpf_cookie build fix.

Alexander Lobakin (11):
bpf, perf: fix bpftool compilation with !CONFIG_PERF_EVENTS
bpf: always emit struct bpf_perf_link BTF
tools, bpf: fix bpftool build with !CONFIG_BPF_EVENTS
samples: bpf: add 'asm/mach-generic' include path for every MIPS
samples: bpf: use host bpftool to generate vmlinux.h, not target
tools, bpf: fix fcntl.h include in bpftool
samples: bpf: fix uin64_t format literals
samples: bpf: fix shifting unsigned long by 32 positions
samples: bpf: fix include order for non-Glibc environments
samples: bpf: fix -Wsequence-point
samples: bpf: xdpsock: fix -Wmaybe-uninitialized

include/linux/perf_event.h | 2 ++
kernel/bpf/syscall.c | 4 +++-
samples/bpf/Makefile | 7 ++++---
samples/bpf/cookie_uid_helper_example.c | 12 ++++++------
samples/bpf/lathist_kern.c | 2 +-
samples/bpf/lwt_len_hist_kern.c | 2 +-
samples/bpf/lwt_len_hist_user.c | 4 ++--
samples/bpf/task_fd_query_user.c | 2 +-
samples/bpf/test_lru_dist.c | 3 ++-
samples/bpf/tracex2_kern.c | 2 +-
samples/bpf/xdpsock_user.c | 5 +++--
tools/bpf/bpftool/tracelog.c | 2 +-
12 files changed, 27 insertions(+), 20 deletions(-)

--
2.35.2



2022-04-20 20:53:56

by Andrii Nakryiko

[permalink] [raw]
Subject: Re: [PATCH bpf-next 00/11] bpf: random unpopular userspace fixes (32 bit et al.)

On Thu, Apr 14, 2022 at 3:44 PM Alexander Lobakin <[email protected]> wrote:
>
> This mostly issues the cross build (1) errors for 32 bit (2)
> MIPS (3) with minimal configuration (4) on Musl (5). The majority
> of them aren't yesterday's, so it is a "who does need it outside
> of x86_64 or ARM64?" moment again.
> Trivial stuff in general, not counting the bpf_cookie build fix.
>
> Alexander Lobakin (11):
> bpf, perf: fix bpftool compilation with !CONFIG_PERF_EVENTS
> bpf: always emit struct bpf_perf_link BTF
> tools, bpf: fix bpftool build with !CONFIG_BPF_EVENTS
> samples: bpf: add 'asm/mach-generic' include path for every MIPS
> samples: bpf: use host bpftool to generate vmlinux.h, not target
> tools, bpf: fix fcntl.h include in bpftool
> samples: bpf: fix uin64_t format literals
> samples: bpf: fix shifting unsigned long by 32 positions
> samples: bpf: fix include order for non-Glibc environments
> samples: bpf: fix -Wsequence-point
> samples: bpf: xdpsock: fix -Wmaybe-uninitialized
>

For consistency with majority of other commits, can you please use
"samples/bpf: " prefix for samples/bpf changes and "bpftool: " for
bpftool's ones? Thanks!

> include/linux/perf_event.h | 2 ++
> kernel/bpf/syscall.c | 4 +++-
> samples/bpf/Makefile | 7 ++++---
> samples/bpf/cookie_uid_helper_example.c | 12 ++++++------
> samples/bpf/lathist_kern.c | 2 +-
> samples/bpf/lwt_len_hist_kern.c | 2 +-
> samples/bpf/lwt_len_hist_user.c | 4 ++--
> samples/bpf/task_fd_query_user.c | 2 +-
> samples/bpf/test_lru_dist.c | 3 ++-
> samples/bpf/tracex2_kern.c | 2 +-
> samples/bpf/xdpsock_user.c | 5 +++--
> tools/bpf/bpftool/tracelog.c | 2 +-
> 12 files changed, 27 insertions(+), 20 deletions(-)
>
> --
> 2.35.2
>
>