From: Paul McKenney <[email protected]>
This is needed for a future tracepoint patch that uses srcu, and to make
sure it doesn't call into lockdep.
tracepoint code already calls notrace variants for rcu_read_lock_sched
so this patch does the same for srcu which will be used in a later
patch. Keeps it consistent with rcu-sched.
[Joel: Added commit message]
Cc: Steven Rostedt <[email protected]>
Cc: Peter Zilstra <[email protected]>
Cc: Ingo Molnar <[email protected]>
Cc: Mathieu Desnoyers <[email protected]>
Cc: Tom Zanussi <[email protected]>
Cc: Namhyung Kim <[email protected]>
Cc: Thomas Glexiner <[email protected]>
Cc: Boqun Feng <[email protected]>
Cc: Paul McKenney <[email protected]>
Cc: Frederic Weisbecker <[email protected]>
Cc: Randy Dunlap <[email protected]>
Cc: Masami Hiramatsu <[email protected]>
Cc: Fenguang Wu <[email protected]>
Cc: Baohong Liu <[email protected]>
Cc: Vedang Patel <[email protected]>
Cc: [email protected]
Reviewed-by: Steven Rostedt (VMware) <[email protected]>
Signed-off-by: Paul McKenney <[email protected]>
Signed-off-by: Joel Fernandes (Google) <[email protected]>
---
include/linux/srcu.h | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/include/linux/srcu.h b/include/linux/srcu.h
index 33c1c698df09..2ec618979b20 100644
--- a/include/linux/srcu.h
+++ b/include/linux/srcu.h
@@ -161,6 +161,16 @@ static inline int srcu_read_lock(struct srcu_struct *sp) __acquires(sp)
return retval;
}
+/* Used by tracing, cannot be traced and cannot invoke lockdep. */
+static inline notrace int
+srcu_read_lock_notrace(struct srcu_struct *sp) __acquires(sp)
+{
+ int retval;
+
+ retval = __srcu_read_lock(sp);
+ return retval;
+}
+
/**
* srcu_read_unlock - unregister a old reader from an SRCU-protected structure.
* @sp: srcu_struct in which to unregister the old reader.
@@ -175,6 +185,13 @@ static inline void srcu_read_unlock(struct srcu_struct *sp, int idx)
__srcu_read_unlock(sp, idx);
}
+/* Used by tracing, cannot be traced and cannot call lockdep. */
+static inline notrace void
+srcu_read_unlock_notrace(struct srcu_struct *sp, int idx) __releases(sp)
+{
+ __srcu_read_unlock(sp, idx);
+}
+
/**
* smp_mb__after_srcu_read_unlock - ensure full ordering after srcu_read_unlock
*
--
2.17.0.441.gb46fe60e1d-goog
Something is majorly messed up with my SMTP server. Only half of the patches
in this series were sent out and the ones that did go out were random.
I keeping getting this as replies for the one's that didn't go out:
https://support.google.com/mail/answer/6596?visit_id=1-636620224226493206-2884214369&rd=1
And its intermittent too.. I am going to spend a bit of time to figure out
why it happened so it doesn't happen again. Sorry about the noise.
Sigh,
- Joel
On Tue, May 15, 2018 at 3:47 PM Joel Fernandes (Google) <
[email protected]> wrote:
> From: Paul McKenney <[email protected]>
> This is needed for a future tracepoint patch that uses srcu, and to make
> sure it doesn't call into lockdep.
> tracepoint code already calls notrace variants for rcu_read_lock_sched
> so this patch does the same for srcu which will be used in a later
> patch. Keeps it consistent with rcu-sched.
> [Joel: Added commit message]
> Cc: Steven Rostedt <[email protected]>
> Cc: Peter Zilstra <[email protected]>
> Cc: Ingo Molnar <[email protected]>
> Cc: Mathieu Desnoyers <[email protected]>
> Cc: Tom Zanussi <[email protected]>
> Cc: Namhyung Kim <[email protected]>
> Cc: Thomas Glexiner <[email protected]>
> Cc: Boqun Feng <[email protected]>
> Cc: Paul McKenney <[email protected]>
> Cc: Frederic Weisbecker <[email protected]>
> Cc: Randy Dunlap <[email protected]>
> Cc: Masami Hiramatsu <[email protected]>
> Cc: Fenguang Wu <[email protected]>
> Cc: Baohong Liu <[email protected]>
> Cc: Vedang Patel <[email protected]>
> Cc: [email protected]
> Reviewed-by: Steven Rostedt (VMware) <[email protected]>
> Signed-off-by: Paul McKenney <[email protected]>
> Signed-off-by: Joel Fernandes (Google) <[email protected]>
> ---
> include/linux/srcu.h | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
> diff --git a/include/linux/srcu.h b/include/linux/srcu.h
> index 33c1c698df09..2ec618979b20 100644
> --- a/include/linux/srcu.h
> +++ b/include/linux/srcu.h
> @@ -161,6 +161,16 @@ static inline int srcu_read_lock(struct srcu_struct
*sp) __acquires(sp)
> return retval;
> }
> +/* Used by tracing, cannot be traced and cannot invoke lockdep. */
> +static inline notrace int
> +srcu_read_lock_notrace(struct srcu_struct *sp) __acquires(sp)
> +{
> + int retval;
> +
> + retval = __srcu_read_lock(sp);
> + return retval;
> +}
> +
> /**
> * srcu_read_unlock - unregister a old reader from an SRCU-protected
structure.
> * @sp: srcu_struct in which to unregister the old reader.
> @@ -175,6 +185,13 @@ static inline void srcu_read_unlock(struct
srcu_struct *sp, int idx)
> __srcu_read_unlock(sp, idx);
> }
> +/* Used by tracing, cannot be traced and cannot call lockdep. */
> +static inline notrace void
> +srcu_read_unlock_notrace(struct srcu_struct *sp, int idx) __releases(sp)
> +{
> + __srcu_read_unlock(sp, idx);
> +}
> +
> /**
> * smp_mb__after_srcu_read_unlock - ensure full ordering after
srcu_read_unlock
> *
> --
> 2.17.0.441.gb46fe60e1d-goog