Hi Randy,
On Mon, Nov 27, 2017 at 7:48 PM, Randy Dunlap <[email protected]> wrote:
> Hi,
>
> Mostly typos/spellos...
>
>
> On 11/27/2017 09:18 AM, Djalal Harouni wrote:
>> Cc: Serge Hallyn <[email protected]>
>> Cc: Andy Lutomirski <[email protected]>
>> Suggested-by: Rusty Russell <[email protected]>
>> Suggested-by: Kees Cook <[email protected]>
>> Signed-off-by: Djalal Harouni <[email protected]>
>> ---
>> include/linux/kmod.h | 65 ++++++++++++++++++++++++++++++++++++++++++-----
>> include/linux/lsm_hooks.h | 6 ++++-
>> include/linux/security.h | 7 +++--
>> kernel/kmod.c | 29 ++++++++++++++++-----
>> security/security.c | 6 +++--
>> security/selinux/hooks.c | 3 ++-
>> 6 files changed, 97 insertions(+), 19 deletions(-)
>>
>> diff --git a/include/linux/kmod.h b/include/linux/kmod.h
>> index 40c89ad..ccd6a1c 100644
>> --- a/include/linux/kmod.h
>> +++ b/include/linux/kmod.h
>> @@ -33,16 +33,67 @@
>
>> +/**
>> + * request_module Try to load a kernel module
>> + *
>> + * Automatically loads the request module.
>> + *
>> + * @mod...: The module name
>> + */
>
> what are the "..." for? what do they do here?
Ok, will fix it.
>
>> +#define request_module(mod...) __request_module(true, -1, NULL, mod)
>> +
>> +#define request_module_nowait(mod...) __request_module(false, -1, NULL, mod)
>> +
>> +/**
>> + * request_module_cap Load kernel module only if the required capability is set
>> + *
[...]
>
>
> --
> ~Randy
Thank you very much for the review, will fix all.
--
tixxdz
From 1585246199667214014@xxx Mon Nov 27 18:49:45 +0000 2017
X-GM-THRID: 1585240691370988488
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread