2023-04-04 12:35:31

by Aleksandr Mikhalitsyn

[permalink] [raw]
Subject: [PATCH 0/2] KVM: SVM: small tweaks for sev_hardware_setup

KVM: SVM: add some info prints to SEV init

Let's add a few pr_info's to sev_hardware_setup to make SEV/SEV-ES
enabling a little bit handier for users. Right now it's too hard
to guess why SEV/SEV-ES are failing to enable.

There are a few reasons.
SEV:
- npt is disabled (module parameter)
- CPU lacks some features (sev, decodeassists)
- Maximum SEV ASID is 0

SEV-ES:
- mmio_caching is disabled (module parameter)
- CPU lacks sev_es feature
- Minimum SEV ASID value is 1 (can be adjusted in BIOS/UEFI)

==

KVM: SVM: free sev_*asid_bitmap init if SEV init fails

If misc_cg_set_capacity() fails for some reason then we have
a memleak for sev_reclaim_asid_bitmap/sev_asid_bitmap. It's
not a case right now, because misc_cg_set_capacity() just can't
fail and check inside it is always successful.

But let's fix that for code consistency.

Cc: Sean Christopherson <[email protected]>
Cc: Paolo Bonzini <[email protected]>
Cc: Stéphane Graber <[email protected]>
Cc: [email protected]
Cc: [email protected]
Signed-off-by: Alexander Mikhalitsyn <[email protected]>

Alexander Mikhalitsyn (2):
KVM: SVM: free sev_*asid_bitmap init if SEV init fails
KVM: SVM: add some info prints to SEV init

arch/x86/kvm/svm/sev.c | 34 +++++++++++++++++++++++++++-------
1 file changed, 27 insertions(+), 7 deletions(-)

--
2.34.1


2023-04-06 03:48:51

by Sean Christopherson

[permalink] [raw]
Subject: Re: [PATCH 0/2] KVM: SVM: small tweaks for sev_hardware_setup

Please tag patches with RESEND when re-sending the exact patches with different
To/Cc fields. Not a big deal, but I blinked a few times trying to figure out
if I really had two copies, or if it's just time for me to log off for the night :-)

2023-04-06 07:20:24

by Aleksandr Mikhalitsyn

[permalink] [raw]
Subject: Re: [PATCH 0/2] KVM: SVM: small tweaks for sev_hardware_setup

On Thu, Apr 6, 2023 at 5:32 AM Sean Christopherson <[email protected]> wrote:
>
> Please tag patches with RESEND when re-sending the exact patches with different
> To/Cc fields. Not a big deal, but I blinked a few times trying to figure out
> if I really had two copies, or if it's just time for me to log off for the night :-)

Hi Sean,

yep, I'm sorry about that. First time I've sent patches without proper
CC's by mistake.

Kind regards,
Alex