2013-05-29 12:31:20

by Jan Beulich

Subject: [PATCH] xen-pciback: more uses of cached MSI-X capability offset

Signed-off-by: Jan Beulich <[email protected]>

---
drivers/xen/xen-pciback/pci_stub.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

--- 3.10-rc3/drivers/xen/xen-pciback/pci_stub.c
+++ 3.10-rc3-xen-pciback-MSI-X-cap/drivers/xen/xen-pciback/pci_stub.c
@@ -106,7 +106,7 @@ static void pcistub_device_release(struc
else
pci_restore_state(dev);

- if (pci_find_capability(dev, PCI_CAP_ID_MSIX)) {
+ if (dev->msix_cap) {
struct physdev_pci_device ppdev = {
.seg = pci_domain_nr(dev->bus),
.bus = dev->bus->number,
@@ -371,7 +371,7 @@ static int pcistub_init_device(struct pc
if (err)
goto config_release;

- if (pci_find_capability(dev, PCI_CAP_ID_MSIX)) {
+ if (dev->msix_cap) {
struct physdev_pci_device ppdev = {
.seg = pci_domain_nr(dev->bus),
.bus = dev->bus->number,

2013-05-29 20:51:38

by Bjorn Helgaas

Subject: Re: [PATCH] xen-pciback: more uses of cached MSI-X capability offset

On Wed, May 29, 2013 at 6:31 AM, Jan Beulich <[email protected]> wrote:
> Signed-off-by: Jan Beulich <[email protected]>
>
> ---
> drivers/xen/xen-pciback/pci_stub.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

Acked-by: Bjorn Helgaas <[email protected]>

I assume you'll take this, Konrad. Let me know if you need me to do anything.

> --- 3.10-rc3/drivers/xen/xen-pciback/pci_stub.c
> +++ 3.10-rc3-xen-pciback-MSI-X-cap/drivers/xen/xen-pciback/pci_stub.c
> @@ -106,7 +106,7 @@ static void pcistub_device_release(struc
> else
> pci_restore_state(dev);
>
> - if (pci_find_capability(dev, PCI_CAP_ID_MSIX)) {
> + if (dev->msix_cap) {
> struct physdev_pci_device ppdev = {
> .seg = pci_domain_nr(dev->bus),
> .bus = dev->bus->number,
> @@ -371,7 +371,7 @@ static int pcistub_init_device(struct pc
> if (err)
> goto config_release;
>
> - if (pci_find_capability(dev, PCI_CAP_ID_MSIX)) {
> + if (dev->msix_cap) {
> struct physdev_pci_device ppdev = {
> .seg = pci_domain_nr(dev->bus),
> .bus = dev->bus->number,
>
>
>

2013-05-29 21:04:02

by Konrad Rzeszutek Wilk

Subject: Re: [PATCH] xen-pciback: more uses of cached MSI-X capability offset

On Wed, May 29, 2013 at 02:51:11PM -0600, Bjorn Helgaas wrote:
> On Wed, May 29, 2013 at 6:31 AM, Jan Beulich <[email protected]> wrote:
> > Signed-off-by: Jan Beulich <[email protected]>
> >
> > ---
> > drivers/xen/xen-pciback/pci_stub.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Acked-by: Bjorn Helgaas <[email protected]>
>
> I assume you'll take this, Konrad. Let me know if you need me to do anything.

Yes, in my queue as we speak. Thanks.
>
> > --- 3.10-rc3/drivers/xen/xen-pciback/pci_stub.c
> > +++ 3.10-rc3-xen-pciback-MSI-X-cap/drivers/xen/xen-pciback/pci_stub.c
> > @@ -106,7 +106,7 @@ static void pcistub_device_release(struc
> > else
> > pci_restore_state(dev);
> >
> > - if (pci_find_capability(dev, PCI_CAP_ID_MSIX)) {
> > + if (dev->msix_cap) {
> > struct physdev_pci_device ppdev = {
> > .seg = pci_domain_nr(dev->bus),
> > .bus = dev->bus->number,
> > @@ -371,7 +371,7 @@ static int pcistub_init_device(struct pc
> > if (err)
> > goto config_release;
> >
> > - if (pci_find_capability(dev, PCI_CAP_ID_MSIX)) {
> > + if (dev->msix_cap) {
> > struct physdev_pci_device ppdev = {
> > .seg = pci_domain_nr(dev->bus),
> > .bus = dev->bus->number,
> >
> >
> >