2018-10-09 07:16:18

by Abdul Haleem

[permalink] [raw]
Subject: [linux-next][bisected e3fbcc7c] build error at drivers/pci/pcie/aer_inject.c:444:6: error: ‘struct pt_regs’ has no member named ‘ip

Greeting's

Today's linux-next fails to build on ppc with below error

drivers/pci/pcie/aer_inject.c: In function ‘aer_inject_ftrace_thunk’:
drivers/pci/pcie/aer_inject.c:444:6: error: ‘struct pt_regs’ has no
member named ‘ip’
regs->ip = (unsigned long) hook->function;
^
make[3]: *** [drivers/pci/pcie/aer_inject.o] Error 1
make[2]: *** [drivers/pci/pcie] Error 2
make[1]: *** [drivers/pci] Error 2

Machine: Power 9
kernel version: 4.19.0-rc7-next-20181008
gcc version: 4.8.5 20150623
config attached

Recent code changes from these commits:

c79ad38b36dd4967d67f83fc48bade37ee041a47 PCI/AER: Abstract AER interrupt handling
7b23285f930a8dedcbf749661cd0f2cc27f79be6 PCI/AER: Reuse existing pcie_port_find_device() interface
e3fbcc7c4b130f81ea586183db561fa3ce9c6447 PCI/AER: Covertly inject errors with ftrace hooks
4696b828ca3781deebc3f61d50978d5c8c5be405 PCI/AER: Hoist aerdrv.c, aer_inject.c up to drivers/pci/pcie/


--
Regard's

Abdul Haleem
IBM Linux Technology Centre


Attachments:
ZZ-VM-config (149.70 kB)

2018-10-09 09:48:06

by Michael Ellerman

[permalink] [raw]
Subject: Re: [linux-next][bisected e3fbcc7c] build error at drivers/pci/pcie/aer_inject.c:444:6: error: ‘struct pt_regs’ has no member named ‘ip

Abdul Haleem <[email protected]> writes:
> Greeting's
>
> Today's linux-next fails to build on ppc with below error
>
> drivers/pci/pcie/aer_inject.c: In function ‘aer_inject_ftrace_thunk’:
> drivers/pci/pcie/aer_inject.c:444:6: error: ‘struct pt_regs’ has no
> member named ‘ip’
> regs->ip = (unsigned long) hook->function;
> ^
> make[3]: *** [drivers/pci/pcie/aer_inject.o] Error 1
> make[2]: *** [drivers/pci/pcie] Error 2
> make[1]: *** [drivers/pci] Error 2
>
> Machine: Power 9
> kernel version: 4.19.0-rc7-next-20181008
> gcc version: 4.8.5 20150623
> config attached
>
> Recent code changes from these commits:
>
> c79ad38b36dd4967d67f83fc48bade37ee041a47 PCI/AER: Abstract AER interrupt handling
> 7b23285f930a8dedcbf749661cd0f2cc27f79be6 PCI/AER: Reuse existing pcie_port_find_device() interface
> e3fbcc7c4b130f81ea586183db561fa3ce9c6447 PCI/AER: Covertly inject errors with ftrace hooks

I don't see this commit in today's linux next (20181009) so presumably
someone else has noticed and dropped the commit?

cheers

2018-10-09 10:42:38

by Abdul Haleem

[permalink] [raw]
Subject: Re: [linux-next][bisected e3fbcc7c] build error at drivers/pci/pcie/aer_inject.c:444:6: error: ‘struct pt_regs’ has no member named ‘ip

On Tue, 2018-10-09 at 20:47 +1100, Michael Ellerman wrote:
> Abdul Haleem <[email protected]> writes:
> > Greeting's
> >
> > Today's linux-next fails to build on ppc with below error
> >
> > drivers/pci/pcie/aer_inject.c: In function ‘aer_inject_ftrace_thunk’:
> > drivers/pci/pcie/aer_inject.c:444:6: error: ‘struct pt_regs’ has no
> > member named ‘ip’
> > regs->ip = (unsigned long) hook->function;
> > ^
> > make[3]: *** [drivers/pci/pcie/aer_inject.o] Error 1
> > make[2]: *** [drivers/pci/pcie] Error 2
> > make[1]: *** [drivers/pci] Error 2
> >
> > Machine: Power 9
> > kernel version: 4.19.0-rc7-next-20181008
> > gcc version: 4.8.5 20150623
> > config attached
> >
> > Recent code changes from these commits:
> >
> > c79ad38b36dd4967d67f83fc48bade37ee041a47 PCI/AER: Abstract AER interrupt handling
> > 7b23285f930a8dedcbf749661cd0f2cc27f79be6 PCI/AER: Reuse existing pcie_port_find_device() interface
> > e3fbcc7c4b130f81ea586183db561fa3ce9c6447 PCI/AER: Covertly inject errors with ftrace hooks
>
> I don't see this commit in today's linux next (20181009) so presumably
> someone else has noticed and dropped the commit?

Yes, the commit is dropped from next-20181009, and now build is fine.

--
Regard's

Abdul Haleem
IBM Linux Technology Centre




2018-10-09 12:18:16

by Bjorn Helgaas

[permalink] [raw]
Subject: Re: [linux-next][bisected e3fbcc7c] build error at d rivers/pci/pcie/aer_inject.c:444:6: error: ‘struct pt_regs’ has no member named ‘ip

On Tue, Oct 9, 2018 at 5:40 AM Abdul Haleem <[email protected]> wrote:
>
> On Tue, 2018-10-09 at 20:47 +1100, Michael Ellerman wrote:
> > Abdul Haleem <[email protected]> writes:
> > > Greeting's
> > >
> > > Today's linux-next fails to build on ppc with below error
> > >
> > > drivers/pci/pcie/aer_inject.c: In function ‘aer_inject_ftrace_thunk’:
> > > drivers/pci/pcie/aer_inject.c:444:6: error: ‘struct pt_regs’ has no
> > > member named ‘ip’
> > > regs->ip = (unsigned long) hook->function;
> > > ^
> > > make[3]: *** [drivers/pci/pcie/aer_inject.o] Error 1
> > > make[2]: *** [drivers/pci/pcie] Error 2
> > > make[1]: *** [drivers/pci] Error 2
> > >
> > > Machine: Power 9
> > > kernel version: 4.19.0-rc7-next-20181008
> > > gcc version: 4.8.5 20150623
> > > config attached
> > >
> > > Recent code changes from these commits:
> > >
> > > c79ad38b36dd4967d67f83fc48bade37ee041a47 PCI/AER: Abstract AER interrupt handling
> > > 7b23285f930a8dedcbf749661cd0f2cc27f79be6 PCI/AER: Reuse existing pcie_port_find_device() interface
> > > e3fbcc7c4b130f81ea586183db561fa3ce9c6447 PCI/AER: Covertly inject errors with ftrace hooks
> >
> > I don't see this commit in today's linux next (20181009) so presumably
> > someone else has noticed and dropped the commit?
>
> Yes, the commit is dropped from next-20181009, and now build is fine.

I dropped those commits yesterday.