2013-04-04 18:27:16

by Bjorn Helgaas

[permalink] [raw]
Subject: Re: [PATCH 0/4] PCI/PM: D3cold support for system suspend

On Mon, Jan 28, 2013 at 9:34 PM, Huang Ying <[email protected]> wrote:
> [PATCH 1/4] PCI/ACPI: Add target state as parameter to pci_platform_pm_ops->run_wake
> [PATCH 2/4] PCI: Rename pci_dev->runtime_d3cold to pci_dev->set_d3cold
> [PATCH 3/4] PCI/PM: Set pci_dev->set_d3cold in pci_set_power_state
> [PATCH 4/4] PCI/PM: Enable D3cold support for system suspend

Do we still need these?

What problem do they solve? Or what new functionality do they add?


2013-04-04 20:10:28

by Rafael J. Wysocki

[permalink] [raw]
Subject: Re: [PATCH 0/4] PCI/PM: D3cold support for system suspend

On Thursday, April 04, 2013 12:26:52 PM Bjorn Helgaas wrote:
> On Mon, Jan 28, 2013 at 9:34 PM, Huang Ying <[email protected]> wrote:
> > [PATCH 1/4] PCI/ACPI: Add target state as parameter to pci_platform_pm_ops->run_wake
> > [PATCH 2/4] PCI: Rename pci_dev->runtime_d3cold to pci_dev->set_d3cold
> > [PATCH 3/4] PCI/PM: Set pci_dev->set_d3cold in pci_set_power_state
> > [PATCH 4/4] PCI/PM: Enable D3cold support for system suspend
>
> Do we still need these?
>
> What problem do they solve? Or what new functionality do they add?

They were supposed to allow PCI devices to be put into D3cold (via ACPI)
during system suspend, but I think it's better not to do that at this
point.

Thanks,
Rafael


--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.