2017-07-02 15:54:10

by Vincent Legoll

[permalink] [raw]
Subject: [PATCH] Make "SCSI Transports" a menuconfig to ease disabling it all

No need to get into the submenu to disable all SCSI Transports-related
config entries

Signed-off-by: Vincent Legoll <[email protected]>
---
drivers/scsi/Kconfig | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
index 3c52867..53c97cc 100644
--- a/drivers/scsi/Kconfig
+++ b/drivers/scsi/Kconfig
@@ -251,9 +251,12 @@ config SCSI_SCAN_ASYNC
Note that this setting also affects whether resuming from
system suspend will be performed asynchronously.

-menu "SCSI Transports"
+menuconfig SCSI_TRANSPORTS
+ tristate "SCSI Transports"
depends on SCSI

+if SCSI_TRANSPORTS
+
config SCSI_SPI_ATTRS
tristate "Parallel SCSI (SPI) Transport Attributes"
depends on SCSI
@@ -297,7 +300,7 @@ config SCSI_SRP_ATTRS
If you wish to export transport-specific information about
each attached SRP device to sysfs, say Y.

-endmenu
+endif # SCSI_TRANSPORTS

menuconfig SCSI_LOWLEVEL
bool "SCSI low-level drivers"
--
2.7.4


2017-07-03 18:30:22

by kernel test robot

[permalink] [raw]
Subject: Re: [PATCH] Make "SCSI Transports" a menuconfig to ease disabling it all

Hi Vincent,

[auto build test WARNING on mkp-scsi/for-next]
[also build test WARNING on v4.12]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url: https://github.com/0day-ci/linux/commits/Vincent-Legoll/Make-SCSI-Transports-a-menuconfig-to-ease-disabling-it-all/20170703-222401
base: https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next
config: m68k-sun3_defconfig (attached as .config)
compiler: m68k-linux-gcc (GCC) 4.9.0
reproduce:
wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=m68k

All warnings (new ones prefixed by >>):

warning: (ISCSI_TCP && SCSI_CXGB3_ISCSI && SCSI_CXGB4_ISCSI && SCSI_BNX2_ISCSI && BE2ISCSI && SCSI_QLA_ISCSI && QEDI && INFINIBAND_ISER) selects SCSI_ISCSI_ATTRS which has unmet direct dependencies (SCSI_TRANSPORTS && SCSI && NET)

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation


Attachments:
(No filename) (1.14 kB)
.config.gz (11.67 kB)
Download all attachments

2017-07-03 18:39:26

by kernel test robot

[permalink] [raw]
Subject: Re: [PATCH] Make "SCSI Transports" a menuconfig to ease disabling it all

Hi Vincent,

[auto build test WARNING on mkp-scsi/for-next]
[also build test WARNING on v4.12]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url: https://github.com/0day-ci/linux/commits/Vincent-Legoll/Make-SCSI-Transports-a-menuconfig-to-ease-disabling-it-all/20170703-222401
base: https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next
config: tile-tilegx_defconfig (attached as .config)
compiler: tilegx-linux-gcc (GCC) 4.6.2
reproduce:
wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=tile

All warnings (new ones prefixed by >>):

warning: (SCSI_AIC94XX && SCSI_HISI_SAS && SCSI_MVSAS && SCSI_ISCI && SCSI_PM8001) selects SCSI_SAS_LIBSAS which has unmet direct dependencies (SCSI_TRANSPORTS && SCSI)
warning: (SCSI_HPSA && SCSI_MPT3SAS && SCSI_SMARTPQI && FUSION_SAS) selects SCSI_SAS_ATTRS which has unmet direct dependencies (SCSI_TRANSPORTS && SCSI)

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation


Attachments:
(No filename) (1.24 kB)
.config.gz (16.11 kB)
Download all attachments

2017-07-04 10:53:19

by Vincent Legoll

[permalink] [raw]
Subject: Re: [PATCH] Make "SCSI Transports" a menuconfig to ease disabling it all

Hello,

On Sun, Jul 2, 2017 at 5:53 PM, Vincent Legoll <[email protected]> wrote:
> No need to get into the submenu to disable all SCSI Transports-related
> config entries
>
> Signed-off-by: Vincent Legoll <[email protected]>
> ---
> drivers/scsi/Kconfig | 7 +++++--

Please drop that patch, it will need to be fixed & tested more before resend

--
Vincent Legoll