2022-02-24 01:12:24

by Michael Walle

Subject: [PATCH v1 1/2] arm64: dts: imx8mn-evk: use proper names for PMIC outputs

Use the power signal names as given in the schematics of the reference
board.

Signed-off-by: Michael Walle <[email protected]>
---
arch/arm64/boot/dts/freescale/imx8mn-evk.dts | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mn-evk.dts b/arch/arm64/boot/dts/freescale/imx8mn-evk.dts
index b4225cfcb6d9..eaa06f49aef5 100644
--- a/arch/arm64/boot/dts/freescale/imx8mn-evk.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mn-evk.dts
@@ -41,7 +41,7 @@ pmic: pmic@25 {

regulators {
buck1: BUCK1{
- regulator-name = "BUCK1";
+ regulator-name = "VDD_ARM_0V9";
regulator-min-microvolt = <600000>;
regulator-max-microvolt = <2187500>;
regulator-boot-on;
@@ -50,7 +50,7 @@ buck1: BUCK1{
};

buck2: BUCK2 {
- regulator-name = "BUCK2";
+ regulator-name = "VDD_SOC";
regulator-min-microvolt = <600000>;
regulator-max-microvolt = <2187500>;
regulator-boot-on;
@@ -61,7 +61,7 @@ buck2: BUCK2 {
};

buck4: BUCK4{
- regulator-name = "BUCK4";
+ regulator-name = "VDD_3V3";
regulator-min-microvolt = <600000>;
regulator-max-microvolt = <3400000>;
regulator-boot-on;
@@ -69,7 +69,7 @@ buck4: BUCK4{
};

buck5: BUCK5{
- regulator-name = "BUCK5";
+ regulator-name = "VDD_1V8";
regulator-min-microvolt = <600000>;
regulator-max-microvolt = <3400000>;
regulator-boot-on;
@@ -77,7 +77,7 @@ buck5: BUCK5{
};

buck6: BUCK6 {
- regulator-name = "BUCK6";
+ regulator-name = "NVCC_DRAM_1V1";
regulator-min-microvolt = <600000>;
regulator-max-microvolt = <3400000>;
regulator-boot-on;
@@ -85,7 +85,7 @@ buck6: BUCK6 {
};

ldo1: LDO1 {
- regulator-name = "LDO1";
+ regulator-name = "NVCC_SNVS_1V8";
regulator-min-microvolt = <1600000>;
regulator-max-microvolt = <3300000>;
regulator-boot-on;
@@ -93,7 +93,7 @@ ldo1: LDO1 {
};

ldo2: LDO2 {
- regulator-name = "LDO2";
+ regulator-name = "VDD_SNVS_0V8";
regulator-min-microvolt = <800000>;
regulator-max-microvolt = <1150000>;
regulator-boot-on;
@@ -101,7 +101,7 @@ ldo2: LDO2 {
};

ldo3: LDO3 {
- regulator-name = "LDO3";
+ regulator-name = "VDDA_1V8";
regulator-min-microvolt = <800000>;
regulator-max-microvolt = <3300000>;
regulator-boot-on;
@@ -109,7 +109,7 @@ ldo3: LDO3 {
};

ldo4: LDO4 {
- regulator-name = "LDO4";
+ regulator-name = "VDD_PHY_1V2";
regulator-min-microvolt = <800000>;
regulator-max-microvolt = <3300000>;
regulator-boot-on;
@@ -117,7 +117,7 @@ ldo4: LDO4 {
};

ldo5: LDO5 {
- regulator-name = "LDO5";
+ regulator-name = "NVCC_SD2";
regulator-min-microvolt = <1800000>;
regulator-max-microvolt = <3300000>;
regulator-boot-on;
--
2.30.2

2022-02-24 07:56:40

by Heiko Thiery

Subject: Re: [PATCH v1 1/2] arm64: dts: imx8mn-evk: use proper names for PMIC outputs

Hi,

Am Mi., 23. Feb. 2022 um 22:06 Uhr schrieb Michael Walle <[email protected]>:
>
> Use the power signal names as given in the schematics of the reference
> board.
>
> Signed-off-by: Michael Walle <[email protected]>
> ---
> arch/arm64/boot/dts/freescale/imx8mn-evk.dts | 20 ++++++++++----------
> 1 file changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mn-evk.dts b/arch/arm64/boot/dts/freescale/imx8mn-evk.dts
> index b4225cfcb6d9..eaa06f49aef5 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mn-evk.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mn-evk.dts
> @@ -41,7 +41,7 @@ pmic: pmic@25 {
>
> regulators {
> buck1: BUCK1{
> - regulator-name = "BUCK1";
> + regulator-name = "VDD_ARM_0V9";

I think BUCK1 and BUCK2 are twisted here. This should be "VDD_SOC".

> regulator-min-microvolt = <600000>;
> regulator-max-microvolt = <2187500>;
> regulator-boot-on;
> @@ -50,7 +50,7 @@ buck1: BUCK1{
> };
>
> buck2: BUCK2 {
> - regulator-name = "BUCK2";
> + regulator-name = "VDD_SOC";

And this should be "VDD_ARM_0V9".

> regulator-min-microvolt = <600000>;
> regulator-max-microvolt = <2187500>;
> regulator-boot-on;
> @@ -61,7 +61,7 @@ buck2: BUCK2 {
> };
>
> buck4: BUCK4{
> - regulator-name = "BUCK4";
> + regulator-name = "VDD_3V3";
> regulator-min-microvolt = <600000>;
> regulator-max-microvolt = <3400000>;
> regulator-boot-on;
> @@ -69,7 +69,7 @@ buck4: BUCK4{
> };
>
> buck5: BUCK5{
> - regulator-name = "BUCK5";
> + regulator-name = "VDD_1V8";
> regulator-min-microvolt = <600000>;
> regulator-max-microvolt = <3400000>;
> regulator-boot-on;
> @@ -77,7 +77,7 @@ buck5: BUCK5{
> };
>
> buck6: BUCK6 {
> - regulator-name = "BUCK6";
> + regulator-name = "NVCC_DRAM_1V1";
> regulator-min-microvolt = <600000>;
> regulator-max-microvolt = <3400000>;
> regulator-boot-on;
> @@ -85,7 +85,7 @@ buck6: BUCK6 {
> };
>
> ldo1: LDO1 {
> - regulator-name = "LDO1";
> + regulator-name = "NVCC_SNVS_1V8";
> regulator-min-microvolt = <1600000>;
> regulator-max-microvolt = <3300000>;
> regulator-boot-on;
> @@ -93,7 +93,7 @@ ldo1: LDO1 {
> };
>
> ldo2: LDO2 {
> - regulator-name = "LDO2";
> + regulator-name = "VDD_SNVS_0V8";
> regulator-min-microvolt = <800000>;
> regulator-max-microvolt = <1150000>;
> regulator-boot-on;
> @@ -101,7 +101,7 @@ ldo2: LDO2 {
> };
>
> ldo3: LDO3 {
> - regulator-name = "LDO3";
> + regulator-name = "VDDA_1V8";
> regulator-min-microvolt = <800000>;
> regulator-max-microvolt = <3300000>;
> regulator-boot-on;
> @@ -109,7 +109,7 @@ ldo3: LDO3 {
> };
>
> ldo4: LDO4 {
> - regulator-name = "LDO4";
> + regulator-name = "VDD_PHY_1V2";
> regulator-min-microvolt = <800000>;
> regulator-max-microvolt = <3300000>;
> regulator-boot-on;
> @@ -117,7 +117,7 @@ ldo4: LDO4 {
> };
>
> ldo5: LDO5 {
> - regulator-name = "LDO5";
> + regulator-name = "NVCC_SD2";
> regulator-min-microvolt = <1800000>;
> regulator-max-microvolt = <3300000>;
> regulator-boot-on;
> --
> 2.30.2
>

--
Heiko

2022-02-24 11:38:59

by Michael Walle

Subject: Re: [PATCH v1 1/2] arm64: dts: imx8mn-evk: use proper names for PMIC outputs

Am 2022-02-24 08:29, schrieb Heiko Thiery:
> Hi,
>
> Am Mi., 23. Feb. 2022 um 22:06 Uhr schrieb Michael Walle
> <[email protected]>:
>>
>> Use the power signal names as given in the schematics of the reference
>> board.
>>
>> Signed-off-by: Michael Walle <[email protected]>
>> ---
>> arch/arm64/boot/dts/freescale/imx8mn-evk.dts | 20
>> ++++++++++----------
>> 1 file changed, 10 insertions(+), 10 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/freescale/imx8mn-evk.dts
>> b/arch/arm64/boot/dts/freescale/imx8mn-evk.dts
>> index b4225cfcb6d9..eaa06f49aef5 100644
>> --- a/arch/arm64/boot/dts/freescale/imx8mn-evk.dts
>> +++ b/arch/arm64/boot/dts/freescale/imx8mn-evk.dts
>> @@ -41,7 +41,7 @@ pmic: pmic@25 {
>>
>> regulators {
>> buck1: BUCK1{
>> - regulator-name = "BUCK1";
>> + regulator-name = "VDD_ARM_0V9";
>
> I think BUCK1 and BUCK2 are twisted here. This should be "VDD_SOC".
>
>> regulator-min-microvolt = <600000>;
>> regulator-max-microvolt = <2187500>;
>> regulator-boot-on;
>> @@ -50,7 +50,7 @@ buck1: BUCK1{
>> };
>>
>> buck2: BUCK2 {
>> - regulator-name = "BUCK2";
>> + regulator-name = "VDD_SOC";
>
> And this should be "VDD_ARM_0V9".

You are absolutely right. I noticed it on the 8MNANOD3L-EVK but
forgot to update these.

-michael