2021-03-08 09:05:08

by Heiko Thiery

[permalink] [raw]
Subject: [PATCH] arm64: configs: Enable PCIe support for imx8mq boards

Enable PCI_IMX6 to get PCI support for imx8mq boards like imx8mq-evk,
imx8mq-kontron-pitx-imx8m and imx8mq-zii-ultra. This increases the image
by 64k.

Signed-off-by: Heiko Thiery <[email protected]>
---
arch/arm64/configs/defconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index d612f633b771..4b7b4a8f1860 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -225,6 +225,7 @@ CONFIG_PCI_HOST_THUNDER_PEM=y
CONFIG_PCI_HOST_THUNDER_ECAM=y
CONFIG_PCIE_ROCKCHIP_HOST=m
CONFIG_PCIE_BRCMSTB=m
+CONFIG_PCI_IMX6=y
CONFIG_PCI_LAYERSCAPE=y
CONFIG_PCIE_LAYERSCAPE_GEN4=y
CONFIG_PCI_HISI=y
--
2.30.0


2021-03-08 13:01:00

by Heiko Thiery

[permalink] [raw]
Subject: Re: [PATCH] arm64: configs: Enable PCIe support for imx8mq boards

Hi all,

Am Mo., 8. März 2021 um 10:03 Uhr schrieb Heiko Thiery <[email protected]>:
>
> Enable PCI_IMX6 to get PCI support for imx8mq boards like imx8mq-evk,
> imx8mq-kontron-pitx-imx8m and imx8mq-zii-ultra. This increases the image
> by 64k.

The growth of 64k is not right.

Using the support script shows:

$ scripts/bloat-o-meter vmlinux vmlinux.with_pci
add/remove: 22/2 grow/shrink: 2/0 up/down: 8338/-16 (8322)
Function old new delta
imx6_pcie_probe - 1804 +1804
imx6_pcie_deassert_core_reset - 1356 +1356
imx6_pcie_of_match - 1200 +1200
imx6_pcie_start_link - 692 +692
imx6_pcie_suspend_noirq - 528 +528
imx6_pcie_init_phy - 496 +496
imx6_pcie_host_init - 336 +336
imx6_pcie_assert_core_reset - 332 +332
pcie_phy_write - 272 +272
imx6_pcie_driver - 200 +200
imx6_pcie_pm_ops - 184 +184
pcie_phy_read - 168 +168
imx6_pcie_resume_noirq - 156 +156
pcie_phy_wait_ack - 140 +140
pcie_phy_poll_ack.isra - 124 +124
imx6_pcie_quirk - 124 +124
drvdata - 60 +60
dw_pcie_ops 208 264 +56
imx6_pcie_init - 40 +40
imx6_pcie_shutdown - 32 +32
imx6_pcie_host_ops - 16 +16
e843419@0d4b_0001256e_27c4 - 8 +8
e843419@0590_00007810_4f0 - 8 +8
vermagic 76 82 +6
e843419@0c2e_0001064f_80 8 - -8
e843419@0633_00008212_13c 8 - -8
Total: Before=21884381, After=21892703, chg +0.04%


> Signed-off-by: Heiko Thiery <[email protected]>
> ---
> arch/arm64/configs/defconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index d612f633b771..4b7b4a8f1860 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -225,6 +225,7 @@ CONFIG_PCI_HOST_THUNDER_PEM=y
> CONFIG_PCI_HOST_THUNDER_ECAM=y
> CONFIG_PCIE_ROCKCHIP_HOST=m
> CONFIG_PCIE_BRCMSTB=m
> +CONFIG_PCI_IMX6=y
> CONFIG_PCI_LAYERSCAPE=y
> CONFIG_PCIE_LAYERSCAPE_GEN4=y
> CONFIG_PCI_HISI=y
> --
> 2.30.0
>

--
Heiko

2021-03-11 16:17:45

by Heiko Thiery

[permalink] [raw]
Subject: Re: [PATCH] arm64: configs: Enable PCIe support for imx8mq boards

Hi all,

Added some more to the CC list since they could be interested in this.

Am Mo., 8. März 2021 um 13:58 Uhr schrieb Heiko Thiery <[email protected]>:
>
> Hi all,
>
> Am Mo., 8. März 2021 um 10:03 Uhr schrieb Heiko Thiery <[email protected]>:
> >
> > Enable PCI_IMX6 to get PCI support for imx8mq boards like imx8mq-evk,
> > imx8mq-kontron-pitx-imx8m and imx8mq-zii-ultra. This increases the image
> > by 64k.
>
> The growth of 64k is not right.
>
> Using the support script shows:
>
> $ scripts/bloat-o-meter vmlinux vmlinux.with_pci
> add/remove: 22/2 grow/shrink: 2/0 up/down: 8338/-16 (8322)
> Function old new delta
> imx6_pcie_probe - 1804 +1804
> imx6_pcie_deassert_core_reset - 1356 +1356
> imx6_pcie_of_match - 1200 +1200
> imx6_pcie_start_link - 692 +692
> imx6_pcie_suspend_noirq - 528 +528
> imx6_pcie_init_phy - 496 +496
> imx6_pcie_host_init - 336 +336
> imx6_pcie_assert_core_reset - 332 +332
> pcie_phy_write - 272 +272
> imx6_pcie_driver - 200 +200
> imx6_pcie_pm_ops - 184 +184
> pcie_phy_read - 168 +168
> imx6_pcie_resume_noirq - 156 +156
> pcie_phy_wait_ack - 140 +140
> pcie_phy_poll_ack.isra - 124 +124
> imx6_pcie_quirk - 124 +124
> drvdata - 60 +60
> dw_pcie_ops 208 264 +56
> imx6_pcie_init - 40 +40
> imx6_pcie_shutdown - 32 +32
> imx6_pcie_host_ops - 16 +16
> e843419@0d4b_0001256e_27c4 - 8 +8
> e843419@0590_00007810_4f0 - 8 +8
> vermagic 76 82 +6
> e843419@0c2e_0001064f_80 8 - -8
> e843419@0633_00008212_13c 8 - -8
> Total: Before=21884381, After=21892703, chg +0.04%
>
>
> > Signed-off-by: Heiko Thiery <[email protected]>
> > ---
> > arch/arm64/configs/defconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> > index d612f633b771..4b7b4a8f1860 100644
> > --- a/arch/arm64/configs/defconfig
> > +++ b/arch/arm64/configs/defconfig
> > @@ -225,6 +225,7 @@ CONFIG_PCI_HOST_THUNDER_PEM=y
> > CONFIG_PCI_HOST_THUNDER_ECAM=y
> > CONFIG_PCIE_ROCKCHIP_HOST=m
> > CONFIG_PCIE_BRCMSTB=m
> > +CONFIG_PCI_IMX6=y
> > CONFIG_PCI_LAYERSCAPE=y
> > CONFIG_PCIE_LAYERSCAPE_GEN4=y
> > CONFIG_PCI_HISI=y
> > --
> > 2.30.0
> >


--
Heiko

2021-03-11 16:38:36

by Fabio Estevam

[permalink] [raw]
Subject: Re: [PATCH] arm64: configs: Enable PCIe support for imx8mq boards

Hi Heiko,

On Thu, Mar 11, 2021 at 1:13 PM Heiko Thiery <[email protected]> wrote:

> > > Enable PCI_IMX6 to get PCI support for imx8mq boards like imx8mq-evk,
> > > imx8mq-kontron-pitx-imx8m and imx8mq-zii-ultra. This increases the image
> > > by 64k.
> >
> > The growth of 64k is not right.

Please resend this patch without mentioning the image growth size.