2012-06-26 10:47:35

by Mark Brown

Subject: [PATCH] regulator: core: Check for failed voltage sets before checking for delay

There is no need to consider waiting for the voltage to ramp if we
didn't manage to set it and looking at the return value is going to be
cheaper than is_enabled().

Signed-off-by: Mark Brown <[email protected]>
---
drivers/regulator/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
index 531441a..da31b8a 100644
--- a/drivers/regulator/core.c
+++ b/drivers/regulator/core.c
@@ -2123,7 +2123,7 @@ static int _regulator_do_set_voltage(struct regulator_dev *rdev,
best_val = _regulator_get_voltage(rdev);

/* Call set_voltage_time_sel if successfully obtained old_selector */
- if (_regulator_is_enabled(rdev) && ret == 0 && old_selector >= 0 &&
+ if (ret == 0 && _regulator_is_enabled(rdev) && old_selector >= 0 &&
rdev->desc->ops->set_voltage_time_sel) {

delay = rdev->desc->ops->set_voltage_time_sel(rdev,
--
1.7.10

2012-06-26 10:52:08

by Axel Lin

Subject: Re: [PATCH] regulator: core: Check for failed voltage sets before checking for delay

2012/6/26 Mark Brown <[email protected]>:
> There is no need to consider waiting for the voltage to ramp if we
> didn't manage to set it and looking at the return value is going to be
> cheaper than is_enabled().
>
> Signed-off-by: Mark Brown <[email protected]>
Acked-by: Axel Lin <[email protected]>